[libvirt PATCH 00/11] syntax-check: Minimize http_sites
Reduce the number of exceptions we keep around by various means. Andrea Bolognani (11): syntax-check: Drop unused http_sites docs: apps: Drop Tivoli Provisioning Manager docs: apps: Drop Cracow Cloud One docs: apps: Drop Snooze util: Drop references to netlink.pdf docs: Use more generic URL for netcat docs: Update URL for libxml2 docs: Update URL for MinGW docs: Update various URLs docs: Use HTTPS where possible src: Use archive.org for dead URLs build-aux/syntax-check.mk | 18 +----------------- ci/README.rst | 6 +++--- docs/apps.rst | 22 +++------------------- docs/drvhyperv.rst | 2 +- docs/drvlxc.rst | 2 +- docs/remote.rst | 2 +- docs/uri.rst | 2 +- docs/windows.rst | 4 ++-- src/conf/nwfilter_conf.c | 4 ++-- src/conf/schemas/basictypes.rng | 2 +- src/util/virnetdevmacvlan.c | 5 +---- src/util/virnetlink.c | 4 +--- tests/openvzutilstest.conf | 2 +- 13 files changed, 19 insertions(+), 56 deletions(-) -- 2.35.3
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 2 -- 1 file changed, 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 6b54f830f1..64babd402c 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -907,7 +907,6 @@ http_sites += munin.projects.linpro.no http_sites += netcat.sourceforge.net http_sites += snooze.inria.fr http_sites += www.nimbusproject.org -http_sites += www.odin.com http_sites += www.sflow.net http_sites += xmlsoft.org http_sites += etallen.com @@ -922,7 +921,6 @@ http_sites += www.javvin.com http_sites += publib.boulder.ibm.com http_sites += kerneltrap.org http_sites += www.microsoft.com -http_sites += xenbits.xen.org http_sites += lovezutto.googlepages.com http_re= ($(subst $(space),|,$(http_sites))) -- 2.35.3
It doesn't seem to be a current product: there is no proper website for it, and the most recent installation instructions I've been able to locate are targeted at RHEL 6. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - docs/apps.rst | 6 ------ 2 files changed, 7 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 64babd402c..bc1b6a983a 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -918,7 +918,6 @@ http_sites += cc1.ifj.edu.pl http_sites += www.javvin.com # 404 links -http_sites += publib.boulder.ibm.com http_sites += kerneltrap.org http_sites += www.microsoft.com http_sites += lovezutto.googlepages.com diff --git a/docs/apps.rst b/docs/apps.rst index ef9781a0dc..95aa3c2ffb 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -258,12 +258,6 @@ Monitoring Provisioning ------------ -`Tivoli Provisioning Manager <https://www.ibm.com/developerworks/community/wikis/home?lang=en#!/wiki/Tivoli+Provisioning+Manager>`__ - Part of the IBM Tivoli family, Tivoli Provisioning Manager (TPM) is - an IT lifecycle automation product. It `uses - libvirt <http://publib.boulder.ibm.com/infocenter/tivihelp/v38r1/index.jsp?topic=/com.ibm.tivoli.tpm.apk.doc/libvirt_package.html>`__ - for communication with virtualization hosts and guest domains. - `Foreman <https://theforeman.org>`__ Foreman is an open source web based application aimed to be a Single Address For All Machines Life Cycle Management. Foreman: -- 2.35.3
The website is still up, although the latency is so high that it could hardly considered usable; the software itself was last updated in 2015. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - docs/apps.rst | 5 ----- 2 files changed, 6 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index bc1b6a983a..d922299b0a 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -914,7 +914,6 @@ http_sites += etallen.com # dead sites http_sites += blog.lystor.org.ua http_sites += blog.mes-stats.fr -http_sites += cc1.ifj.edu.pl http_sites += www.javvin.com # 404 links diff --git a/docs/apps.rst b/docs/apps.rst index 95aa3c2ffb..71865c4176 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -149,11 +149,6 @@ Desktop applications Infrastructure as a Service (IaaS) ---------------------------------- -`Cracow Cloud One <http://cc1.ifj.edu.pl>`__ - The CC1 system provides a complete solution for Private Cloud - Computing. An intuitive web access interface with an administration - module and simple installation procedure make it easy to benefit from - private Cloud Computing technology. `Eucalyptus <https://github.com/eucalyptus/eucalyptus>`__ Eucalyptus is an on-premise Infrastructure as a Service cloud software platform that is open source and AWS-compatible. Eucalyptus -- 2.35.3
The website is still up, but the software itself was last updated in 2014. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - docs/apps.rst | 5 ----- 2 files changed, 6 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index d922299b0a..94a03cab98 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -905,7 +905,6 @@ http_sites += mah.everybody.org http_sites += mingw.org http_sites += munin.projects.linpro.no http_sites += netcat.sourceforge.net -http_sites += snooze.inria.fr http_sites += www.nimbusproject.org http_sites += www.sflow.net http_sites += xmlsoft.org diff --git a/docs/apps.rst b/docs/apps.rst index 71865c4176..4d8c87d34d 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -159,11 +159,6 @@ Infrastructure as a Service (IaaS) Infrastructure-as-a-Service (IaaS) capabilities to the scientific community. It uses libvirt for communication with all KVM and Xen virtual machines. -`Snooze <http://snooze.inria.fr>`__ - Snooze is an open-source scalable, autonomic, and energy-efficient - virtual machine (VM) management framework for private clouds. It - integrates libvirt for VM monitoring, live migration, and life-cycle - management. `OpenStack <https://www.openstack.org>`__ OpenStack is a "cloud operating system" usable for both public and private clouds. Its various parts take care of compute, storage and -- 2.35.3
The website no longer exists and the PDF file can't even be retrieved via archive.org. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - src/util/virnetdevmacvlan.c | 5 +---- src/util/virnetlink.c | 4 +--- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 94a03cab98..7d7cf90b4b 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -918,7 +918,6 @@ http_sites += www.javvin.com # 404 links http_sites += kerneltrap.org http_sites += www.microsoft.com -http_sites += lovezutto.googlepages.com http_re= ($(subst $(space),|,$(http_sites))) diff --git a/src/util/virnetdevmacvlan.c b/src/util/virnetdevmacvlan.c index fd8c20e059..1985d1028a 100644 --- a/src/util/virnetdevmacvlan.c +++ b/src/util/virnetdevmacvlan.c @@ -16,10 +16,7 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Notes: - * netlink: http://lovezutto.googlepages.com/netlink.pdf - * iproute2 package - * + * Notes: iproute2 package */ #include <config.h> diff --git a/src/util/virnetlink.c b/src/util/virnetlink.c index 04a39a905b..c6b015d7a9 100644 --- a/src/util/virnetlink.c +++ b/src/util/virnetlink.c @@ -16,9 +16,7 @@ * License along with this library. If not, see * <http://www.gnu.org/licenses/>. * - * Notes: - * netlink: http://lovezutto.googlepages.com/netlink.pdf - * iproute2 package + * Notes: iproute2 package */ #include <config.h> -- 2.35.3
GNU netcat was last updated in 2004. These days, most operating systems will include either the nmap or OpenBSD variant of the tool. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - docs/remote.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 7d7cf90b4b..82cbac3daf 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -904,7 +904,6 @@ http_sites += 0pointer.de http_sites += mah.everybody.org http_sites += mingw.org http_sites += munin.projects.linpro.no -http_sites += netcat.sourceforge.net http_sites += www.nimbusproject.org http_sites += www.sflow.net http_sites += xmlsoft.org diff --git a/docs/remote.rst b/docs/remote.rst index 933166144d..bcc394e083 100644 --- a/docs/remote.rst +++ b/docs/remote.rst @@ -55,7 +55,7 @@ Remote libvirt supports a range of transports: ``ssh`` Transported over an ordinary `ssh (secure shell) <https://www.openssh.com/>`__ connection. Requires `Netcat - (nc) <http://netcat.sourceforge.net/>`__ installed and libvirtd should be + (nc) <https://en.wikipedia.org/wiki/Netcat>`__ installed and libvirtd should be running on the remote machine. You should use some sort of ssh key management (eg. `ssh-agent <http://mah.everybody.org/docs/ssh>`__) otherwise programs which use this transport will stop to ask for a password. -- 2.35.3
The project is developed as part of GNOME these days, and the old URL redirects to GNOME's GitLab instance. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - docs/uri.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 82cbac3daf..c914840f86 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -906,7 +906,6 @@ http_sites += mingw.org http_sites += munin.projects.linpro.no http_sites += www.nimbusproject.org http_sites += www.sflow.net -http_sites += xmlsoft.org http_sites += etallen.com # dead sites diff --git a/docs/uri.rst b/docs/uri.rst index 4efd634087..3ca3fb12c3 100644 --- a/docs/uri.rst +++ b/docs/uri.rst @@ -178,7 +178,7 @@ Extra parameters can be added to remote URIs as part of the query string (the part following ``?``). Remote URIs understand the extra parameters shown below. Any others are passed unmodified through to the back end. Note that parameter values must be -`URI-escaped <http://xmlsoft.org/html/libxml-uri.html#xmlURIEscapeStr>`__. +`URI-escaped <https://gnome.pages.gitlab.gnome.org/libxml2/devhelp/libxml2-uri.html#xmlURIEscapeStr>`__. All transports support the following parameters: -- 2.35.3
The MinGW-w64 project has effectively replaced the original MinGW project, and distributions such as Fedora have been shipping packages based on the former for years now. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - ci/README.rst | 6 +++--- docs/windows.rst | 4 ++-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index c914840f86..e0012ae82f 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -902,7 +902,6 @@ http_sites += herp.derp # HTTP-only sites http_sites += 0pointer.de http_sites += mah.everybody.org -http_sites += mingw.org http_sites += munin.projects.linpro.no http_sites += www.nimbusproject.org http_sites += www.sflow.net diff --git a/ci/README.rst b/ci/README.rst index 6c6c6f95b3..e3c60c54d1 100644 --- a/ci/README.rst +++ b/ci/README.rst @@ -10,8 +10,8 @@ Cirrus CI integration ===================== libvirt currently supports three non-Linux operating systems: Windows, FreeBSD -and macOS. Windows cross-builds can be prepared on Linux by using `MinGW`_, but -for both FreeBSD and macOS we need to use the actual operating system, and +and macOS. Windows cross-builds can be prepared on Linux by using `MinGW-w64`_, +but for both FreeBSD and macOS we need to use the actual operating system, and unfortunately GitLab shared runners are currently not available for either. To work around this limitation, we take advantage of `Cirrus CI`_'s free @@ -61,7 +61,7 @@ repository as usual and you'll automatically get the additional CI coverage. .. _Cirrus CI GitHub app: https://github.com/marketplace/cirrus-ci .. _Cirrus CI settings: https://cirrus-ci.com/settings/profile/ .. _Cirrus CI: https://cirrus-ci.com/ -.. _MinGW: http://mingw.org/ +.. _MinGW-w64: https://www.mingw-w64.org/ .. _cirrus-run: https://github.com/sio/cirrus-run/ diff --git a/docs/windows.rst b/docs/windows.rst index 5bfc2fa5ba..b9aa5626cf 100644 --- a/docs/windows.rst +++ b/docs/windows.rst @@ -104,8 +104,8 @@ desired <contact.html>`__. Compiling yourself ------------------ -Libvirt can be compiled on Windows using the free `MinGW -compiler <http://www.mingw.org/>`__. +Libvirt can be compiled on Windows using the free `MinGW-w64 +compiler <https://www.mingw-w64.org/>`__. MSYS Build script ~~~~~~~~~~~~~~~~~ -- 2.35.3
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 4 ---- docs/apps.rst | 6 +++--- docs/drvhyperv.rst | 2 +- 3 files changed, 4 insertions(+), 8 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index e0012ae82f..e0d2a7fe6c 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -902,9 +902,6 @@ http_sites += herp.derp # HTTP-only sites http_sites += 0pointer.de http_sites += mah.everybody.org -http_sites += munin.projects.linpro.no -http_sites += www.nimbusproject.org -http_sites += www.sflow.net http_sites += etallen.com # dead sites @@ -914,7 +911,6 @@ http_sites += www.javvin.com # 404 links http_sites += kerneltrap.org -http_sites += www.microsoft.com http_re= ($(subst $(space),|,$(http_sites))) diff --git a/docs/apps.rst b/docs/apps.rst index 4d8c87d34d..1a25c0a21e 100644 --- a/docs/apps.rst +++ b/docs/apps.rst @@ -154,7 +154,7 @@ Infrastructure as a Service (IaaS) software platform that is open source and AWS-compatible. Eucalyptus uses libvirt virtualization API to directly interact with Xen and KVM hypervisors. -`Nimbus <http://www.nimbusproject.org>`__ +`Nimbus <https://www.nimbusproject.org/>`__ Nimbus is an open-source toolkit focused on providing Infrastructure-as-a-Service (IaaS) capabilities to the scientific community. It uses libvirt for communication with all KVM and Xen @@ -224,14 +224,14 @@ Monitoring for each guest without installing collectd on the guest systems. For a full description, please refer to the libvirt section in the collectd.conf(5) manual page. -`Host sFlow <https://www.sflow.net/>`__ +`Host sFlow <https://sflow.net/>`__ Host sFlow is a lightweight agent running on KVM hypervisors that links to libvirt library and exports standardized cpu, memory, network and disk metrics for all virtual machines. `Munin <https://honk.sigxcpu.org/projects/libvirt/#munin>`__ The plugins provided by Guido Günther allow to monitor various things like network and block I/O with - `Munin <http://munin.projects.linpro.no/>`__. + `Munin <https://munin-monitoring.org/>`__. `Nagios-virt <https://people.redhat.com/rjones/nagios-virt/>`__ Nagios-virt is a configuration tool to add monitoring of your virtualised domains to `Nagios <https://www.nagios.org/>`__. You can diff --git a/docs/drvhyperv.rst b/docs/drvhyperv.rst index 17d620f29c..1760cc1fdb 100644 --- a/docs/drvhyperv.rst +++ b/docs/drvhyperv.rst @@ -9,7 +9,7 @@ The libvirt Microsoft Hyper-V driver can manage Hyper-V 2012 R2 and newer. Project Links ------------- -- The `Microsoft Hyper-V <http://www.microsoft.com/hyper-v-server/>`__ +- The `Microsoft Hyper-V <https://docs.microsoft.com/en-us/windows-server/virtualization/hyper-v/hyper-v-on-windows-server>`__ hypervisor Connections to the Microsoft Hyper-V driver -- 2.35.3
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 1 - docs/drvlxc.rst | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index e0d2a7fe6c..762b2e5ccc 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -900,7 +900,6 @@ http_sites += example.org http_sites += herp.derp # HTTP-only sites -http_sites += 0pointer.de http_sites += mah.everybody.org http_sites += etallen.com diff --git a/docs/drvlxc.rst b/docs/drvlxc.rst index b88323b165..24501cae11 100644 --- a/docs/drvlxc.rst +++ b/docs/drvlxc.rst @@ -245,7 +245,7 @@ Systemd Socket Activation Integration The libvirt LXC driver provides the ability to pass across pre-opened file descriptors when starting LXC guests. This allows for libvirt LXC to support systemd's `socket activation -capability <http://0pointer.de/blog/projects/socket-activated-containers.html>`__, +capability <https://0pointer.de/blog/projects/socket-activated-containers.html>`__, where an incoming client connection in the host OS will trigger the startup of a container, which runs another copy of systemd which gets passed the server socket, and then activates the actual service handler in the container. -- 2.35.3
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- build-aux/syntax-check.mk | 4 +--- src/conf/nwfilter_conf.c | 4 ++-- src/conf/schemas/basictypes.rng | 2 +- tests/openvzutilstest.conf | 2 +- 4 files changed, 5 insertions(+), 7 deletions(-) diff --git a/build-aux/syntax-check.mk b/build-aux/syntax-check.mk index 762b2e5ccc..9cc88ed896 100644 --- a/build-aux/syntax-check.mk +++ b/build-aux/syntax-check.mk @@ -903,12 +903,10 @@ http_sites += herp.derp http_sites += mah.everybody.org http_sites += etallen.com -# dead sites +# HTTP-only dead sites accessed via archive.org http_sites += blog.lystor.org.ua http_sites += blog.mes-stats.fr http_sites += www.javvin.com - -# 404 links http_sites += kerneltrap.org http_re= ($(subst $(space),|,$(http_sites))) diff --git a/src/conf/nwfilter_conf.c b/src/conf/nwfilter_conf.c index 5171145c75..a4baa75117 100644 --- a/src/conf/nwfilter_conf.c +++ b/src/conf/nwfilter_conf.c @@ -1107,8 +1107,8 @@ static const virXMLAttr2Struct vlanAttributes[] = { } }; -/* STP is documented by IEEE 802.1D; for a synopsis, - * see http://www.javvin.com/protocolSTP.html */ +/* STP is documented by IEEE 802.1D; for a synopsis, see + * https://web.archive.org/web/20130530200728/http://www.javvin.com/protocolSTP... */ static const virXMLAttr2Struct stpAttributes[] = { /* spanning tree uses a special destination MAC address */ { diff --git a/src/conf/schemas/basictypes.rng b/src/conf/schemas/basictypes.rng index ae4d568222..2d6f1a2c84 100644 --- a/src/conf/schemas/basictypes.rng +++ b/src/conf/schemas/basictypes.rng @@ -234,7 +234,7 @@ </data> </define> - <!-- Based on http://blog.mes-stats.fr/2008/10/09/regex-ipv4-et-ipv6 --> + <!-- Based on https://web.archive.org/web/20090503193311/http://blog.mes-stats.fr/2008/10/... --> <define name="ipv6Addr"> <data type="string"> <!-- To understand this better, take apart the toplevel "|"s --> diff --git a/tests/openvzutilstest.conf b/tests/openvzutilstest.conf index c5d048c5f6..d3827d8f0c 100644 --- a/tests/openvzutilstest.conf +++ b/tests/openvzutilstest.conf @@ -1,4 +1,4 @@ -# sample config from http://blog.lystor.org.ua/2009/11/openvz-configuration-example.html +# sample config from https://web.archive.org/web/20111228161814/http://blog.lystor.org.ua/2009/11... ONBOOT="yes" -- 2.35.3
On 5/24/22 10:45, Andrea Bolognani wrote:
Reduce the number of exceptions we keep around by various means.
Andrea Bolognani (11): syntax-check: Drop unused http_sites docs: apps: Drop Tivoli Provisioning Manager docs: apps: Drop Cracow Cloud One docs: apps: Drop Snooze util: Drop references to netlink.pdf docs: Use more generic URL for netcat docs: Update URL for libxml2 docs: Update URL for MinGW docs: Update various URLs docs: Use HTTPS where possible src: Use archive.org for dead URLs
build-aux/syntax-check.mk | 18 +----------------- ci/README.rst | 6 +++--- docs/apps.rst | 22 +++------------------- docs/drvhyperv.rst | 2 +- docs/drvlxc.rst | 2 +- docs/remote.rst | 2 +- docs/uri.rst | 2 +- docs/windows.rst | 4 ++-- src/conf/nwfilter_conf.c | 4 ++-- src/conf/schemas/basictypes.rng | 2 +- src/util/virnetdevmacvlan.c | 5 +---- src/util/virnetlink.c | 4 +--- tests/openvzutilstest.conf | 2 +- 13 files changed, 19 insertions(+), 56 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Andrea Bolognani -
Michal Prívozník