From 918f814aacb258ea9641ed1bb9e48baf2d93082a Mon Sep 17 00:00:00 2001 From: Zhou Yimin <zhouyimin@huawei.com> Date: Fri, 21 Mar 2014 14:52:40 +0800 Subject: [PATCH] virlog: Modify virLogParseDefaultPriority's comment of return value

virLogParseDefaultPriority's successful return value is the same as virLogSetDefaultPriority's successful return value. So it should be 0 rather than the parsed log level. Signed-off-by: Zhou Yimin <zhouyimin@huawei.com> --- src/util/virlog.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/util/virlog.c b/src/util/virlog.c index 5d4d3c7..9ae30b6 100644 --- a/src/util/virlog.c +++ b/src/util/virlog.c @@ -1365,7 +1365,7 @@ virLogGetNbOutputs(void) * 3: WARNING * 4: ERROR * - * Returns the parsed log level or -1 on error. + * Returns 0 if successful, -1 in case of error. */ int virLogParseDefaultPriority(const char *priority) -- 1.7.12.4 -----Original Message----- From: Michal Privoznik [mailto:mprivozn@redhat.com] Sent: Thursday, March 20, 2014 10:56 PM To: Wangrui (K); libvir-list@redhat.com Cc: zhouyimin Zhou(Yimin); Yanqiangjun; Zhaoyanbin (A) Subject: Re: [libvirt] [PATCH] virlog: Modify virLogParseDefaultPriority's comment of return value On 17.03.2014 13:31, Wangrui (K) wrote:

virLogParseDefaultPriority's successful return value is the same as

virLogSetDefaultPriority's successful return value. So it should be 0

rather than the parsed log level.

Signed-off-by: Zhou Yimin <zhouyimin@huawei.com>

---

src/util/virlog.c | 2 +-

1 file changed, 1 insertion(+), 1 deletion(-)

I was just about to review this patch, but it does not apply anymore. Can you rebase and resend? Michal