[libvirt] [libvirt-php] Remove strip from installation
Make it able to generate debuginfo package. --- configure.ac | 1 - src/Makefile.am | 2 +- 2 files changed, 1 insertions(+), 2 deletions(-) diff --git a/configure.ac b/configure.ac index 8149349..5ebe416 100644 --- a/configure.ac +++ b/configure.ac @@ -11,7 +11,6 @@ AC_LANG([C]) AC_PROG_INSTALL AC_PROG_SED AC_PROG_AWK -AC_CHECK_TOOL([STRIP], [strip]) AC_CHECK_TOOL([ECHO], [echo]) AC_CHECK_TOOL([RM], [rm]) diff --git a/src/Makefile.am b/src/Makefile.am index edb5df4..76ebee6 100644 --- a/src/Makefile.am +++ b/src/Makefile.am @@ -13,7 +13,7 @@ build: $(ECHO) "Extension compiled as $(PACKAGE).so" install-exec-local: - $(INSTALL) -m 644 -D --strip $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so + $(INSTALL) -m 644 -D $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so $(INSTALL) -m 755 -d $(DESTDIR)$(PHPCDIR) $(ECHO) "extension=$(PACKAGE).so" > $(DESTDIR)$(PHPCDIR)/libvirt-php.ini -- 1.7.3.4 �
On 04/01/2011 07:25 AM, Lyre wrote:
Make it able to generate debuginfo package.
Thanks, pushed now! I don't know why this is not there but maybe I added this to f14 branch only since it's necessary to generate debuginfo packages for Fedora. However I applied your patch to master branch :) Thanks again, Michal -- Michal Novotny <minovotn@redhat.com>, RHCE Virtualization Team (xen userspace), Red Hat
于 2011年04月01日 16:33, Michal Novotny 写道:
Make it able to generate debuginfo package. Thanks, pushed now! I don't know why this is not there but maybe I added
On 04/01/2011 07:25 AM, Lyre wrote: this to f14 branch only since it's necessary to generate debuginfo packages for Fedora. However I applied your patch to master branch :)
Thanks again, Michal
Hi michal: I'm debugging a problem that maybe caused by libvirt-php. However if we strip the library during installation, we wouldn't be able to build the debuginfo package. The spec file wouldn't build this package, but this change make it possible. BTW, I've noticed that there's a bug in set_error(), I'll submit it after test.r
于 2011年04月01日 16:33, Michal Novotny 写道:
Make it able to generate debuginfo package. Thanks, pushed now! I don't know why this is not there but maybe I added
On 04/01/2011 07:25 AM, Lyre wrote: this to f14 branch only since it's necessary to generate debuginfo packages for Fedora. However I applied your patch to master branch :)
Thanks again, Michal
Hi michal:
I'm debugging a problem that maybe caused by libvirt-php. However if we strip the library during installation, we wouldn't be able to build the debuginfo package. The spec file wouldn't build this package, but this change make it possible.
BTW, I've noticed that there's a bug in set_error(), I'll submit it after test.r Hi,
On 04/01/2011 11:23 AM, Lyre wrote: thanks. Now there's already set_error_if_unset() function so please make sure you're working against the latest tree, i.e. be sure to run `git pull` before you start working on that. Michal -- Michal Novotny <minovotn@redhat.com>, RHCE Virtualization Team (xen userspace), Red Hat
On 03/31/2011 11:25 PM, Lyre wrote:
Make it able to generate debuginfo package.
install-exec-local: - $(INSTALL) -m 644 -D --strip $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so + $(INSTALL) -m 644 -D $(PACKAGE).so $(DESTDIR)$(PHPEDIR)/$(PACKAGE).so $(INSTALL) -m 755 -d $(DESTDIR)$(PHPCDIR) $(ECHO) "extension=$(PACKAGE).so" > $(DESTDIR)$(PHPCDIR)/libvirt-php.ini
Good change. GNU Coding Standards recommend, and Automake provides, 'make install' with debug vs. 'make install-strip' with stripped binaries; and 'make install-strip' works by reinvoking 'make install' with $(INSTALL) redefined to also do stripping. So it is still possible to install things stripped by specifically asking for it, but stripping should never be the default. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (3)
-
Eric Blake -
Lyre -
Michal Novotny