[Libvir] Patch: Driver private data
This patch is more aspirational than currently useful. Only the remote patch would use driver->private, but I think others should be changed to do so too. Rich. -- Emerging Technologies, Red Hat http://et.redhat.com/~rjones/ 64 Baker Street, London, W1U 7DF Mobile: +44 7866 314 421 "[Negative numbers] darken the very whole doctrines of the equations and make dark of the things which are in their nature excessively obvious and simple" (Francis Maseres FRS, mathematician, 1759)
On Wed, Feb 28, 2007 at 04:27:05PM +0000, Richard W.M. Jones wrote:
This patch is more aspirational than currently useful. Only the remote patch would use driver->private, but I think others should be changed to do so too.
Certainly - I'll update the QEMU & Test drivers at least once we've got this in. The Xen driver can be best addressed when they are merged. Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Wed, 2007-02-28 at 17:06 +0000, Daniel P. Berrange wrote:
On Wed, Feb 28, 2007 at 04:27:05PM +0000, Richard W.M. Jones wrote:
This patch is more aspirational than currently useful. Only the remote patch would use driver->private, but I think others should be changed to do so too.
Certainly - I'll update the QEMU & Test drivers at least once we've got this in. The Xen driver can be best addressed when they are merged.
Cool, be careful with the QEMU driver, though. i.e. you can have a situation where one driver is used for domains, and the QEMU driver is used for networks. Or, indeed, the QEMU driver might be used for both. We probably want a networkPrivate pointer which will also contain the qemuPrivate data and the driver will always prefer networkPrivate if it is non-NULL. Something like that. Cheers, Mark.
participants (3)
-
Daniel P. Berrange -
Mark McLoughlin -
Richard W.M. Jones