[libvirt] [PATCH] change permissions of directories in cgroups
Hi, This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x). I guess 0655 is not expected and just a mistake, or is there a special reason? Thanks, ozaki-r Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
From 4829855bc0baa3c75806f106bc0e54eb1da75eea Mon Sep 17 00:00:00 2001 From: Ryota Ozaki <ozaki.ryota@gmail.com> Date: Fri, 8 May 2009 03:23:50 +0900 Subject: [PATCH] change permissions of directories in cgroups
This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x). --- src/cgroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/cgroup.c b/src/cgroup.c index d1d44a2..50517e2 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -436,7 +436,7 @@ static int virCgroupMakeGroup(const char *name) virCgroupFree(&root); if (access(path, F_OK) != 0) { - if (mkdir(path, 0655) < 0) { + if (mkdir(path, 0755) < 0) { rc = -errno; VIR_FREE(path); break; -- 1.6.0.6
Quoting Ryota Ozaki (ozaki.ryota@gmail.com):
Hi,
This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x).
I guess 0655 is not expected and just a mistake, or is there a special reason?
Haha, that sure seems like a mistake. Good catch.
Thanks, ozaki-r
Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
Acked-by: Serge Hallyn <serue@us.ibm.com> thanks, -serge
From 4829855bc0baa3c75806f106bc0e54eb1da75eea Mon Sep 17 00:00:00 2001 From: Ryota Ozaki <ozaki.ryota@gmail.com> Date: Fri, 8 May 2009 03:23:50 +0900 Subject: [PATCH] change permissions of directories in cgroups
This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x). --- src/cgroup.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/cgroup.c b/src/cgroup.c index d1d44a2..50517e2 100644 --- a/src/cgroup.c +++ b/src/cgroup.c @@ -436,7 +436,7 @@ static int virCgroupMakeGroup(const char *name) virCgroupFree(&root);
if (access(path, F_OK) != 0) { - if (mkdir(path, 0655) < 0) { + if (mkdir(path, 0755) < 0) { rc = -errno; VIR_FREE(path); break; -- 1.6.0.6
-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, May 08, 2009 at 09:03:32AM +0900, Ryota Ozaki wrote:
Hi,
This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x).
I guess 0655 is not expected and just a mistake, or is there a special reason?
ACK, this looks fine. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Fri, May 08, 2009 at 09:03:32AM +0900, Ryota Ozaki wrote:
Hi,
This patch creates a directory in cgroups with an ordinary permission 0755 (rwxr-xr-x) instead of 0655 (rw-r-xr-x).
I guess 0655 is not expected and just a mistake, or is there a special reason?
I've committed this patch now Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (3)
-
Daniel P. Berrange -
Ryota Ozaki -
Serge E. Hallyn