11:57 a.m.
I'm a bit conflicted about this one: on one hand, unlike Debian 8 we
haven't really run into any issue with Ubuntu 16.04, we can still
build almost all projects on it, and it doesn't require any crazy
hacks to maintain; on the other hand, perhaps the reason why we still
claim we can build almost all projects on it is because we don't
actually run any build on it, either on CentOS CI or on Travis CI :D
Anyway: here are the patches, let's see what other people think.
Andrea Bolognani (2):
Stop building on Ubuntu 16.04
guests: Drop Ubuntu 18.04
guests/host_vars/libvirt-ubuntu-16/docker.yml | 2 --
.../host_vars/libvirt-ubuntu-16/install.yml | 2 --
guests/host_vars/libvirt-ubuntu-16/main.yml | 22 -------------------
guests/inventory | 1 -
guests/playbooks/build/jobs/defaults.yml | 1 -
.../playbooks/build/projects/libvirt-dbus.yml | 5 +----
.../build/projects/libvirt-go-xml.yml | 1 -
.../playbooks/build/projects/libvirt-go.yml | 1 -
.../build/projects/libvirt-ocaml.yml | 1 -
.../build/projects/libvirt-sandbox.yml | 1 -
.../playbooks/build/projects/libvirt-tck.yml | 1 -
guests/playbooks/build/projects/libvirt.yml | 1 -
guests/playbooks/build/projects/osinfo-db.yml | 1 -
.../playbooks/build/projects/virt-manager.yml | 4 +---
guests/vars/mappings.yml | 3 ---
15 files changed, 2 insertions(+), 45 deletions(-)
delete mode 100644 guests/host_vars/libvirt-ubuntu-16/docker.yml
delete mode 100644 guests/host_vars/libvirt-ubuntu-16/install.yml
delete mode 100644 guests/host_vars/libvirt-ubuntu-16/main.yml
--
2.20.1
11:57 a.m.
New subject: [libvirt] [jenkins-ci PATCH 1/2] Stop building on Ubuntu 16.04
According to our platform support policy[1], we only support
an Ubuntu LTS release for two years after the following LTS
has been released, which means dropping Ubuntu 16.04 support
is almost a year overdue.
[1] https://libvirt.org/platforms.html
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/playbooks/build/jobs/defaults.yml | 1 -
guests/playbooks/build/projects/libvirt-dbus.yml | 5 +----
guests/playbooks/build/projects/libvirt-go-xml.yml | 1 -
guests/playbooks/build/projects/libvirt-go.yml | 1 -
guests/playbooks/build/projects/libvirt-ocaml.yml | 1 -
guests/playbooks/build/projects/libvirt-sandbox.yml | 1 -
guests/playbooks/build/projects/libvirt-tck.yml | 1 -
guests/playbooks/build/projects/libvirt.yml | 1 -
guests/playbooks/build/projects/osinfo-db.yml | 1 -
guests/playbooks/build/projects/virt-manager.yml | 4 +---
10 files changed, 2 insertions(+), 15 deletions(-)
diff --git a/guests/playbooks/build/jobs/defaults.yml
b/guests/playbooks/build/jobs/defaults.yml
index 61ef872..e5a6119 100644
--- a/guests/playbooks/build/jobs/defaults.yml
+++ b/guests/playbooks/build/jobs/defaults.yml
@@ -9,7 +9,6 @@ all_machines:
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
rpm_machines:
- libvirt-centos-7
diff --git a/guests/playbooks/build/projects/libvirt-dbus.yml
b/guests/playbooks/build/projects/libvirt-dbus.yml
index b00d7af..85e0a5a 100644
--- a/guests/playbooks/build/projects/libvirt-dbus.yml
+++ b/guests/playbooks/build/projects/libvirt-dbus.yml
@@ -11,7 +11,6 @@
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
archive_format: xz
git_url: '{{ git_urls["libvirt-dbus"][git_remote] }}'
@@ -29,12 +28,10 @@
- libvirt-fedora-28
- libvirt-fedora-29
- libvirt-fedora-rawhide
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
- include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
vars:
- # CentOS 7 doesn't include Python 3 and the version in Ubuntu
- # 16.04 is too old
+ # CentOS 7 doesn't include Python 3
machines:
- libvirt-debian-9
- libvirt-debian-sid
diff --git a/guests/playbooks/build/projects/libvirt-go-xml.yml
b/guests/playbooks/build/projects/libvirt-go-xml.yml
index 94ca7ae..b15726d 100644
--- a/guests/playbooks/build/projects/libvirt-go-xml.yml
+++ b/guests/playbooks/build/projects/libvirt-go-xml.yml
@@ -10,7 +10,6 @@
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
archive_format: gz
git_url: '{{ git_urls["libvirt-go-xml"][git_remote] }}'
diff --git a/guests/playbooks/build/projects/libvirt-go.yml
b/guests/playbooks/build/projects/libvirt-go.yml
index bcca302..dfe88b2 100644
--- a/guests/playbooks/build/projects/libvirt-go.yml
+++ b/guests/playbooks/build/projects/libvirt-go.yml
@@ -10,7 +10,6 @@
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
archive_format: gz
git_url: '{{ git_urls["libvirt-go"][git_remote] }}'
diff --git a/guests/playbooks/build/projects/libvirt-ocaml.yml
b/guests/playbooks/build/projects/libvirt-ocaml.yml
index 629e316..df17798 100644
--- a/guests/playbooks/build/projects/libvirt-ocaml.yml
+++ b/guests/playbooks/build/projects/libvirt-ocaml.yml
@@ -11,7 +11,6 @@
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
archive_format: xz
git_url: '{{ git_urls["libvirt-ocaml"][git_remote] }}'
diff --git a/guests/playbooks/build/projects/libvirt-sandbox.yml
b/guests/playbooks/build/projects/libvirt-sandbox.yml
index 6dd866c..8562141 100644
--- a/guests/playbooks/build/projects/libvirt-sandbox.yml
+++ b/guests/playbooks/build/projects/libvirt-sandbox.yml
@@ -10,7 +10,6 @@
- libvirt-fedora-28
- libvirt-fedora-29
- libvirt-fedora-rawhide
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
archive_format: gz
git_url: '{{ git_urls["libvirt-sandbox"][git_remote] }}'
diff --git a/guests/playbooks/build/projects/libvirt-tck.yml
b/guests/playbooks/build/projects/libvirt-tck.yml
index b0aca96..172f139 100644
--- a/guests/playbooks/build/projects/libvirt-tck.yml
+++ b/guests/playbooks/build/projects/libvirt-tck.yml
@@ -10,7 +10,6 @@
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
archive_format: gz
git_url: '{{ git_urls["libvirt-tck"][git_remote] }}'
diff --git a/guests/playbooks/build/projects/libvirt.yml
b/guests/playbooks/build/projects/libvirt.yml
index dd84038..cd40bd8 100644
--- a/guests/playbooks/build/projects/libvirt.yml
+++ b/guests/playbooks/build/projects/libvirt.yml
@@ -18,7 +18,6 @@
- libvirt-fedora-28
- libvirt-fedora-29
- libvirt-fedora-rawhide
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
- include: '{{ playbook_base }}/jobs/autotools-check-job.yml'
vars:
diff --git a/guests/playbooks/build/projects/osinfo-db.yml
b/guests/playbooks/build/projects/osinfo-db.yml
index 9cd1652..f1d3fd9 100644
--- a/guests/playbooks/build/projects/osinfo-db.yml
+++ b/guests/playbooks/build/projects/osinfo-db.yml
@@ -23,7 +23,6 @@
- libvirt-freebsd-11
- libvirt-freebsd-12
- libvirt-freebsd-current
- - libvirt-ubuntu-16
- libvirt-ubuntu-18
command: |
$MAKE check
diff --git a/guests/playbooks/build/projects/virt-manager.yml
b/guests/playbooks/build/projects/virt-manager.yml
index bc67eae..5288792 100644
--- a/guests/playbooks/build/projects/virt-manager.yml
+++ b/guests/playbooks/build/projects/virt-manager.yml
@@ -1,9 +1,7 @@
---
- set_fact:
name: virt-manager
- # virt-manager is Python 3 only, so it can't be built on CentOS 7;
- # Ubuntu 16.04 has Python 3 but not the libxml2 bindings, so it can't
- # build the project either
+ # virt-manager is Python 3 only, so it can't be built on CentOS 7
machines:
- libvirt-debian-9
- libvirt-debian-sid
--
2.20.1
11:57 a.m.
New subject: [libvirt] [jenkins-ci PATCH 2/2] guests: Drop Ubuntu 18.04
Signed-off-by: Andrea Bolognani <abologna(a)redhat.com>
---
guests/host_vars/libvirt-ubuntu-16/docker.yml | 2 --
.../host_vars/libvirt-ubuntu-16/install.yml | 2 --
guests/host_vars/libvirt-ubuntu-16/main.yml | 22 -------------------
guests/inventory | 1 -
guests/vars/mappings.yml | 3 ---
5 files changed, 30 deletions(-)
delete mode 100644 guests/host_vars/libvirt-ubuntu-16/docker.yml
delete mode 100644 guests/host_vars/libvirt-ubuntu-16/install.yml
delete mode 100644 guests/host_vars/libvirt-ubuntu-16/main.yml
diff --git a/guests/host_vars/libvirt-ubuntu-16/docker.yml
b/guests/host_vars/libvirt-ubuntu-16/docker.yml
deleted file mode 100644
index 2d4eb25..0000000
--- a/guests/host_vars/libvirt-ubuntu-16/docker.yml
+++ /dev/null
@@ -1,2 +0,0 @@
----
-docker_base: ubuntu:16.04
diff --git a/guests/host_vars/libvirt-ubuntu-16/install.yml
b/guests/host_vars/libvirt-ubuntu-16/install.yml
deleted file mode 100644
index d8ce841..0000000
--- a/guests/host_vars/libvirt-ubuntu-16/install.yml
+++ /dev/null
@@ -1,2 +0,0 @@
----
-install_url: http://archive.ubuntu.com/ubuntu/dists/xenial/main/installer-amd64/
diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml
b/guests/host_vars/libvirt-ubuntu-16/main.yml
deleted file mode 100644
index 0e38128..0000000
--- a/guests/host_vars/libvirt-ubuntu-16/main.yml
+++ /dev/null
@@ -1,22 +0,0 @@
----
-projects:
- - libosinfo
- - libvirt
- - libvirt-dbus
- - libvirt-glib
- - libvirt-go
- - libvirt-go-xml
- - libvirt-ocaml
- - libvirt-perl
- - libvirt-python
- - libvirt-sandbox
- - libvirt-tck
- - osinfo-db
- - osinfo-db-tools
- - virt-viewer
-
-package_format: 'deb'
-os_name: 'Ubuntu'
-os_version: '16'
-
-ansible_python_interpreter: /usr/bin/python3
diff --git a/guests/inventory b/guests/inventory
index 4cf8e1b..d79ba63 100644
--- a/guests/inventory
+++ b/guests/inventory
@@ -7,5 +7,4 @@ libvirt-fedora-rawhide
libvirt-freebsd-11
libvirt-freebsd-12
libvirt-freebsd-current
-libvirt-ubuntu-16
libvirt-ubuntu-18
diff --git a/guests/vars/mappings.yml b/guests/vars/mappings.yml
index edd658e..92681c2 100644
--- a/guests/vars/mappings.yml
+++ b/guests/vars/mappings.yml
@@ -190,7 +190,6 @@ mappings:
deb: libglusterfs-dev
rpm: glusterfs-api-devel
Debian9: glusterfs-common
- Ubuntu16: glusterfs-common
Ubuntu18: glusterfs-common
cross-policy-deb: foreign
@@ -225,7 +224,6 @@ mappings:
gtk-update-icon-cache:
default: gtk-update-icon-cache
- Ubuntu16: libgtk2.0-bin
gtk-vnc2:
deb: libgtk-vnc-2.0-dev
@@ -799,7 +797,6 @@ mappings:
default: python3-libxml2
FreeBSD: py36-libxml2
CentOS7:
- Ubuntu16:
python3-lxml:
default: python3-lxml
--
2.20.1
12:42 p.m.
New subject: [libvirt] [jenkins-ci PATCH 2/2] guests: Drop Ubuntu 18.04
[snip]
Please, just do a s/18.04/16.04 in the commit message before pushing.
Best Regards,
3:21 a.m.
New subject: [libvirt] [jenkins-ci PATCH 2/2] guests: Drop Ubuntu 18.04
On Thu, 2019-03-28 at 18:42 +0100, Fabiano Fidêncio wrote:
[snip]
Please, just do a s/18.04/16.04 in the commit message before pushing.
Good catch! I've fixed it locally, thanks :)
--
Andrea Bolognani / Red Hat / Virtualization
12:16 p.m.
On Thu, 2019-03-28 at 17:57 +0100, Andrea Bolognani wrote:
I'm a bit conflicted about this one: on one hand, unlike Debian 8
we
haven't really run into any issue with Ubuntu 16.04, we can still
build almost all projects on it, and it doesn't require any crazy
hacks to maintain; on the other hand, perhaps the reason why we still
claim we can build almost all projects on it is because we don't
actually run any build on it, either on CentOS CI or on Travis CI :D
Anyway: here are the patches, let's see what other people think.
On the other (other!) hand, with Debian 8 out of the picture dropping
Ubuntu 16.04 would mean the oldest QEMU version we'd have to support
would be 2.8 rather than 2.5, which would probably result in slightly
more dead code being eligible for removal. I'd be okay with that.
--
Andrea Bolognani / Red Hat / Virtualization
12:37 p.m.
On Thu, Mar 28, 2019 at 05:57:57PM +0100, Andrea Bolognani wrote:
I'm a bit conflicted about this one: on one hand, unlike Debian 8
we
I don't see a conflict. As your first patch says, our support policy
has eliminated this distro version, so there's no reason to have it
in CI.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
3:20 a.m.
On Thu, 2019-03-28 at 17:37 +0000, Daniel P. Berrangé wrote:
On Thu, Mar 28, 2019 at 05:57:57PM +0100, Andrea Bolognani wrote:
> I'm a bit conflicted about this one: on one hand, unlike Debian 8 we
I don't see a conflict. As your first patch says, our support policy
has eliminated this distro version, so there's no reason to have it
in CI.
Alright! ACKs then? O:-)
--
Andrea Bolognani / Red Hat / Virtualization
4:08 a.m.
On Thu, Mar 28, 2019 at 05:57:57PM +0100, Andrea Bolognani wrote:
I'm a bit conflicted about this one: on one hand, unlike Debian 8
we
haven't really run into any issue with Ubuntu 16.04, we can still
build almost all projects on it, and it doesn't require any crazy
hacks to maintain; on the other hand, perhaps the reason why we still
claim we can build almost all projects on it is because we don't
actually run any build on it, either on CentOS CI or on Travis CI :D
Anyway: here are the patches, let's see what other people think.
Andrea Bolognani (2):
Stop building on Ubuntu 16.04
guests: Drop Ubuntu 18.04
Reviewed-by: Pavel Hrdina <phrdina(a)redhat.com>
2100
days inactive
2101
days old
8 comments
4 participants
participants (4)
-
Andrea Bolognani -
Daniel P. Berrangé -
Fabiano Fidêncio -
Pavel Hrdina