[libvirt] [PATCH] tests: Update qemucaps2xml for QEMU 4.0.0 on x86_64
Commit fb0d0d6c5492 added capabilities data and updated qemucapabilitiestest but forgot to update qemucaps2xmltest at the same time. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- *cough* and of course the reviewer didn't notice *cough* .../qemucaps2xmloutdata/caps_4.0.0.x86_64.xml | 28 +++++++++++++++++++ tests/qemucaps2xmltest.c | 1 + 2 files changed, 29 insertions(+) create mode 100644 tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml diff --git a/tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml b/tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml new file mode 100644 index 0000000000..d41693a001 --- /dev/null +++ b/tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml @@ -0,0 +1,28 @@ +<capabilities> + + <host> + <cpu> + <arch>x86_64</arch> + </cpu> + <power_management/> + <iommu support='no'/> + </host> + + <guest> + <os_type>hvm</os_type> + <arch name='x86_64'> + <wordsize>64</wordsize> + <emulator>/usr/bin/qemu-system-x86_64</emulator> + <domain type='qemu'/> + <domain type='kvm'/> + </arch> + <features> + <cpuselection/> + <deviceboot/> + <disksnapshot default='on' toggle='no'/> + <acpi default='on' toggle='yes'/> + <apic default='on' toggle='no'/> + </features> + </guest> + +</capabilities> diff --git a/tests/qemucaps2xmltest.c b/tests/qemucaps2xmltest.c index dd9fc6917a..9d6b6f474c 100644 --- a/tests/qemucaps2xmltest.c +++ b/tests/qemucaps2xmltest.c @@ -198,6 +198,7 @@ mymain(void) DO_TEST("x86_64", "caps_2.12.0"); DO_TEST("x86_64", "caps_3.0.0"); DO_TEST("x86_64", "caps_3.1.0"); + DO_TEST("x86_64", "caps_4.0.0"); DO_TEST("aarch64", "caps_2.6.0"); DO_TEST("aarch64", "caps_2.10.0"); DO_TEST("aarch64", "caps_2.12.0"); -- 2.20.1
On Thu, Jan 31, 2019 at 02:22:48PM +0100, Andrea Bolognani wrote:
Commit fb0d0d6c5492 added capabilities data and updated qemucapabilitiestest but forgot to update qemucaps2xmltest at the same time.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- *cough* and of course the reviewer didn't notice *cough*
It's okay, it does not seem THAT useful: $ sha1sum tests/qemucaps2xmloutdata/caps_* | sort 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.10.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.12.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.6.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.9.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_3.0.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_3.1.0.ppc64.xml 30e84ffb64dbbf5e98401cc48eb8d62718d9f909 tests/qemucaps2xmloutdata/caps_2.10.0.aarch64.xml 30e84ffb64dbbf5e98401cc48eb8d62718d9f909 tests/qemucaps2xmloutdata/caps_2.12.0.aarch64.xml 30e84ffb64dbbf5e98401cc48eb8d62718d9f909 tests/qemucaps2xmloutdata/caps_2.6.0.aarch64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_1.5.3.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_1.6.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_1.7.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.10.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.11.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.1.1.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.12.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.4.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.5.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.6.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.7.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.8.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.9.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_3.0.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_3.1.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml 748474f70fe5743630548e2317aa57ba61e3436c tests/qemucaps2xmloutdata/caps_3.0.0.riscv64.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.10.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.11.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.12.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.7.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.8.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.9.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_3.0.0.s390x.xml 9d061fd737dca36839ee39fdabe23b7e223b5afd tests/qemucaps2xmloutdata/caps_3.0.0.riscv32.xml
.../qemucaps2xmloutdata/caps_4.0.0.x86_64.xml | 28 +++++++++++++++++++ tests/qemucaps2xmltest.c | 1 + 2 files changed, 29 insertions(+) create mode 100644 tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml
Reviewed-by: Ján Tomko <jtomko@redhat.com> Jano
On Fri, 2019-02-01 at 12:14 +0100, Ján Tomko wrote:
On Thu, Jan 31, 2019 at 02:22:48PM +0100, Andrea Bolognani wrote:
Commit fb0d0d6c5492 added capabilities data and updated qemucapabilitiestest but forgot to update qemucaps2xmltest at the same time.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- *cough* and of course the reviewer didn't notice *cough*
It's okay, it does not seem THAT useful:
$ sha1sum tests/qemucaps2xmloutdata/caps_* | sort 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.10.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.12.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.6.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_2.9.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_3.0.0.ppc64.xml 0920190f4cc69b09208d040bfea7e8c28aa5d399 tests/qemucaps2xmloutdata/caps_3.1.0.ppc64.xml 30e84ffb64dbbf5e98401cc48eb8d62718d9f909 tests/qemucaps2xmloutdata/caps_2.10.0.aarch64.xml 30e84ffb64dbbf5e98401cc48eb8d62718d9f909 tests/qemucaps2xmloutdata/caps_2.12.0.aarch64.xml 30e84ffb64dbbf5e98401cc48eb8d62718d9f909 tests/qemucaps2xmloutdata/caps_2.6.0.aarch64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_1.5.3.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_1.6.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_1.7.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.10.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.11.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.1.1.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.12.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.4.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.5.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.6.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.7.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.8.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_2.9.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_3.0.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_3.1.0.x86_64.xml 7215a9dc383575f64f379125d41ade537ff56ddc tests/qemucaps2xmloutdata/caps_4.0.0.x86_64.xml 748474f70fe5743630548e2317aa57ba61e3436c tests/qemucaps2xmloutdata/caps_3.0.0.riscv64.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.10.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.11.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.12.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.7.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.8.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_2.9.0.s390x.xml 87e692398a85c24540ae3d4d42ba3f55bb7b6769 tests/qemucaps2xmloutdata/caps_3.0.0.s390x.xml 9d061fd737dca36839ee39fdabe23b7e223b5afd tests/qemucaps2xmloutdata/caps_3.0.0.riscv32.xml
Solid point! Addressed in https://www.redhat.com/archives/libvir-list/2019-February/msg00026.html -- Andrea Bolognani / Red Hat / Virtualization
participants (2)
-
Andrea Bolognani -
Ján Tomko