[libvirt] [PATCH 0/2] remove 2 unused functions
From: YueWenyuan <yuewenyuan@huawei.com> remove unused functions virTimeFieldsNow() and virTimeFieldsNowRaw() YueWenyuan (2): remove unused function virTimeFieldsNow remove unused function virTimeFieldsNowRaw src/libvirt_private.syms | 2 -- src/util/virtime.c | 43 ------------------------------------------- src/util/virtime.h | 4 ---- 3 files changed, 49 deletions(-) -- 1.7.12.4
From: YueWenyuan <yuewenyuan@huawei.com> remove unused function virTimeFieldsNow() in src/libvirt_private.syms, src/util/virtime.c and src/util/virtime.h Signed-off-by: YueWenyuan <yuewenyuan@huawei.com> Signed-off-by: Zhang Bo <oscar.zhangbo@huawei.com> --- src/libvirt_private.syms | 1 - src/util/virtime.c | 21 --------------------- src/util/virtime.h | 2 -- 3 files changed, 24 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 8c50ea2..43b041f 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2230,7 +2230,6 @@ virThreadPoolSendJob; # util/virtime.h -virTimeFieldsNow; virTimeFieldsNowRaw; virTimeFieldsThen; virTimeLocalOffsetFromUTC; diff --git a/src/util/virtime.c b/src/util/virtime.c index 9d365d5..7013caa 100644 --- a/src/util/virtime.c +++ b/src/util/virtime.c @@ -242,27 +242,6 @@ int virTimeMillisNow(unsigned long long *now) /** - * virTimeFieldsNowRaw: - * @fields: filled with current time fields - * - * Retrieves the current time, in broken-down field format. - * The time is always in UTC. - * - * Returns 0 on success, -1 on error with errno reported - */ -int virTimeFieldsNow(struct tm *fields) -{ - unsigned long long now; - - if (virTimeMillisNow(&now) < 0) - return -1; - - virTimeFieldsThen(now, fields); - return 0; -} - - -/** * virTimeStringNow: * * Creates a string containing a formatted timestamp diff --git a/src/util/virtime.h b/src/util/virtime.h index 8ebad38..86dddc1 100644 --- a/src/util/virtime.h +++ b/src/util/virtime.h @@ -56,8 +56,6 @@ int virTimeStringThenRaw(unsigned long long when, char *buf) */ int virTimeMillisNow(unsigned long long *now) ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; -int virTimeFieldsNow(struct tm *fields) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; char *virTimeStringNow(void); char *virTimeStringThen(unsigned long long when); -- 1.7.12.4
From: YueWenyuan <yuewenyuan@huawei.com> remove unused function virTimeFieldsNowRaw() in src/libvirt_private.syms, src/util/virtime.c and src/util/virtime.h Signed-off-by: YueWenyuan <yuewenyuan@huawei.com> Signed-off-by: Zhang Bo <oscar.zhangbo@huawei.com> --- src/libvirt_private.syms | 1 - src/util/virtime.c | 22 ---------------------- src/util/virtime.h | 2 -- 3 files changed, 25 deletions(-) diff --git a/src/libvirt_private.syms b/src/libvirt_private.syms index 43b041f..800fe95 100644 --- a/src/libvirt_private.syms +++ b/src/libvirt_private.syms @@ -2230,7 +2230,6 @@ virThreadPoolSendJob; # util/virtime.h -virTimeFieldsNowRaw; virTimeFieldsThen; virTimeLocalOffsetFromUTC; virTimeMillisNow; diff --git a/src/util/virtime.c b/src/util/virtime.c index 7013caa..f127166 100644 --- a/src/util/virtime.c +++ b/src/util/virtime.c @@ -78,28 +78,6 @@ int virTimeMillisNowRaw(unsigned long long *now) } -/** - * virTimeFieldsNowRaw: - * @fields: filled with current time fields - * - * Retrieves the current time, in broken-down field format. - * The time is always in UTC. - * - * Returns 0 on success, -1 on error with errno set - */ -int virTimeFieldsNowRaw(struct tm *fields) -{ - unsigned long long now; - - if (virTimeMillisNowRaw(&now) < 0) - return -1; - - virTimeFieldsThen(now, fields); - - return 0; -} - - #define SECS_PER_HOUR (60 * 60) #define SECS_PER_DAY (SECS_PER_HOUR * 24) #define DIV(a, b) ((a) / (b) - ((a) % (b) < 0)) diff --git a/src/util/virtime.h b/src/util/virtime.h index 86dddc1..12c1303 100644 --- a/src/util/virtime.h +++ b/src/util/virtime.h @@ -44,8 +44,6 @@ void virTimeFieldsThen(unsigned long long when, struct tm *fields) * errno on failure */ int virTimeMillisNowRaw(unsigned long long *now) ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; -int virTimeFieldsNowRaw(struct tm *fields) - ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; int virTimeStringNowRaw(char *buf) ATTRIBUTE_NONNULL(1) ATTRIBUTE_RETURN_CHECK; int virTimeStringThenRaw(unsigned long long when, char *buf) -- 1.7.12.4
On Tue, May 12, 2015 at 07:26:11PM +0800, Zhang Bo wrote:
From: YueWenyuan <yuewenyuan@huawei.com>
remove unused functions virTimeFieldsNow() and virTimeFieldsNowRaw()
Removing unused functions like this is really a non-goal. They are general utility functions in libvirt that may or may not be used at a single point in time, but we do not remove them just because they happen to not currently be used. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (2)
-
Daniel P. Berrange -
Zhang Bo