[libvirt] [PATCH] Fix error squashing when refreshing file volumes
When refreshing a file based pool, errors hit when determining a volume's format were being squashed, reporting OOM instead. The attached patch fixes the error reporting here. Reported by Jason Guiditta. Thanks, Cole
On Mon, May 11, 2009 at 10:03:24AM -0400, Cole Robinson wrote:
When refreshing a file based pool, errors hit when determining a volume's format were being squashed, reporting OOM instead. The attached patch fixes the error reporting here.
Reported by Jason Guiditta.
ACK. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Mon, May 11, 2009 at 10:03:24AM -0400, Cole Robinson wrote:
When refreshing a file based pool, errors hit when determining a volume's format were being squashed, reporting OOM instead. The attached patch fixes the error reporting here.
Looks fine, though if you start to add function comments it would be better to have them match the format used in libvirt.c (i.e. one Return sentence and description of args and functionality. ACK, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On 05/11/2009 10:33 AM, Daniel Veillard wrote:
On Mon, May 11, 2009 at 10:03:24AM -0400, Cole Robinson wrote:
When refreshing a file based pool, errors hit when determining a volume's format were being squashed, reporting OOM instead. The attached patch fixes the error reporting here.
Looks fine, though if you start to add function comments it would be better to have them match the format used in libvirt.c (i.e. one Return sentence and description of args and functionality.
ACK,
Daniel
Okay, I committed this, with the comment to match existing convention. Thanks, Cole
participants (3)
-
Cole Robinson -
Daniel P. Berrange -
Daniel Veillard