[libvirt] [PATCH] Explicitly link virfirewalltest and virsystemdtest against dbus
This fixes link failures like: CCLD virfirewalltest /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to symbol 'dbus_message_iter_init_append' --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/Makefile.am b/tests/Makefile.am index 7ffb44e..5ef8940 100644 --- a/tests/Makefile.am +++ b/tests/Makefile.am @@ -963,7 +963,7 @@ virmockdbus_la_LDFLAGS = -module -avoid-version \ virsystemdtest_SOURCES = \ virsystemdtest.c testutils.h testutils.c virsystemdtest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) -virsystemdtest_LDADD = $(LDADDS) +virsystemdtest_LDADD = $(LDADDS) $(DBUS_LIBS) else ! WITH_DBUS EXTRA_DIST += virdbustest.c virmockdbus.c virsystemdtest.c @@ -1047,7 +1047,7 @@ virfiletest_LDADD = $(LDADDS) virfirewalltest_SOURCES = \ virfirewalltest.c testutils.h testutils.c -virfirewalltest_LDADD = $(LDADDS) +virfirewalltest_LDADD = $(LDADDS) $(DBUS_LIBS) virfirewalltest_CFLAGS = $(AM_CFLAGS) $(DBUS_CFLAGS) jsontest_SOURCES = \ -- 1.9.2
On 05/03/2014 06:16 AM, Guido Günther wrote:
This fixes link failures like:
CCLD virfirewalltest /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to symbol 'dbus_message_iter_init_append' --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACK; safe for 1.2.4 -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
On Sat, May 03, 2014 at 07:39:03AM -0600, Eric Blake wrote:
On 05/03/2014 06:16 AM, Guido Günther wrote:
This fixes link failures like:
CCLD virfirewalltest /usr/bin/ld: virfirewalltest-virfirewalltest.o: undefined reference to symbol 'dbus_message_iter_init_append' --- tests/Makefile.am | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
ACK; safe for 1.2.4
Pushed. Thanks, -- Guido
participants (2)
-
Eric Blake -
Guido Günther