[libvirt] [PATCH] Fix enabling storage driver

As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this. Thanks, Cole diff --git a/configure.in b/configure.in index 47633b0..64c6013 100644 --- a/configure.in +++ b/configure.in @@ -257,6 +257,10 @@ if test "$with_remote" = "yes" ; then LIBVIRT_FEATURES="$LIBVIRT_FEATURES -DWITH_REMOTE" fi +if test "$with_libvirtd" = "yes" ; then + LIBVIRT_FEATURES="$LIBVIRT_FEATURES -DWITH_LIBVIRTD" +fi + if test "$with_xen" = "yes" ; then dnl search for the Xen store library AC_SEARCH_LIBS(xs_read, [xenstore],

On Mon, Jun 09, 2008 at 03:14:14PM -0400, Cole Robinson wrote:
As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this.
Odd ... but yes +1. Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-top is 'top' for virtual machines. Tiny program with many powerful monitoring features, net stats, disk stats, logging, etc. http://et.redhat.com/~rjones/virt-top

On Tue, Jun 10, 2008 at 09:38:59AM +0100, Richard W.M. Jones wrote:
On Mon, Jun 09, 2008 at 03:14:14PM -0400, Cole Robinson wrote:
As of a couple weeks ago, the storage driver is only registered if the WITH_LIBVIRTD macro is defined. The configure option --with-libvirtd actually wasn't defining this macro. The attached patch fixes this.
Odd ... but yes +1.
Yup, but in any case it doesn't seems it can do any harm, fine by me, applied and commited, thanks ! Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (3)
-
Cole Robinson
-
Daniel Veillard
-
Richard W.M. Jones