On Mon, May 04, 2009 at 03:22:50PM -0400, Cole Robinson wrote:

The attached patch removes the error message squashing that can take place in the qemu driver when launching a new VM via restore or migrate.

ACK

commit cd93c8247c9df7e98b3f2b092c18e4be45d46059 Author: Cole Robinson <crobinso@redhat.com> Date: Thu Apr 23 15:01:29 2009 -0400

Don't throw away StartVM errors when migrating/restoring in qemu driver.

diff --git a/src/qemu_driver.c b/src/qemu_driver.c index 5c8a883..a44861d 100644 --- a/src/qemu_driver.c +++ b/src/qemu_driver.c @@ -225,7 +225,7 @@ qemudAutostartConfigs(struct qemud_driver *driver) { virErrorPtr err = virGetLastError(); VIR_ERROR(_("Failed to autostart VM '%s': %s\n"), vm->def->name, - err ? err->message : NULL); + err ? err->message : ""); } else { virDomainEventPtr event = virDomainEventNewFromObj(vm, @@ -3283,8 +3283,6 @@ static int qemudDomainRestore(virConnectPtr conn, close(fd); fd = -1; if (ret < 0) { - qemudReportError(conn, NULL, NULL, VIR_ERR_OPERATION_FAILED, - "%s", _("failed to start VM")); if (!vm->persistent) { virDomainRemoveInactive(&driver->domains, vm); @@ -4780,8 +4778,6 @@ qemudDomainMigratePrepare2 (virConnectPtr dconn, */ snprintf (migrateFrom, sizeof (migrateFrom), "tcp:0.0.0.0:%d", this_port); if (qemudStartVMDaemon (dconn, driver, vm, migrateFrom, -1) < 0) { - qemudReportError (dconn, NULL, NULL, VIR_ERR_OPERATION_FAILED, - "%s", _("failed to start listening VM")); if (!vm->persistent) { virDomainRemoveInactive(&driver->domains, vm); vm = NULL;

-- Libvir-list mailing list Libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

-- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|