[libvirt] [PATCH 0/2] libxl: drop support for Xen 4.4 and 4.5
Bla bla bla... Jim Fehlig (2): libxl: drop support for Xen < 4.6 news: announce dropping support for Xen 4.4 and 4.5 docs/drvxen.html.in | 11 +++++------ docs/news.xml | 9 +++++++++ m4/virt-driver-libxl.m4 | 23 ++--------------------- 3 files changed, 16 insertions(+), 27 deletions(-) -- 2.16.2
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6. Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/drvxen.html.in | 11 +++++------ m4/virt-driver-libxl.m4 | 23 ++--------------------- 2 files changed, 7 insertions(+), 27 deletions(-) diff --git a/docs/drvxen.html.in b/docs/drvxen.html.in index d30ed2a04..935677387 100644 --- a/docs/drvxen.html.in +++ b/docs/drvxen.html.in @@ -56,12 +56,11 @@ any other non-config files in this directory. </li> <li> - <strong>libxl</strong>: Starting with Xen 4.2, the legacy XenD/xm - toolstack is deprecated in favor of libxl, also commonly called - libxenlight. libvirt supports this new Xen toolstack via the - libxl driver. If XenD is enabled, the legacy xen driver consisting - of the above mentioned channels will be used. If XenD is disabled, - the libxl driver will be used. + <strong>libxl</strong>: Starting with Xen 4.5, the legacy xm/xend + toolstack was removed and replaced with the new xl/libxl toolstack, + also commonly called libxenlight. libvirt has supported this new + Xen toolstack since its introduction in Xen 4.2 and currently + supports Xen >= 4.6. </li> </ul> diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4 index 2cc1c062d..48d2d7dfa 100644 --- a/m4/virt-driver-libxl.m4 +++ b/m4/virt-driver-libxl.m4 @@ -29,33 +29,14 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [ LIBXL_API_VERSION="-DLIBXL_API_VERSION=0x040400" dnl search for libxl, aka libxenlight - dnl Xen > 4.5 introduced a pkgconfig file, check for it first + dnl Xen 4.6 introduced a pkgconfig file old_with_libxl="$with_libxl" - LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.4.0], [true]) + LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0]) if test "x$with_libxl" = "xyes" ; then LIBXL_FIRMWARE_DIR=$($PKG_CONFIG --variable xenfirmwaredir xenlight) LIBXL_EXECBIN_DIR=$($PKG_CONFIG --variable libexec_bin xenlight) fi - dnl pkgconfig file not found, fallback to lib probe - if test "x$with_libxl" = "xno" ; then - with_libxl="$old_with_libxl" - - dnl LIBXL_API_VERSION 4.4.0 introduced a new parameter to - dnl libxl_domain_create_restore for specifying restore parameters. - dnl The libxl driver will make use of this new parameter for specifying - dnl the Xen migration stream version. Specify LIBXL_API_VERSION to trigger - dnl an error if there is too old xenlight - old_CFLAGS="$CFLAGS" - CFLAGS="$CFLAGS $LIBXL_API_VERSION" - LIBVIRT_CHECK_LIB([LIBXL], [xenlight], [libxl_ctx_alloc], [libxl.h], [fail="1"]) - CFLAGS="$old_CFLAGS" - - if test $fail = 1; then - AC_MSG_ERROR([You must install the libxl Library from Xen >= 4.4 to compile libxenlight driver with -lxl]) - fi - fi - if test "$with_libxl" = "yes"; then old_LIBS="$LIBS" old_CFLAGS="$CFLAGS" -- 2.16.2
On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote:
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6.
Generally libvirt would keep supporting things even if upstream drops support, if some relevant distro still ships and supports it. RHEL doesn't ship libxl though, so just Q of whether these libxl versions are relevant to any Suse or Debian distros that are actively used.
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/drvxen.html.in | 11 +++++------ m4/virt-driver-libxl.m4 | 23 ++--------------------- 2 files changed, 7 insertions(+), 27 deletions(-)
diff --git a/docs/drvxen.html.in b/docs/drvxen.html.in index d30ed2a04..935677387 100644 --- a/docs/drvxen.html.in +++ b/docs/drvxen.html.in @@ -56,12 +56,11 @@ any other non-config files in this directory. </li> <li> - <strong>libxl</strong>: Starting with Xen 4.2, the legacy XenD/xm - toolstack is deprecated in favor of libxl, also commonly called - libxenlight. libvirt supports this new Xen toolstack via the - libxl driver. If XenD is enabled, the legacy xen driver consisting - of the above mentioned channels will be used. If XenD is disabled, - the libxl driver will be used. + <strong>libxl</strong>: Starting with Xen 4.5, the legacy xm/xend + toolstack was removed and replaced with the new xl/libxl toolstack, + also commonly called libxenlight. libvirt has supported this new + Xen toolstack since its introduction in Xen 4.2 and currently + supports Xen >= 4.6. </li> </ul>
diff --git a/m4/virt-driver-libxl.m4 b/m4/virt-driver-libxl.m4 index 2cc1c062d..48d2d7dfa 100644 --- a/m4/virt-driver-libxl.m4 +++ b/m4/virt-driver-libxl.m4 @@ -29,33 +29,14 @@ AC_DEFUN([LIBVIRT_DRIVER_CHECK_LIBXL], [ LIBXL_API_VERSION="-DLIBXL_API_VERSION=0x040400"
dnl search for libxl, aka libxenlight - dnl Xen > 4.5 introduced a pkgconfig file, check for it first + dnl Xen 4.6 introduced a pkgconfig file old_with_libxl="$with_libxl" - LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.4.0], [true]) + LIBVIRT_CHECK_PKG([LIBXL], [xenlight], [4.6.0]) if test "x$with_libxl" = "xyes" ; then LIBXL_FIRMWARE_DIR=$($PKG_CONFIG --variable xenfirmwaredir xenlight) LIBXL_EXECBIN_DIR=$($PKG_CONFIG --variable libexec_bin xenlight) fi
- dnl pkgconfig file not found, fallback to lib probe - if test "x$with_libxl" = "xno" ; then - with_libxl="$old_with_libxl" - - dnl LIBXL_API_VERSION 4.4.0 introduced a new parameter to - dnl libxl_domain_create_restore for specifying restore parameters. - dnl The libxl driver will make use of this new parameter for specifying - dnl the Xen migration stream version. Specify LIBXL_API_VERSION to trigger - dnl an error if there is too old xenlight - old_CFLAGS="$CFLAGS" - CFLAGS="$CFLAGS $LIBXL_API_VERSION" - LIBVIRT_CHECK_LIB([LIBXL], [xenlight], [libxl_ctx_alloc], [libxl.h], [fail="1"]) - CFLAGS="$old_CFLAGS" - - if test $fail = 1; then - AC_MSG_ERROR([You must install the libxl Library from Xen >= 4.4 to compile libxenlight driver with -lxl]) - fi - fi - if test "$with_libxl" = "yes"; then old_LIBS="$LIBS" old_CFLAGS="$CFLAGS" -- 2.16.2
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote:
On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote:
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6.
Generally libvirt would keep supporting things even if upstream drops support, if some relevant distro still ships and supports it. RHEL doesn't ship libxl though, so just Q of whether these libxl versions are relevant to any Suse or Debian distros that are actively used.
BTW, if we're willing to drop old versions of Xen wrt the libxl driver, shouldn't we first drop the legacy Xen driver which is used with even older versions of Xen < 4.2 ? Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On 03/28/2018 07:28 AM, Daniel P. Berrangé wrote:
On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote:
On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote:
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6.
Generally libvirt would keep supporting things even if upstream drops support, if some relevant distro still ships and supports it. RHEL doesn't ship libxl though, so just Q of whether these libxl versions are relevant to any Suse or Debian distros that are actively used.
BTW, if we're willing to drop old versions of Xen wrt the libxl driver, shouldn't we first drop the legacy Xen driver which is used with even older versions of Xen < 4.2 ?
Touche :-). I have a dusty patchset to do that too. Time to brush it off and nuke the old driver first. Regards, Jim
On Wed, Mar 28, 2018 at 08:10:34AM -0600, Jim Fehlig wrote:
On 03/28/2018 07:28 AM, Daniel P. Berrangé wrote:
On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote:
On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote:
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6.
Generally libvirt would keep supporting things even if upstream drops support, if some relevant distro still ships and supports it. RHEL doesn't ship libxl though, so just Q of whether these libxl versions are relevant to any Suse or Debian distros that are actively used.
BTW, if we're willing to drop old versions of Xen wrt the libxl driver, shouldn't we first drop the legacy Xen driver which is used with even older versions of Xen < 4.2 ?
Touche :-). I have a dusty patchset to do that too. Time to brush it off and nuke the old driver first.
Great, I look forward to seeing that, because it will simplify some work I'm trying todo to cleanup the virDrvConnectOpen method impls. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Wed, Mar 28, 2018 at 03:13:35PM +0100, Daniel P. Berrangé wrote:
On Wed, Mar 28, 2018 at 08:10:34AM -0600, Jim Fehlig wrote:
On 03/28/2018 07:28 AM, Daniel P. Berrangé wrote:
On Wed, Mar 28, 2018 at 10:03:51AM +0100, Daniel P. Berrangé wrote:
On Tue, Mar 27, 2018 at 04:31:29PM -0600, Jim Fehlig wrote:
Currently the libxl driver claims support for Xen >= 4.4, but Xen 4.4 and 4.5 are no longer supported upstream. Let's increase the minimum supported version to 4.6.
Generally libvirt would keep supporting things even if upstream drops support, if some relevant distro still ships and supports it. RHEL doesn't ship libxl though, so just Q of whether these libxl versions are relevant to any Suse or Debian distros that are actively used.
BTW, if we're willing to drop old versions of Xen wrt the libxl driver, shouldn't we first drop the legacy Xen driver which is used with even older versions of Xen < 4.2 ?
Touche :-). I have a dusty patchset to do that too. Time to brush it off and nuke the old driver first.
Great, I look forward to seeing that, because it will simplify some work I'm trying todo to cleanup the virDrvConnectOpen method impls.
Sorry for hijacking the thread, but this is somehow related. From the hypervisor drivers we have, can we also drop the following ones? - openvz: Last hypervisor-related non-trivial feature added in 0.9.12. - PHYP: Apart from leaks, coverity fixes and trivial implementation changes, there was: - no bigger change since Jul 2011 - no feature-related (functionality-adding) change since Apr 2011 which was less than 2 years since its inclusion in libvirt - UML: I tired to find when some patch was related to UML, but I stopped scrolling due to boredom From the non-hypervisor drivers, is anyone using the HAL backend of nodedev driver? Have a nice day, Martin
Signed-off-by: Jim Fehlig <jfehlig@suse.com> --- docs/news.xml | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/docs/news.xml b/docs/news.xml index 108889574..a2e0af100 100644 --- a/docs/news.xml +++ b/docs/news.xml @@ -56,6 +56,15 @@ on S390. </description> </change> + <change> + <summary> + Xen: Drop support for Xen 4.4 and 4.5 + </summary> + <description> + Xen 4.4 and 4.5 are no longer supported by the Xen community. + Drop support for older Xen versions, requiring Xen >= 4.6. + </description> + </change> </section> <section title="Improvements"> <change> -- 2.16.2
participants (3)
-
Daniel P. Berrangé -
Jim Fehlig -
Martin Kletzander