[libvirt] [PATCH] xenapi: Fix double-freeing the session in xenapiClose
xen_session_logout already frees the whole session object. Don't call xenSessionFree on a freed session object. Reported by Sharmila Radhakrishnan. --- src/xenapi/xenapi_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 97da1d1..dbc03cb 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -230,7 +230,7 @@ xenapiClose (virConnectPtr conn) if (priv->session != NULL) { xen_session_logout(priv->session); - xenSessionFree(priv->session); + priv->session = NULL; } VIR_FREE(priv->url); -- 1.7.4.1
On 07/21/2011 10:11 AM, Matthias Bolte wrote:
xen_session_logout already frees the whole session object. Don't call xenSessionFree on a freed session object.
Reported by Sharmila Radhakrishnan. --- src/xenapi/xenapi_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 97da1d1..dbc03cb 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -230,7 +230,7 @@ xenapiClose (virConnectPtr conn)
if (priv->session != NULL) { xen_session_logout(priv->session); - xenSessionFree(priv->session); + priv->session = NULL; }
ACK. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
2011/7/21 Eric Blake <eblake@redhat.com>:
On 07/21/2011 10:11 AM, Matthias Bolte wrote:
xen_session_logout already frees the whole session object. Don't call xenSessionFree on a freed session object.
Reported by Sharmila Radhakrishnan. --- src/xenapi/xenapi_driver.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/xenapi/xenapi_driver.c b/src/xenapi/xenapi_driver.c index 97da1d1..dbc03cb 100644 --- a/src/xenapi/xenapi_driver.c +++ b/src/xenapi/xenapi_driver.c @@ -230,7 +230,7 @@ xenapiClose (virConnectPtr conn)
if (priv->session != NULL) { xen_session_logout(priv->session); - xenSessionFree(priv->session); + priv->session = NULL; }
ACK.
Thanks, pushed. -- Matthias Bolte http://photron.blogspot.com
participants (2)
-
Eric Blake -
Matthias Bolte