On Mon, Mar 04, 2019 at 03:03:23PM +0100, Michal Privoznik wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1658504 Some description apart from the bug would be appreciated.

> > Signed-off-by: Michal Privoznik <mprivozn(a)redhat.com&gt; > --- > src/conf/domain_conf.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/src/conf/domain_conf.c b/src/conf/domain_conf.c > index 05c2c9f34e..3340f0b0ef 100644 > --- a/src/conf/domain_conf.c > +++ b/src/conf/domain_conf.c > @@ -30565,8 +30565,6 @@ virDomainDiskTranslateSourcePool(virDomainDiskDefPtr def) > return -1; > } > > - def->src->srcpool->mode = VIR_STORAGE_SOURCE_POOL_MODE_DIRECT; > - I think it might be worth enhancing the documentation on what does and what does not support 'mode' attr. I think it's reasonable not to format mode='direct' with iscsi-direct pool, it feels very redundant and a bit confusing.

Reviewed-by: Erik Skultety <eskultet(a)redhat.com&gt;