[libvirt] [gconfig v2 0/2] Add host setters
From: Visarion Alexandru <viorel.visarion@gmail.com> These new patches are a bit different than the last ones. I first delete the <listen address=""> child node and then I modify the <listen> attribute. Visarion Alexandru (2): config: Add vnc host setter config: Add spice host setter libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 9 +++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 5 files changed, 27 insertions(+) -- 2.7.4
From: Visarion Alexandru <viorel.visarion@gmail.com> Learn to set the address that vnc is listening on. --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 9 +++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 13 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c index fc26bb9..dfec2d8 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c @@ -120,6 +120,15 @@ void gvir_config_domain_graphics_vnc_set_port(GVirConfigDomainGraphicsVnc *graph NULL); } +void gvir_config_domain_graphics_vnc_set_host(GVirConfigDomainGraphicsVnc *graphics, + const char *address) +{ + g_return_if_fail(GVIR_CONFIG_IS_DOMAIN_GRAPHICS_VNC(graphics)); + + gvir_config_object_delete_child(GVIR_CONFIG_OBJECT(graphics), "listen", NULL); + gvir_config_object_set_attribute(GVIR_CONFIG_OBJECT(graphics), "listen", address, NULL); +} + void gvir_config_domain_graphics_vnc_set_password(GVirConfigDomainGraphicsVnc *graphics, const char *password) { diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h index fe78621..10f8661 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h @@ -73,6 +73,9 @@ int gvir_config_domain_graphics_vnc_get_port(GVirConfigDomainGraphicsVnc *graphi void gvir_config_domain_graphics_vnc_set_port(GVirConfigDomainGraphicsVnc *graphics, int port); +void gvir_config_domain_graphics_vnc_set_host(GVirConfigDomainGraphicsVnc *graphics, + const char *address); + void gvir_config_domain_graphics_vnc_set_password(GVirConfigDomainGraphicsVnc *graphics, const char *password); diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 4ef4bf7..3153a83 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -764,6 +764,7 @@ global: gvir_config_domain_video_get_model; gvir_config_domain_video_set_accel3d; + gvir_config_domain_graphics_vnc_set_host; } LIBVIRT_GCONFIG_0.2.2; # .... define new API here using predicted next version number .... -- 2.7.4
Hey, On Thu, Jul 28, 2016 at 06:16:38PM +0300, Visarion Alexandru wrote:
From: Visarion Alexandru <viorel.visarion@gmail.com>
Learn to set the address that vnc is listening on. --- libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 9 +++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 13 insertions(+)
diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c index fc26bb9..dfec2d8 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c @@ -120,6 +120,15 @@ void gvir_config_domain_graphics_vnc_set_port(GVirConfigDomainGraphicsVnc *graph NULL); }
+void gvir_config_domain_graphics_vnc_set_host(GVirConfigDomainGraphicsVnc *graphics, + const char *address)
Why not gvir_config_domain_graphics_set_listen_address? Overall, the patch looks good (adding some short API documentation would be nice). However, the "listen" attribute really is deprecated at this point in favour of "listen" nodes. Adding an API setting the "listen" attribute and removing the "listen" node really looks like we are adding already obsolete API to libvirt-glib. Ideally we'd add void gvir_config_domain_graphics_vnc_set_listen(GVirConfigDomainGraphicsVnc *graphics, GList *listens); and a GVirConfigDomainGraphicsListen base class + GVirConfigDomainGraphicsListenAddress derived class This would allow us to support only the preferred XML format. Christophe
From: Visarion Alexandru <viorel.visarion@gmail.com> Learn to set the address that spice is listening on. --- libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 1 + 3 files changed, 14 insertions(+) diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c b/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c index 079ea27..fa1dd31 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c @@ -157,6 +157,16 @@ void gvir_config_domain_graphics_spice_set_image_compression compression); } + +void gvir_config_domain_graphics_spice_set_host(GVirConfigDomainGraphicsSpice *graphics, + const char *address) +{ + g_return_if_fail(GVIR_CONFIG_IS_DOMAIN_GRAPHICS_SPICE(graphics)); + + gvir_config_object_delete_child(GVIR_CONFIG_OBJECT(graphics), "listen", NULL); + gvir_config_object_set_attribute(GVIR_CONFIG_OBJECT(graphics), "listen", address, NULL); +} + void gvir_config_domain_graphics_spice_set_gl(GVirConfigDomainGraphicsSpice *graphics, gboolean gl) { diff --git a/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h b/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h index 25c132e..9f55724 100644 --- a/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h +++ b/libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h @@ -95,6 +95,9 @@ gvir_config_domain_graphics_spice_get_image_compression void gvir_config_domain_graphics_spice_set_gl(GVirConfigDomainGraphicsSpice *graphics, gboolean gl); +void gvir_config_domain_graphics_spice_set_host(GVirConfigDomainGraphicsSpice *graphics, + const char *address); + G_END_DECLS #endif /* __LIBVIRT_GCONFIG_DOMAIN_GRAPHICS_SPICE_H__ */ diff --git a/libvirt-gconfig/libvirt-gconfig.sym b/libvirt-gconfig/libvirt-gconfig.sym index 3153a83..9d349fc 100644 --- a/libvirt-gconfig/libvirt-gconfig.sym +++ b/libvirt-gconfig/libvirt-gconfig.sym @@ -765,6 +765,7 @@ global: gvir_config_domain_video_get_model; gvir_config_domain_video_set_accel3d; gvir_config_domain_graphics_vnc_set_host; + gvir_config_domain_graphics_spice_set_host; } LIBVIRT_GCONFIG_0.2.2; # .... define new API here using predicted next version number .... -- 2.7.4
Hey, On Thu, Jul 28, 2016 at 06:16:37PM +0300, Visarion Alexandru wrote:
From: Visarion Alexandru <viorel.visarion@gmail.com>
These new patches are a bit different than the last ones. I first delete the <listen address=""> child node and then I modify the <listen> attribute.
You could mention this in the commit log of each patch as well, and indicate that otherwise we could get inconsistencies between the listen node and attribute, which causes errors when trying to start (or define ?) the domain. Christophe
Visarion Alexandru (2): config: Add vnc host setter config: Add spice host setter
libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.c | 10 ++++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-spice.h | 3 +++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.c | 9 +++++++++ libvirt-gconfig/libvirt-gconfig-domain-graphics-vnc.h | 3 +++ libvirt-gconfig/libvirt-gconfig.sym | 2 ++ 5 files changed, 27 insertions(+)
-- 2.7.4
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Christophe Fergeau -
Visarion Alexandru