[PATCH] News: Several apparmor improvements at v6.7.0

From: jgao <jgao@redhat.com> Add news about apparmor about the improvements. Signed-off-by: jgao <jgao@redhat.com> --- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/NEWS.rst b/NEWS.rst index 905deba5a8..30a4f1065a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -224,6 +224,11 @@ v6.7.0 (2020-09-01) forbidden and no size auto-alignment will be made. Instead, libvirt will suggest an aligned round up size for the user. + * apparmor: Several improvements + + Add support for virtiofs filesystem, allowing qemu load old shared objects after + upgrades. + * **Bug fixes** * virdevmapper: Deal with kernels without DM support -- 2.21.3

Trivial advice: Mention your patch version in the title of the email. See the last sentence of https://libvirt.org/submitting-patches.html On Mon, Nov 9, 2020 at 3:35 PM jgao <jgao@redhat.com> wrote:
From: jgao <jgao@redhat.com>
Add news about apparmor about the improvements.
Signed-off-by: jgao <jgao@redhat.com>
For a single patch, add --- below signed-off-by and then mention the difference from the previous patch version. For a patch series, mention that changes in the cover letter. See https://www.kernel.org/doc/html/latest/process/submitting-patches.html#the-c...
--- NEWS.rst | 5 +++++ 1 file changed, 5 insertions(+)
diff --git a/NEWS.rst b/NEWS.rst index 905deba5a8..30a4f1065a 100644 --- a/NEWS.rst +++ b/NEWS.rst @@ -224,6 +224,11 @@ v6.7.0 (2020-09-01) forbidden and no size auto-alignment will be made. Instead, libvirt will suggest an aligned round up size for the user.
+ * apparmor: Several improvements + + Add support for virtiofs filesystem, allowing qemu load old shared objects after + upgrades. + * **Bug fixes**
* virdevmapper: Deal with kernels without DM support -- 2.21.3
-- Reviewed-by: Han Han <hhan@redhat.com>

Please don't CC individual developers when posting patches: we're all subscribed to the mailing list. On Mon, 2020-11-09 at 15:33 +0800, jgao wrote:
From: jgao <jgao@redhat.com>
Add news about apparmor about the improvements.
Signed-off-by: jgao <jgao@redhat.com>
Please make sure both the Signed-off-by tag and git authorship information are in the form FirstName LastName <email> We generally can't accept patches that don't have a S-o-b in that format.
+ * apparmor: Several improvements + + Add support for virtiofs filesystem, allowing qemu load old shared objects after + upgrades.
These are completely distinct changes, but the way you constructed your sentence makes it appear as if they were connected. I suggest something like Add support for the virtiofs filesystem and allow QEMU to load old modules after upgrade. Does that sound good to you? -- Andrea Bolognani / Red Hat / Virtualization

Hi Andrea, Thanks for your advice, i'll try again with your suggestions! Jianan Gao On Thu, Nov 12, 2020 at 9:45 PM Andrea Bolognani <abologna@redhat.com> wrote:
Please don't CC individual developers when posting patches: we're all subscribed to the mailing list.
On Mon, 2020-11-09 at 15:33 +0800, jgao wrote:
From: jgao <jgao@redhat.com>
Add news about apparmor about the improvements.
Signed-off-by: jgao <jgao@redhat.com>
Please make sure both the Signed-off-by tag and git authorship information are in the form
FirstName LastName <email>
We generally can't accept patches that don't have a S-o-b in that format.
+ * apparmor: Several improvements + + Add support for virtiofs filesystem, allowing qemu load old shared objects after + upgrades.
These are completely distinct changes, but the way you constructed your sentence makes it appear as if they were connected. I suggest something like
Add support for the virtiofs filesystem and allow QEMU to load old modules after upgrade.
Does that sound good to you?
-- Andrea Bolognani / Red Hat / Virtualization
participants (4)
-
Andrea Bolognani
-
Han Han
-
jgao
-
Jianan Gao