[libvirt] [PATCH][reordered] gitignore: ignore more files
ignore *.patch, cscope.po.out, cscope.in.out Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> --- .gitignore | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-) diff --git a/.gitignore b/.gitignore index 1cd2d45..3672131 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ *.loT *.o *.orig +*.patch *.pyc *.rej *.s @@ -184,7 +185,9 @@ Makefile.in TAGS coverage cscope.files +cscope.in.out cscope.out +cscope.po.out results.log stamp-h stamp-h.in -- 1.7.1
On 11/01/12 10:30, liguang wrote:
ignore *.patch, cscope.po.out, cscope.in.out
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> --- .gitignore | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore index 1cd2d45..3672131 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ *.loT *.o *.orig +*.patch
Hm, also I'd prefer having .patch kept unignored for two reasons: 1) there are several .patch files in the tree: $ git ls-files | grep "\.patch" docs/api_extension/0001-add-to-xml.patch docs/api_extension/0002-add-new-public-API.patch docs/api_extension/0003-define-internal-driver-API.patch docs/api_extension/0004-implement-the-public-APIs.patch docs/api_extension/0005-implement-the-remote-protocol.patch docs/api_extension/0006-make-old-API-trivially-wrap-to-new-API.patch docs/api_extension/0007-add-virsh-support.patch docs/api_extension/0008-support-new-xml.patch docs/api_extension/0009-support-all-flags-in-test-driver.patch docs/api_extension/0010-improve-vcpu-support-in-qemu-command-line.patch docs/api_extension/0011-complete-vcpu-support-in-qemu-driver.patch docs/api_extension/0012-improve-vcpu-support-in-xen-command-line.patch docs/api_extension/0013-improve-getting-xen-vcpu-counts.patch docs/api_extension/0014-improve-setting-xen-vcpu-counts.patch docs/api_extension/0015-remove-dead-xen-code.patch so changes to these would pose problems 2) this actually reminds you clean your tree before pushing changes and removes the possibility of accidentally sending wrong patches with "git send-email *.patch"
*.pyc *.rej *.s
Peter
On 11/02/2012 05:05 AM, Peter Krempa wrote:
On 11/01/12 10:30, liguang wrote:
ignore *.patch, cscope.po.out, cscope.in.out
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> --- .gitignore | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore index 1cd2d45..3672131 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ *.loT *.o *.orig +*.patch
Hm, also I'd prefer having .patch kept unignored for two reasons: 1) there are several .patch files in the tree:
$ git ls-files | grep "\.patch" docs/api_extension/0001-add-to-xml.patch
so changes to these would pose problems
Not if we also add an inclusion rule: !/docs/api_extension/*.patch
2) this actually reminds you clean your tree before pushing changes and removes the possibility of accidentally sending wrong patches with "git send-email *.patch"
This reason I agree with, and concur with NACK'ing the patch. If you want to ignore .patch files locally, then: echo '*.patch' >> .git/info/exclude -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
在 2012-11-02五的 12:05 +0100，Peter Krempa写道：
On 11/01/12 10:30, liguang wrote:
ignore *.patch, cscope.po.out, cscope.in.out
Signed-off-by: liguang <lig.fnst@cn.fujitsu.com> --- .gitignore | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/.gitignore b/.gitignore index 1cd2d45..3672131 100644 --- a/.gitignore +++ b/.gitignore @@ -13,6 +13,7 @@ *.loT *.o *.orig +*.patch
Hm, also I'd prefer having .patch kept unignored for two reasons: 1) there are several .patch files in the tree:
$ git ls-files | grep "\.patch" docs/api_extension/0001-add-to-xml.patch docs/api_extension/0002-add-new-public-API.patch docs/api_extension/0003-define-internal-driver-API.patch docs/api_extension/0004-implement-the-public-APIs.patch docs/api_extension/0005-implement-the-remote-protocol.patch docs/api_extension/0006-make-old-API-trivially-wrap-to-new-API.patch docs/api_extension/0007-add-virsh-support.patch docs/api_extension/0008-support-new-xml.patch docs/api_extension/0009-support-all-flags-in-test-driver.patch docs/api_extension/0010-improve-vcpu-support-in-qemu-command-line.patch docs/api_extension/0011-complete-vcpu-support-in-qemu-driver.patch docs/api_extension/0012-improve-vcpu-support-in-xen-command-line.patch docs/api_extension/0013-improve-getting-xen-vcpu-counts.patch docs/api_extension/0014-improve-setting-xen-vcpu-counts.patch docs/api_extension/0015-remove-dead-xen-code.patch
so changes to these would pose problems
2) this actually reminds you clean your tree before pushing changes and removes the possibility of accidentally sending wrong patches with "git send-email *.patch"
Maybe, I'll remove *.patch ignore
*.pyc *.rej *.s
Peter
-- liguang lig.fnst@cn.fujitsu.com FNST linux kernel team
participants (4)
-
Eric Blake -
li guang -
liguang
-
Peter Krempa