On 11/01/2011 01:38 AM, Eric Blake wrote:
On 10/29/2011 11:12 AM, ajia(a)redhat.com wrote:
> From: Alex Jia<ajia(a)redhat.com>
>
> Detected by Coverity. Leak introduced in commit baf2ff7.
>
> * daemon/remote.c: Clean up on failure.
>
> Signed-off-by: Alex Jia<ajia(a)redhat.com>
> ---
> daemon/remote.c | 2 ++
> 1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/daemon/remote.c b/daemon/remote.c
> index f5141b9..173cd92 100644
> --- a/daemon/remote.c
> +++ b/daemon/remote.c
> @@ -498,6 +498,8 @@ static int
> remoteRelayDomainEventDiskChange(virConnectPtr conn ATTRIBUTE_UNUSED,
>
> mem_error:
> virReportOOMError();
> + VIR_FREE(oldSrcPath_p);
> + VIR_FREE(newSrcPath_p);
NACK. Already fixed by commit 457d46ca.
Yeah, Michal has fixed this issue, thanks for your review.
Alex