[libvirt] [PATCH] qemu: plug memory leak
From: Alex Jia <ajia@redhat.com> Detected by Coverity. Leak introduced in commit 6cabc0b. * src/qemu/qemu_command.c: Clean up on failure. Signed-off-by: Alex Jia <ajia@redhat.com> --- src/qemu/qemu_command.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0936492..02958cb 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4995,6 +4995,7 @@ qemuBuildCommandLine(virConnectPtr conn, } if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6) { + VIR_FREE(modstr); qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("this QEMU binary lacks hda support")); goto error; -- 1.7.1
From: Alex Jia <ajia@redhat.com> Detected by Coverity. Leak introduced in commit baf2ff7. * daemon/remote.c: Clean up on failure. Signed-off-by: Alex Jia <ajia@redhat.com> --- daemon/remote.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/daemon/remote.c b/daemon/remote.c index f5141b9..173cd92 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -498,6 +498,8 @@ static int remoteRelayDomainEventDiskChange(virConnectPtr conn ATTRIBUTE_UNUSED, mem_error: virReportOOMError(); + VIR_FREE(oldSrcPath_p); + VIR_FREE(newSrcPath_p); return -1; } -- 1.7.1
On 10/29/2011 11:12 AM, ajia@redhat.com wrote:
From: Alex Jia<ajia@redhat.com>
Detected by Coverity. Leak introduced in commit baf2ff7.
* daemon/remote.c: Clean up on failure.
Signed-off-by: Alex Jia<ajia@redhat.com> --- daemon/remote.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c index f5141b9..173cd92 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -498,6 +498,8 @@ static int remoteRelayDomainEventDiskChange(virConnectPtr conn ATTRIBUTE_UNUSED,
mem_error: virReportOOMError(); + VIR_FREE(oldSrcPath_p); + VIR_FREE(newSrcPath_p);
NACK. Already fixed by commit 457d46ca. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 11/01/2011 01:38 AM, Eric Blake wrote:
On 10/29/2011 11:12 AM, ajia@redhat.com wrote:
From: Alex Jia<ajia@redhat.com>
Detected by Coverity. Leak introduced in commit baf2ff7.
* daemon/remote.c: Clean up on failure.
Signed-off-by: Alex Jia<ajia@redhat.com> --- daemon/remote.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/daemon/remote.c b/daemon/remote.c index f5141b9..173cd92 100644 --- a/daemon/remote.c +++ b/daemon/remote.c @@ -498,6 +498,8 @@ static int remoteRelayDomainEventDiskChange(virConnectPtr conn ATTRIBUTE_UNUSED,
mem_error: virReportOOMError(); + VIR_FREE(oldSrcPath_p); + VIR_FREE(newSrcPath_p);
NACK. Already fixed by commit 457d46ca.
Yeah, Michal has fixed this issue, thanks for your review. Alex
On 10/29/2011 11:12 AM, ajia@redhat.com wrote:
From: Alex Jia<ajia@redhat.com>
Detected by Coverity. Leak introduced in commit 6cabc0b.
* src/qemu/qemu_command.c: Clean up on failure.
Signed-off-by: Alex Jia<ajia@redhat.com> --- src/qemu/qemu_command.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c index 0936492..02958cb 100644 --- a/src/qemu/qemu_command.c +++ b/src/qemu/qemu_command.c @@ -4995,6 +4995,7 @@ qemuBuildCommandLine(virConnectPtr conn, }
if (sound->model == VIR_DOMAIN_SOUND_MODEL_ICH6) { + VIR_FREE(modstr); qemuReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("this QEMU binary lacks hda support")); goto error;
ACK and pushed. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
participants (3)
-
ajia＠redhat.com -
Alex Jia
-
Eric Blake