This has been broken for a looong time - in fact, we've been shipping a mostly-empty NEWS file for at least the past two years. Including the html namespace and using it for matching elements, like hacking1.xsl and hacking2.xsl were already doing, makes the NEWS file useful again. Add a note explaining that the release list has been split up by year as well. --- docs/news.xsl | 30 ++++++++++++++++++------------ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/docs/news.xsl b/docs/news.xsl index e35030e..916bc4b 100644 --- a/docs/news.xsl +++ b/docs/news.xsl @@ -1,39 +1,46 @@ <?xml version="1.0"?> -<xsl:stylesheet xmlns:xsl="http://www.w3.org/1999/XSL/Transform" - version="1.0"> +<xsl:stylesheet version="1.0" + xmlns:html="http://www.w3.org/1999/xhtml" + xmlns:xsl="http://www.w3.org/1999/XSL/Transform"> <xsl:output method="text" encoding="UTF-8"/> <xsl:template match="/"> <xsl:text> NEWS file for libvirt - Note that this is automatically generated from the news webpage at: + Note that this file contains only the most recent releases; for the full + list, please visit: http://libvirt.org/news.html </xsl:text> - <xsl:apply-templates select="html/body/*"/> + <xsl:apply-templates select="html:html/html:body/*"/> </xsl:template> - <xsl:template match="h1"/> - <xsl:template match="h3"> + <xsl:template match="html:h1"/> + <xsl:template match="html:p"/> + + <xsl:template match="html:h3"> <xsl:text> </xsl:text> <xsl:apply-templates/> <xsl:text>: </xsl:text> </xsl:template> - <xsl:template match="ul"> - <xsl:apply-templates select=".//li"/> + + <xsl:template match="html:ul"> + <xsl:apply-templates select="html:li"/> <xsl:text> </xsl:text> </xsl:template> - <xsl:template match="li"> + + <xsl:template match="html:li"> <xsl:text> - </xsl:text> <xsl:value-of select="."/> <xsl:text> </xsl:text> </xsl:template> - <xsl:template match="a"> + + <xsl:template match="html:a"> <xsl:value-of select="."/> <xsl:text> at </xsl:text> @@ -41,6 +48,5 @@ <xsl:text> </xsl:text> </xsl:template> - <xsl:template match="p"> - </xsl:template> + </xsl:stylesheet> -- 2.4.3

On Thu, Oct 15, 2015 at 04:12:07PM +0200, Andrea Bolognani wrote:

As agreed, I've followed up with the cleanups by splitting the huge news.html.in file into separate, smaller files, one per year.

Along with the split I've also included a fixed XSLT stylesheet so that we can start shipping a meaningful NEWS file again.

Cheers.

I like it, it looks nice, there are just two issues here: 1) the NEWS file is not generated if I run 'make all', I don't know whether that should or should not happen, so feel free to debate me on that one, 2) syntax-check fails with this series, but that's not because there would be anything wrong with the files you've added, it's just an exclusion rule missing them. The following should be either squashed in the first patch or added as a separate patch before the first one: diff --git i/cfg.mk w/cfg.mk index e4364348434e..391f37b4c7c6 100644 --- i/cfg.mk +++ w/cfg.mk @@ -90,7 +90,7 @@ endif # Files that should never cause syntax check failures. VC_LIST_ALWAYS_EXCLUDE_REGEX = \ - (^(HACKING|docs/(news\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$ + (^(HACKING|docs/(news(-[0-9]*)?\.html\.in|.*\.patch))|\.(po|fig|gif|ico|png))$$ # Functions like free() that are no-ops on NULL arguments. useless_free_options = \ -- ACK series with that fixed.

Andrea Bolognani (3): NEWS: Split releases by year (2005-2011) NEWS: Split releases by year (2012-2015) NEWS: Fix XSLT stylesheet

docs/news-2005.html.in | 28 + docs/news-2006.html.in | 354 + docs/news-2007.html.in | 534 ++ docs/news-2008.html.in | 580 ++ docs/news-2009.html.in | 1603 ++++ docs/news-2010.html.in | 2218 ++++++ docs/news-2011.html.in | 3314 +++++++++ docs/news-2012.html.in | 3012 ++++++++ docs/news-2013.html.in | 3675 ++++++++++ docs/news-2014.html.in | 3418 +++++++++ docs/news.html.in | 18544 +---------------------------------------------- docs/news.xsl | 30 +- 12 files changed, 18759 insertions(+), 18551 deletions(-) create mode 100644 docs/news-2005.html.in create mode 100644 docs/news-2006.html.in create mode 100644 docs/news-2007.html.in create mode 100644 docs/news-2008.html.in create mode 100644 docs/news-2009.html.in create mode 100644 docs/news-2010.html.in create mode 100644 docs/news-2011.html.in create mode 100644 docs/news-2012.html.in create mode 100644 docs/news-2013.html.in create mode 100644 docs/news-2014.html.in

-- 2.4.3

-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list