On 05/07/2011, at 1:23 AM, Matthias Bolte wrote:

2011/7/4 Justin Clift <jclift@redhat.com>:

...

Just went to update the OSX libvirt build for 0.9.3, but it's giving a duplicate symbol error:

ld: duplicate symbol _virNetworkDNSHostsDef in ./.libs/libvirt_driver_test.a(libvirt_driver_test_la-test_driver.o) and ./.libs/libvirt_conf.a(libvirt_conf_la-network_conf.o)

"virNetworkDNSHostsDef" is definitely in src/conf/network_conf.*, but not seeing it anywhere in src/test/test_driver.*.

The problem seems to the the struct A {} A; style. This looks bogus. Here's a patch that might fix it.

Thanks Matthias, that fixes it perfectly. :) Just incorporated your patch into the new OSX 0.9.3 libvirt build. Should be live to the wider OSX public within 24 hours or so. :) Regards and best wishes, Justin Clift -- Aeolus Community Manager http://www.aeolusproject.org

On 05/07/2011, at 6:46 PM, Matthias Bolte wrote:

2011/7/5 Justin Clift <jclift@redhat.com>:

...

Thanks Matthias, that fixes it perfectly. :)

Just incorporated your patch into the new OSX 0.9.3 libvirt build. Should be live to the wider OSX public within 24 hours or so. :)

Regards and best wishes,

Justin Clift

I take that as an ACK and pushed the patch.

Oops, yes, definitely ACK. :) Regards and best wishes, Justin Clift -- Aeolus Community Manager http://www.aeolusproject.org