[libvirt] [PATCH] prevent an executed external process to be a zombie
Hi, This patch prevents an executed external process to be a zombie by doing waitpid() even if virPipeReadUntilEOF() fails. Thanks, ozaki-r Signed-off-by: Ryota Ozaki <ozaki.ryota@gmail.com>
On Mon, Mar 30, 2009 at 12:49:55AM +0900, Ryota Ozaki wrote:
Hi,
This patch prevents an executed external process to be a zombie by doing waitpid() even if virPipeReadUntilEOF() fails.
ACK patch looks good NB, can you fix your mail client so that it attaches patches with MIME type of 'text/plain', not 'application/octet-stream'. The latter makes it impossible to reply & quote the patch. Failing that, include the patch inline in the body of the message. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Hi Daniel, On Mon, Mar 30, 2009 at 6:18 PM, Daniel P. Berrange <berrange@redhat.com> wrote:
On Mon, Mar 30, 2009 at 12:49:55AM +0900, Ryota Ozaki wrote:
Hi,
This patch prevents an executed external process to be a zombie by doing waitpid() even if virPipeReadUntilEOF() fails.
ACK patch looks good
NB, can you fix your mail client so that it attaches patches with MIME type of 'text/plain', not 'application/octet-stream'. The latter makes it impossible to reply & quote the patch.
hmm, I'm using Gmail but I have no idea how to deal with that.
Failing that, include the patch inline in the body of the message.
so I'll do this next time on. Thanks, anyway. ozaki-r
Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Mon, Mar 30, 2009 at 12:49:55AM +0900, Ryota Ozaki wrote:
Hi,
This patch prevents an executed external process to be a zombie by doing waitpid() even if virPipeReadUntilEOF() fails.
Makes sense, applied and commited, thanks a lot ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (3)
-
Daniel P. Berrange -
Daniel Veillard -
Ryota Ozaki