[libvirt] [PATCH] Remove pointless virLXCProcessMonitorDestroy method

From: "Daniel P. Berrange" <berrange@redhat.com> Asynchronously setting priv->mon to NULL was pointless, just remove the destroy callback entirely. Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_process.c | 15 --------------- 1 file changed, 15 deletions(-) diff --git a/src/lxc/lxc_process.c b/src/lxc/lxc_process.c index 15572cd..b9cff85 100644 --- a/src/lxc/lxc_process.c +++ b/src/lxc/lxc_process.c @@ -554,20 +554,6 @@ cleanup: } -static void virLXCProcessMonitorDestroy(virLXCMonitorPtr mon, - virDomainObjPtr vm) -{ - virLXCDomainObjPrivatePtr priv; - - virDomainObjLock(vm); - priv = vm->privateData; - if (priv->monitor == mon) - priv->monitor = NULL; - if (virObjectUnref(vm)) - virDomainObjUnlock(vm); -} - - extern virLXCDriverPtr lxc_driver; static void virLXCProcessMonitorEOFNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED, virDomainObjPtr vm) @@ -649,7 +635,6 @@ static void virLXCProcessMonitorExitNotify(virLXCMonitorPtr mon ATTRIBUTE_UNUSED static virLXCMonitorCallbacks monitorCallbacks = { .eofNotify = virLXCProcessMonitorEOFNotify, - .destroy = virLXCProcessMonitorDestroy, .exitNotify = virLXCProcessMonitorExitNotify, }; -- 1.7.11.2

On 09/25/2012 02:29 PM, Daniel P. Berrange wrote:
From: "Daniel P. Berrange" <berrange@redhat.com>
Asynchronously setting priv->mon to NULL was pointless, just remove the destroy callback entirely.
Signed-off-by: Daniel P. Berrange <berrange@redhat.com> --- src/lxc/lxc_process.c | 15 --------------- 1 file changed, 15 deletions(-)
ACK. -- Eric Blake eblake@redhat.com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (2)
-
Daniel P. Berrange
-
Eric Blake