[libvirt] [libvirt-designer][PATCH 1/2] cfg.mk: Update list of syntax-check exceptions
The bindtextdomain syntax-check macro is doing some dumb checking: each file containing '\<main *(' must call bindtextdomain. Even if it's mentioned inside a comment block, which we do as of e71ad8e13e7. --- Or shall we drop bindtextdomain rule instead? cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cfg.mk b/cfg.mk index 54f62d4..1e4b31d 100644 --- a/cfg.mk +++ b/cfg.mk @@ -104,8 +104,8 @@ sc_copyright_format: prev_version_file = /dev/null -exclude_file_name_regexp--sc_bindtextdomain = ^(libvirt-designer/test)|(libvirt-designer/libvirt-designer-init-*)|(examples/virtxml.c) +exclude_file_name_regexp--sc_bindtextdomain = ^libvirt-designer/(test|libvirt-designer-main\.c)|^examples/virtxml\.c$$ -exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch] +exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch]$$ -exclude_file_name_regexp--sc_prohibit_strcmp = ^libvirt-designer/libvirt-designer-init-qemu.c +exclude_file_name_regexp--sc_prohibit_strcmp = ^libvirt-designer/libvirt-designer-init-qemu.c$$ -- 1.8.1.5
--- libvirt-designer/libvirt-designer-main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libvirt-designer/libvirt-designer-main.c b/libvirt-designer/libvirt-designer-main.c index ce69024..07de8c1 100644 --- a/libvirt-designer/libvirt-designer-main.c +++ b/libvirt-designer/libvirt-designer-main.c @@ -38,7 +38,7 @@ * understood by GTK+ are stripped before return. */ void gvir_designer_init(int *argc, - char ***argv) + char ***argv) { GError *err = NULL; if (!gvir_designer_init_check(argc, argv, &err)) { @@ -65,8 +65,8 @@ static void gvir_log_handler(const gchar *log_domain G_GNUC_UNUSED, * @err: pointer to a #GError to which a message will be posted on error */ gboolean gvir_designer_init_check(int *argc, - char ***argv, - GError **err) + char ***argv, + GError **err) { if (!gvir_config_init_check(argc, argv, err)) return FALSE; -- 1.8.1.5
ACK On Fri, Apr 19, 2013 at 11:24:31AM +0200, Michal Privoznik wrote:
--- libvirt-designer/libvirt-designer-main.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libvirt-designer/libvirt-designer-main.c b/libvirt-designer/libvirt-designer-main.c index ce69024..07de8c1 100644 --- a/libvirt-designer/libvirt-designer-main.c +++ b/libvirt-designer/libvirt-designer-main.c @@ -38,7 +38,7 @@ * understood by GTK+ are stripped before return. */ void gvir_designer_init(int *argc, - char ***argv) + char ***argv) { GError *err = NULL; if (!gvir_designer_init_check(argc, argv, &err)) { @@ -65,8 +65,8 @@ static void gvir_log_handler(const gchar *log_domain G_GNUC_UNUSED, * @err: pointer to a #GError to which a message will be posted on error */ gboolean gvir_designer_init_check(int *argc, - char ***argv, - GError **err) + char ***argv, + GError **err) { if (!gvir_config_init_check(argc, argv, err)) return FALSE; -- 1.8.1.5
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
ACK Christophe On Fri, Apr 19, 2013 at 11:24:30AM +0200, Michal Privoznik wrote:
The bindtextdomain syntax-check macro is doing some dumb checking: each file containing '\<main *(' must call bindtextdomain. Even if it's mentioned inside a comment block, which we do as of e71ad8e13e7. ---
Or shall we drop bindtextdomain rule instead?
cfg.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/cfg.mk b/cfg.mk index 54f62d4..1e4b31d 100644 --- a/cfg.mk +++ b/cfg.mk @@ -104,8 +104,8 @@ sc_copyright_format: prev_version_file = /dev/null
-exclude_file_name_regexp--sc_bindtextdomain = ^(libvirt-designer/test)|(libvirt-designer/libvirt-designer-init-*)|(examples/virtxml.c) +exclude_file_name_regexp--sc_bindtextdomain = ^libvirt-designer/(test|libvirt-designer-main\.c)|^examples/virtxml\.c$$
-exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch] +exclude_file_name_regexp--sc_preprocessor_indentation = ^*/*.[ch]$$
-exclude_file_name_regexp--sc_prohibit_strcmp = ^libvirt-designer/libvirt-designer-init-qemu.c +exclude_file_name_regexp--sc_prohibit_strcmp = ^libvirt-designer/libvirt-designer-init-qemu.c$$ -- 1.8.1.5
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (2)
-
Christophe Fergeau -
Michal Privoznik