[libvirt] [PATCH] storage: Fix broken storage_driver build

Commit id '5d5c732d7' had an incorrect assignment and was found by travis build: storage/storage_driver.c:1668:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if ((obj == virStoragePoolObjListSearch(&driver->pools, ~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Signed-off-by: John Ferlan <jferlan@redhat.com> --- <sigh> Where are those damn pink ears. Pushed as a build breaker. src/storage/storage_driver.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/storage/storage_driver.c b/src/storage/storage_driver.c index cb45052ef7..561ca36f90 100644 --- a/src/storage/storage_driver.c +++ b/src/storage/storage_driver.c @@ -1665,9 +1665,9 @@ storagePoolLookupByTargetPath(virConnectPtr conn, return NULL; storageDriverLock(); - if ((obj == virStoragePoolObjListSearch(&driver->pools, - storagePoolLookupByTargetPathCallback, - path))) { + if ((obj = virStoragePoolObjListSearch(&driver->pools, + storagePoolLookupByTargetPathCallback, + path))) { def = virStoragePoolObjGetDef(obj); pool = virGetStoragePool(conn, def->name, def->uuid, NULL, NULL); virStoragePoolObjEndAPI(&obj); -- 2.13.6

On 11/24/2017 03:45 PM, John Ferlan wrote:
Commit id '5d5c732d7' had an incorrect assignment and was found by travis build:
storage/storage_driver.c:1668:14: error: equality comparison with extraneous parentheses [-Werror,-Wparentheses-equality] if ((obj == virStoragePoolObjListSearch(&driver->pools,
~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
Signed-off-by: John Ferlan <jferlan@redhat.com> ---
<friday>
<sigh> Where are those damn pink ears.
There's a git hook script that takes a picture with webcam on every git commit [1]. We can set it up and be required to take a selfie when committing fixes like this :-) 1: https://lolcommits.github.io/ </friday> Michal
participants (2)
-
John Ferlan
-
Michal Privoznik