Hi guys, Just tried "make rpm" with git head, on RHEL 6.x. It gave the following failure: make[1]: Leaving directory `/home/jc/git_repos/libvirt' make[1]: Entering directory `/home/jc/git_repos/libvirt' { test ! -d "libvirt-0.9.6" || { find "libvirt-0.9.6" -type d ! -perm -200 -exec chmod u+w {} ';' && rm -fr "libvirt-0.9.6"; }; } test -d "libvirt-0.9.6" || mkdir "libvirt-0.9.6" cp: cannot stat `./NEWS': No such file or directory make[1]: *** [distdir] Error 1 make[1]: Leaving directory `/home/jc/git_repos/libvirt' make: *** [rpm] Error 2 Anyone want to fix it prior to 0.9.7? :)

At 11/08/2011 02:22 PM, Justin Clift Write: > On 08/11/2011, at 5:17 PM, Justin Clift wrote: >> Hi guys, >> >> Just tried "make rpm" with git head, on RHEL 6.x. >> >> It gave the following failure: >> >> make[1]: Leaving directory `/home/jc/git_repos/libvirt' >> make[1]: Entering directory `/home/jc/git_repos/libvirt' >> { test ! -d "libvirt-0.9.6" || { find "libvirt-0.9.6" -type d ! -perm -200 -exec chmod u+w {} ';'&& rm -fr "libvirt-0.9.6"; }; } >> test -d "libvirt-0.9.6" || mkdir "libvirt-0.9.6" >> cp: cannot stat `./NEWS': No such file or directory I do not know why NEWS disappears. >> make[1]: *** [distdir] Error 1 >> make[1]: Leaving directory `/home/jc/git_repos/libvirt' >> make: *** [rpm] Error 2 >> >> Anyone want to fix it prior to 0.9.7? :) > As additional info, after doing a "touch NEWS" just to get it > past this point, it then fails with: > > make[2]: Leaving directory `/home/jc/git_repos/libvirt/include' > (cd src&& make top_distdir=../libvirt-0.9.6 distdir=../libvirt-0.9.6/src \ > am__remove_distdir=: am__skip_length_check=: am__skip_mode_fix=: distdir) > make[2]: Entering directory `/home/jc/git_repos/libvirt/src' > make[2]: *** No rule to make target `probes.h', needed by `distdir'. Stop. > make[2]: Leaving directory `/home/jc/git_repos/libvirt/src' > make[1]: *** [distdir] Error 1 > make[1]: Leaving directory `/home/jc/git_repos/libvirt' > make: *** [rpm] Error 2 > > This is a newly setup RHEL 6.1 x64 VM, with the "Development Tools" yum > package group installed, plus minimal -devel packages to let configure > succeed. I use RHEL6.1 x64 too. But I do not meet this problem. I think you do not install this package: systemtap-sdt-devel. Thanks Wen Congyang > Any ideas? > > Regards and best wishes, > > Justin Clift > > -- > Aeolus Community Manager > http://www.aeolusproject.org > > > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list > -- libvir-list mailing list libvir-list(a)redhat.com https://www.redhat.com/mailman/listinfo/libvir-list

At 11/08/2011 05:09 PM, Wenyi Gao Write: > On 2011年11月08日 16:58, Wen Congyang wrote: >> At 11/08/2011 02:22 PM, Justin Clift Write: >>> On 08/11/2011, at 5:17 PM, Justin Clift wrote: >>>> Hi guys, >>>> >>>> Just tried "make rpm" with git head, on RHEL 6.x. >>>> >>>> It gave the following failure: >>>> >>>> make[1]: Leaving directory `/home/jc/git_repos/libvirt' >>>> make[1]: Entering directory `/home/jc/git_repos/libvirt' >>>> { test ! -d "libvirt-0.9.6" || { find "libvirt-0.9.6" -type d ! >>>> -perm -200 -exec chmod u+w {} ';'&& rm -fr "libvirt-0.9.6"; }; } >>>> test -d "libvirt-0.9.6" || mkdir "libvirt-0.9.6" >>>> cp: cannot stat `./NEWS': No such file or directory >> I do not know why NEWS disappears. >> >>>> make[1]: *** [distdir] Error 1 >>>> make[1]: Leaving directory `/home/jc/git_repos/libvirt' >>>> make: *** [rpm] Error 2 >>>> >>>> Anyone want to fix it prior to 0.9.7? :) >>> As additional info, after doing a "touch NEWS" just to get it >>> past this point, it then fails with: >>> >>> make[2]: Leaving directory `/home/jc/git_repos/libvirt/include' >>> (cd src&& make top_distdir=../libvirt-0.9.6 >>> distdir=../libvirt-0.9.6/src \ >>> am__remove_distdir=: am__skip_length_check=: >>> am__skip_mode_fix=: distdir) >>> make[2]: Entering directory `/home/jc/git_repos/libvirt/src' >>> make[2]: *** No rule to make target `probes.h', needed by >>> `distdir'. Stop. >>> make[2]: Leaving directory `/home/jc/git_repos/libvirt/src' >>> make[1]: *** [distdir] Error 1 >>> make[1]: Leaving directory `/home/jc/git_repos/libvirt' >>> make: *** [rpm] Error 2 >>> >>> This is a newly setup RHEL 6.1 x64 VM, with the "Development Tools" yum >>> package group installed, plus minimal -devel packages to let configure >>> succeed. >> I use RHEL6.1 x64 too. But I do not meet this problem. >> >> I think you do not install this package: systemtap-sdt-devel. >> >> Thanks >> Wen Congyang >> >>> Any ideas? >>> >>> Regards and best wishes, >>> >>> Justin Clift >>> >>> -- >>> Aeolus Community Manager >>> http://www.aeolusproject.org >>> >>> >>> >>> -- >>> libvir-list mailing list >>> libvir-list(a)redhat.com >>> https://www.redhat.com/mailman/listinfo/libvir-list >>> >> -- >> libvir-list mailing list >> libvir-list(a)redhat.com >> https://www.redhat.com/mailman/listinfo/libvir-list >> > I also got the error on ubuntu 11.10 when run make distcheck > > libvirt$ make distcheck > > { test ! -d "libvirt-0.9.6" || { find "libvirt-0.9.6" -type d ! -perm > -200 -exec chmod u+w {} ';'&& rm -fr "libvirt-0.9.6"; }; } > test -d "libvirt-0.9.6" || mkdir "libvirt-0.9.6" > cp: cannot stat `./NEWS': No such file or directory > make: *** [distdir] Error 1 I seems that NEWS is not included in dist on your machine. Here is my Makefile: DIST_COMMON = README $(am__configure_deps) $(srcdir)/Makefile.am \ $(srcdir)/Makefile.in $(srcdir)/config.h.in \ $(srcdir)/libvirt.pc.in $(srcdir)/libvirt.spec.in \ $(srcdir)/mingw32-libvirt.spec.in $(top_srcdir)/configure \ ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog INSTALL NEWS \ TODO build-aux/compile build-aux/config.guess \ build-aux/config.rpath build-aux/config.sub build-aux/depcomp \ build-aux/install-sh build-aux/ltmain.sh build-aux/mdate-sh \ build-aux/missing build-aux/mkinstalldirs \ build-aux/texinfo.tex The DIST_COMMON contains NEWS. Does DIST_COMMON contain NEWS in your Makefile? Thanks Wen Congyang > >

I believe it's due to missing xsltproc binary? Wenyi, same as your earlier "failed to load external entity api.html.tmp" warning. On 11/08/2011 05:23 PM, Wenyi Gao wrote: >>> I also got the error on ubuntu 11.10 when run make distcheck >>> >>> libvirt$ make distcheck >>> >>> { test ! -d "libvirt-0.9.6" || { find "libvirt-0.9.6" -type d ! -perm >>> -200 -exec chmod u+w {} ';'&& rm -fr "libvirt-0.9.6"; }; } >>> test -d "libvirt-0.9.6" || mkdir "libvirt-0.9.6" >>> cp: cannot stat `./NEWS': No such file or directory >>> make: *** [distdir] Error 1 >> I seems that NEWS is not included in dist on your machine. >> >> Here is my Makefile: >> >> DIST_COMMON = README $(am__configure_deps) $(srcdir)/Makefile.am \ >> $(srcdir)/Makefile.in $(srcdir)/config.h.in \ >> $(srcdir)/libvirt.pc.in $(srcdir)/libvirt.spec.in \ >> $(srcdir)/mingw32-libvirt.spec.in $(top_srcdir)/configure \ >> ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog INSTALL NEWS \ >> TODO build-aux/compile build-aux/config.guess \ >> build-aux/config.rpath build-aux/config.sub build-aux/depcomp \ >> build-aux/install-sh build-aux/ltmain.sh build-aux/mdate-sh \ >> build-aux/missing build-aux/mkinstalldirs \ >> build-aux/texinfo.tex >> >> The DIST_COMMON contains NEWS. >> >> Does DIST_COMMON contain NEWS in your Makefile? >> >> Thanks >> Wen Congyang >>> > Yes, it also contain NEWS in my Makefile. > > DIST_COMMON = README $(am__configure_deps) $(srcdir)/Makefile.am \ > $(srcdir)/Makefile.in $(srcdir)/config.h.in \ > $(srcdir)/libvirt.pc.in $(srcdir)/libvirt.spec.in \ > $(srcdir)/mingw32-libvirt.spec.in $(top_srcdir)/configure \ > ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog INSTALL NEWS \ > TODO build-aux/compile build-aux/config.guess \ > build-aux/config.rpath build-aux/config.sub build-aux/depcomp \ > build-aux/install-sh build-aux/ltmain.sh build-aux/missing > > -- > libvir-list mailing list > libvir-list(a)redhat.com > https://www.redhat.com/mailman/listinfo/libvir-list

I seems that NEWS is not included in dist on your machine. Here is my Makefile: DIST_COMMON = README $(am__configure_deps) $(srcdir)/Makefile.am \ $(srcdir)/Makefile.in $(srcdir)/config.h.in \ $(srcdir)/libvirt.pc.in $(srcdir)/libvirt.spec.in \ $(srcdir)/mingw32-libvirt.spec.in $(top_srcdir)/configure \ ABOUT-NLS AUTHORS COPYING COPYING.LIB ChangeLog INSTALL NEWS \ TODO build-aux/compile build-aux/config.guess \ build-aux/config.rpath build-aux/config.sub build-aux/depcomp \ build-aux/install-sh build-aux/ltmain.sh build-aux/mdate-sh \ build-aux/missing build-aux/mkinstalldirs \ build-aux/texinfo.tex The DIST_COMMON contains NEWS. Does DIST_COMMON contain NEWS in your Makefile?

On 11/08/2011 02:37 AM, Justin Clift wrote: > > Found the problem with the NEWS file. It's because libxslt wasn't > installed. > Should we be adding libxslt as a maintainer's prereq in bootstrap.conf? That is, I think bootstrap.conf should require all packages necessary to

create a functional tarball from libvirt.git, even if those packages are _not_ required to successfully build an already-available tarball. > Still haven't found out the problem with probes.h though. Now looking at > that again. On 11/08/2011 01:58 AM, Wen Congyang wrote: > I think you do not install this package: systemtap-sdt-devel. So that sounds like systemtap is another maintainer prereq. On 11/08/2011 04:44 AM, Daniel Veillard wrote: > On Tue, Nov 08, 2011 at 04:33:15PM +0800, Wenyi Gao wrote: >> I got the latest code and build it with following error on Ubuntu 11.10: >> Validating api.html >> warning: failed to load external entity "api.html.tmp" > Try to get xsltproc and xmllint tools, they are in libxml2 and > libxslt packages, dunno the exact name in Debian/Ubuntu, possibly > some -bin package. Sounds like xmllint should be yet another maintainer prereq in bootstrap.conf.

On 09/11/2011, at 9:52 AM, Eric Blake wrote: > On 11/08/2011 02:37 AM, Justin Clift wrote: >> >> Found the problem with the NEWS file. It's because libxslt wasn't installed. > > Should we be adding libxslt as a maintainer's prereq in bootstrap.conf? > > That is, I think bootstrap.conf should require all packages necessary to create a functional tarball from libvirt.git, even if those packages are _not_ required to successfully build an already-available tarball. That sounds like it will fix the problem, pretty much permanently (until further requirements happen). Definitely in favour of that. :) >> Still haven't found out the problem with probes.h though. Now looking at >> that again. > > On 11/08/2011 01:58 AM, Wen Congyang wrote: >> I think you do not install this package: systemtap-sdt-devel. > > So that sounds like systemtap is another maintainer prereq. It's not the problem. For me anyway. To clarify, systemtap-sdt-devel is already installed. Doing a brand new autogen.sh, then compiling normally with:

make -j 3 Goes through to successful completion. All good. It's only "make rpm" which is having the problem: make[2]: Entering directory `/home/jc/git_repos/libvirt/src' make[2]: *** No rule to make target `probes.h', needed by `distdir'. Stop. make[2]: Leaving directory `/home/jc/git_repos/libvirt/src' make[1]: *** [distdir] Error 1 make[1]: Leaving directory `/home/jc/git_repos/libvirt' make: *** [rpm] Error 2 So, it sounds like there's something rpm specific which needs kicking into shape. Attaching the full session log file, showing the autogen run, the normal make run, and the make rpm run. Hopefully it helps. :) <snip> >>> Validating api.html >>> warning: failed to load external entity "api.html.tmp" > >> Try to get xsltproc and xmllint tools, they are in libxml2 and >> libxslt packages, dunno the exact name in Debian/Ubuntu, possibly >> some -bin package. > > Sounds like xmllint should be yet another maintainer prereq in bootstrap.conf. Yep, sounds like it. :) Regards and best wishes, Justin Clift -- Aeolus Community Manager http://www.aeolusproject.org

On another note, Eric, do you reckon it's possible to add the XHTML1 DTDs to maintainer requirements? Without them, generation of the html docs fails at the validation stage.