[libvirt] [PATCH] lxc: Resolve Coverity RESOURCE_LEAK
Commit id 'c27553b6e' added a return -1 in a failure path without also VIR_FREE(stack) Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/lxc/lxc_container.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index feb8fad..125e1c8 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -2463,6 +2463,7 @@ int lxcContainerStart(virDomainDefPtr def, virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Config askes for inherit net namespace " "as well as private network interfaces")); + VIR_FREE(stack); return -1; } VIR_DEBUG("Inheriting a net namespace"); -- 2.1.0
On Thu, Aug 27, 2015 at 07:08:24AM -0400, John Ferlan wrote:
Commit id 'c27553b6e' added a return -1 in a failure path without also VIR_FREE(stack)
Signed-off-by: John Ferlan <jferlan@redhat.com> --- src/lxc/lxc_container.c | 1 + 1 file changed, 1 insertion(+)
diff --git a/src/lxc/lxc_container.c b/src/lxc/lxc_container.c index feb8fad..125e1c8 100644 --- a/src/lxc/lxc_container.c +++ b/src/lxc/lxc_container.c @@ -2463,6 +2463,7 @@ int lxcContainerStart(virDomainDefPtr def, virReportError(VIR_ERR_CONFIG_UNSUPPORTED, "%s", _("Config askes for inherit net namespace " "as well as private network interfaces")); + VIR_FREE(stack); return -1; } VIR_DEBUG("Inheriting a net namespace");
ACK Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
participants (2)
-
Daniel P. Berrange -
John Ferlan