Re: [libvirt] [libvirt-php] rewrite checking for libxml2
I don't think you're supposed to inline pkg.m4 within aclocal...
I didn't check it carefully. But it was generated by autoreconf -fi, I'm not quite sure what exactly it did.
On Mon, Feb 21, 2011 at 10:16:04PM +0800, Lyre wrote:
I don't think you're supposed to inline pkg.m4 within aclocal...
I didn't check it carefully.
But it was generated by autoreconf -fi, I'm not quite sure what exactly it did.
The problem here is that 'aclocal.m4' is an auto-generated file and thus should never have been checked into GIT in the first place Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
So it was generated automatically using autoreconf -fi? If yes then I guess it could be fine to use it. Any opinion Diego? Michal On 02/21/2011 03:16 PM, Lyre wrote:
I don't think you're supposed to inline pkg.m4 within aclocal...
I didn't check it carefully.
But it was generated by autoreconf -fi, I'm not quite sure what exactly it did.
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
-- Michal Novotny<minovotn@redhat.com>, RHCE Virtualization Team (xen userspace), Red Hat
Il giorno lun, 21/02/2011 alle 15.34 +0100, Michal Novotny ha scritto:
Any opinion Diego?
As Daniel said, if you're using autoreconf you should not handle aclocal.m4 in git at all. For whatever reason I assumed you weren't using automake (in which case aclocal can be hand-edited). -- Diego Elio Pettenò — Flameeyes http://blog.flameeyes.eu/
participants (4)
-
Daniel P. Berrange -
Diego Elio Pettenò -
Lyre -
Michal Novotny