[libvirt] [ libvirt ] [ PATCH ] Added support for ARMv7 Big Endian
Hi All, Could you please review below patch, I have successfully tested patch on ARM Versatile Express V2P Board. From: Yogesh Tillu <tillu.yogesh@gmail.com> Date: Thu, 5 Sep 2013 17:07:55 +0530 Subject: [PATCH] [ PATCH ] Added Support for ARMv7 Big Endian Signed-off-by: Yogesh Tillu <tillu.yogesh@gmail.com> --- src/util/virarch.c | 1 + src/util/virarch.h | 1 + 2 files changed, 2 insertions(+) diff --git a/src/util/virarch.c b/src/util/virarch.c index 81558e5..b4e06da 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -37,6 +37,7 @@ static const struct virArchData { { "alpha", 64, VIR_ARCH_BIG_ENDIAN }, { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, + { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, { "i686", 32, VIR_ARCH_LITTLE_ENDIAN }, diff --git a/src/util/virarch.h b/src/util/virarch.h index 0d8ae25..dd25679 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@ -29,6 +29,7 @@ typedef enum { VIR_ARCH_ALPHA, /* Alpha 64 BE http://en.wikipedia.org/wiki/DEC_Alpha */ VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ + VIR_ARCH_ARMV7B, /* ARMv7 32 BE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_CRIS, /* ETRAX 32 LE http://en.wikipedia.org/wiki/ETRAX_CRIS */ VIR_ARCH_I686, /* x86 32 LE http://en.wikipedia.org/wiki/X86 */ -- 1.8.1.2 Test Performed: # virsh nodeinfo CPU model: armv7b CPU(s): 1 CPU frequency: 48 MHz CPU socket(s): 1 Core(s) per socket: 5 Thread(s) per core: 1 NUMA cell(s): 1 Memory size: 1029784 KiB Regards, Yogesh Tillu
Hi All, Could you please let me know to whom should I contact to review this patch and for approval to get into this into libvirt repository. Thanks, Yogesh On Thu, Sep 5, 2013 at 5:22 PM, yogesh tillu <tillu.yogesh@gmail.com> wrote:
Hi All, Could you please review below patch, I have successfully tested patch on ARM Versatile Express V2P Board.
From: Yogesh Tillu <tillu.yogesh@gmail.com> Date: Thu, 5 Sep 2013 17:07:55 +0530 Subject: [PATCH] [ PATCH ] Added Support for ARMv7 Big Endian
Signed-off-by: Yogesh Tillu <tillu.yogesh@gmail.com> --- src/util/virarch.c | 1 + src/util/virarch.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/src/util/virarch.c b/src/util/virarch.c index 81558e5..b4e06da 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -37,6 +37,7 @@ static const struct virArchData { { "alpha", 64, VIR_ARCH_BIG_ENDIAN }, { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, + { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, { "i686", 32, VIR_ARCH_LITTLE_ENDIAN },
diff --git a/src/util/virarch.h b/src/util/virarch.h index 0d8ae25..dd25679 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@ -29,6 +29,7 @@ typedef enum { VIR_ARCH_ALPHA, /* Alpha 64 BE http://en.wikipedia.org/wiki/DEC_Alpha */ VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ + VIR_ARCH_ARMV7B, /* ARMv7 32 BE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_CRIS, /* ETRAX 32 LE http://en.wikipedia.org/wiki/ETRAX_CRIS */ VIR_ARCH_I686, /* x86 32 LE http://en.wikipedia.org/wiki/X86 */
-- 1.8.1.2
Test Performed: # virsh nodeinfo CPU model: armv7b CPU(s): 1 CPU frequency: 48 MHz CPU socket(s): 1 Core(s) per socket: 5 Thread(s) per core: 1 NUMA cell(s): 1 Memory size: 1029784 KiB
Regards, Yogesh Tillu
-- -- Yogesh
On Thu, Sep 05, 2013 at 05:22:31PM +0530, yogesh tillu wrote:
Hi All, Could you please review below patch, I have successfully tested patch on ARM Versatile Express V2P Board.
From: Yogesh Tillu <tillu.yogesh@gmail.com> Date: Thu, 5 Sep 2013 17:07:55 +0530 Subject: [PATCH] [ PATCH ] Added Support for ARMv7 Big Endian
Signed-off-by: Yogesh Tillu <tillu.yogesh@gmail.com> --- src/util/virarch.c | 1 + src/util/virarch.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/src/util/virarch.c b/src/util/virarch.c index 81558e5..b4e06da 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -37,6 +37,7 @@ static const struct virArchData { { "alpha", 64, VIR_ARCH_BIG_ENDIAN }, { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, + { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, { "i686", 32, VIR_ARCH_LITTLE_ENDIAN },
diff --git a/src/util/virarch.h b/src/util/virarch.h index 0d8ae25..dd25679 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@ -29,6 +29,7 @@ typedef enum { VIR_ARCH_ALPHA, /* Alpha 64 BE http://en.wikipedia.org/wiki/DEC_Alpha */ VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ + VIR_ARCH_ARMV7B, /* ARMv7 32 BE
Your mail client has mangled the patch by wrapping lines. Also sending of HTML email to development lists is frowned upon. Just this once, I've manually fixed the problems & applied your patch. For future either fix your mail client not to mangle patches, or use the git send-email program for patch submission. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
Sorry for inconvenience. I will send patch with git send-email next time. Thanks, Yogesh On Mon, Sep 9, 2013 at 3:11 PM, Daniel P. Berrange <berrange@redhat.com>wrote:
On Thu, Sep 05, 2013 at 05:22:31PM +0530, yogesh tillu wrote:
Hi All, Could you please review below patch, I have successfully tested patch on ARM Versatile Express V2P Board.
From: Yogesh Tillu <tillu.yogesh@gmail.com> Date: Thu, 5 Sep 2013 17:07:55 +0530 Subject: [PATCH] [ PATCH ] Added Support for ARMv7 Big Endian
Signed-off-by: Yogesh Tillu <tillu.yogesh@gmail.com> --- src/util/virarch.c | 1 + src/util/virarch.h | 1 + 2 files changed, 2 insertions(+)
diff --git a/src/util/virarch.c b/src/util/virarch.c index 81558e5..b4e06da 100644 --- a/src/util/virarch.c +++ b/src/util/virarch.c @@ -37,6 +37,7 @@ static const struct virArchData { { "alpha", 64, VIR_ARCH_BIG_ENDIAN }, { "armv6l", 32, VIR_ARCH_LITTLE_ENDIAN }, { "armv7l", 32, VIR_ARCH_LITTLE_ENDIAN }, + { "armv7b", 32, VIR_ARCH_BIG_ENDIAN }, { "cris", 32, VIR_ARCH_LITTLE_ENDIAN }, { "i686", 32, VIR_ARCH_LITTLE_ENDIAN },
diff --git a/src/util/virarch.h b/src/util/virarch.h index 0d8ae25..dd25679 100644 --- a/src/util/virarch.h +++ b/src/util/virarch.h @@ -29,6 +29,7 @@ typedef enum { VIR_ARCH_ALPHA, /* Alpha 64 BE http://en.wikipedia.org/wiki/DEC_Alpha */ VIR_ARCH_ARMV6L, /* ARMv6 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ VIR_ARCH_ARMV7L, /* ARMv7 32 LE http://en.wikipedia.org/wiki/ARM_architecture */ + VIR_ARCH_ARMV7B, /* ARMv7 32 BE
Your mail client has mangled the patch by wrapping lines. Also sending of HTML email to development lists is frowned upon.
Just this once, I've manually fixed the problems & applied your patch.
For future either fix your mail client not to mangle patches, or use the git send-email program for patch submission.
Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/:| |: http://libvirt.org -o- http://virt-manager.org:| |: http://autobuild.org -o- http://search.cpan.org/~danberr/:| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc:|
-- -- Yogesh
participants (2)
-
Daniel P. Berrange -
yogesh tillu