[libvirt] [PATCH 0/2] Fix copy-pasta errors in config loading for aux daemons
Apparently the option is not configured very often since nobody figured it out until now. Peter Krempa (2): lock: Fix loading of config file for the lock daemon log: Fix loading of conf file for log daemon src/locking/lock_daemon_config.c | 2 +- src/logging/log_daemon_config.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) -- 2.11.0
'log_outputs' would be read into the variable for log_filters --- src/locking/lock_daemon_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/locking/lock_daemon_config.c b/src/locking/lock_daemon_config.c index 9362b2b74..20824b870 100644 --- a/src/locking/lock_daemon_config.c +++ b/src/locking/lock_daemon_config.c @@ -96,7 +96,7 @@ virLockDaemonConfigLoadOptions(virLockDaemonConfigPtr data, return -1; if (virConfGetValueString(conf, "log_filters", &data->log_filters) < 0) return -1; - if (virConfGetValueString(conf, "log_outputs", &data->log_filters) < 0) + if (virConfGetValueString(conf, "log_outputs", &data->log_outputs) < 0) return -1; if (virConfGetValueUInt(conf, "max_clients", &data->max_clients) < 0) return -1; -- 2.11.0
'log_outputs' would be read into the variable for log_filters --- src/logging/log_daemon_config.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/logging/log_daemon_config.c b/src/logging/log_daemon_config.c index 10b42e912..cf58e6230 100644 --- a/src/logging/log_daemon_config.c +++ b/src/logging/log_daemon_config.c @@ -99,7 +99,7 @@ virLogDaemonConfigLoadOptions(virLogDaemonConfigPtr data, return -1; if (virConfGetValueString(conf, "log_filters", &data->log_filters) < 0) return -1; - if (virConfGetValueString(conf, "log_outputs", &data->log_filters) < 0) + if (virConfGetValueString(conf, "log_outputs", &data->log_outputs) < 0) return -1; if (virConfGetValueUInt(conf, "max_clients", &data->max_clients) < 0) return -1; -- 2.11.0
On Tue, Dec 13, 2016 at 18:37:21 +0100, Peter Krempa wrote:
Apparently the option is not configured very often since nobody figured it out until now.
Peter Krempa (2): lock: Fix loading of config file for the lock daemon log: Fix loading of conf file for log daemon
src/locking/lock_daemon_config.c | 2 +- src/logging/log_daemon_config.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)
ACK pasta series. Jirka
participants (2)
-
Jiri Denemark -
Peter Krempa