[libvirt] [PATCH] conf: Fix virNetworkAssignDef's comment.
--- src/conf/network_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 6968e25..c877a6d 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -333,7 +333,7 @@ virNetworkObjAssignDef(virNetworkObjPtr network, * def. For an existing network, use "live" and current state of the * network to determine which to replace. * - * Returns -1 on failure, 0 on success. + * Returns NULL on error, virNetworkObjPtr on success. */ virNetworkObjPtr virNetworkAssignDef(virNetworkObjListPtr nets, -- 1.7.1
On 24/09/13 10:05, lawrancejing wrote:
--- src/conf/network_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 6968e25..c877a6d 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -333,7 +333,7 @@ virNetworkObjAssignDef(virNetworkObjPtr network, * def. For an existing network, use "live" and current state of the * network to determine which to replace. * - * Returns -1 on failure, 0 on success. + * Returns NULL on error, virNetworkObjPtr on success.
NACK, the obvious thing is function returns an integer. Osier
I changed virNetworkAssignDef's comment,however what the patch show is "-333,7 +333,7 @@ virNetworkObjAssignDef". Please give me a hint, thank you. 2013/9/24 Osier Yang <jyang@redhat.com>
On 24/09/13 10:05, lawrancejing wrote:
--- src/conf/network_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/src/conf/network_conf.c b/src/conf/network_conf.c index 6968e25..c877a6d 100644 --- a/src/conf/network_conf.c +++ b/src/conf/network_conf.c @@ -333,7 +333,7 @@ virNetworkObjAssignDef(**virNetworkObjPtr network, * def. For an existing network, use "live" and current state of the * network to determine which to replace. * - * Returns -1 on failure, 0 on success. + * Returns NULL on error, virNetworkObjPtr on success.
NACK, the obvious thing is function returns an integer.
Osier
On 24/09/13 15:57, lawrance jing wrote:
I changed virNetworkAssignDef's comment,however what the patch show is "-333,7 +333,7 @@ virNetworkObjAssignDef". Please give me a hint, thank you.
Oh, it was confused, ACK and pushed. By the way, it's nicer if your reply mails with text format. Osier
On 09/23/2013 08:05 PM, lawrancejing wrote:
--- src/conf/network_conf.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)
Unfortunately, Osier committed your patch without checking how your attribution would appear. 'git shortlog' now lists your username 'lawrancejing' rather than a legal name; other mail from you uses 'lawrance jing'. Which form would you prefer, so that we can add a .mailmap entry? It is permissible to use UTF-8; it is also okay if you want to use your name in native characters followed by a parenthesized rendering of your name in Latin characters. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
participants (4)
-
Eric Blake -
lawrance jing -
lawrancejing
-
Osier Yang