[Libvir] PATCH: Fix accident close of monitor FD & leak of logfile FD to child
After the QEMU monitor filehandle has been successfully initialized, we then promptly close it ! It seems a 'return' statement accidentally got removed somewhere during previously refactoring. Second, the QEMU logfile does not have the close-on-exec flag set so the logfile is leaked to child processes. qemu_driver.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
On Thu, Jul 19, 2007 at 01:52:00AM +0100, Daniel P. Berrange wrote:
After the QEMU monitor filehandle has been successfully initialized, we then promptly close it ! It seems a 'return' statement accidentally got removed somewhere during previously refactoring.
Second, the QEMU logfile does not have the close-on-exec flag set so the logfile is leaked to child processes. +1
Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
participants (2)
-
Daniel P. Berrange -
Daniel Veillard