[libvirt] [jenkins-ci PATCH 0/6] Some coverage fixes and improvements
We were installing some unnecessary packages and not building projects on as many platforms as possible. Let's fix that :) Andrea Bolognani (6): guests: Don't prepare Ubuntu 16.04 for virt-manager guests: Don't prepare CentOS 7 for libvirt-sandbox guests: Prepare Debian 8 for libvirt-sandbox projects: Build libvirt-sandbox on Debian 8 guests: Prepare Debian 8 for libvirt-dbus projects: Build libvirt-dbus on Debian 8 guests/host_vars/libvirt-centos-7/main.yml | 1 - guests/host_vars/libvirt-debian-8/main.yml | 2 ++ guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - projects/libvirt-dbus.yaml | 1 + projects/libvirt-sandbox.yaml | 1 + 5 files changed, 4 insertions(+), 2 deletions(-) -- 2.17.1
virt-manager can't be built successfully on the platform, so we shouldn't install the corresponding build dependencies. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars/libvirt-ubuntu-16/main.yml index 92296b4..4d9914a 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -12,7 +12,6 @@ projects: - libvirt-tck - osinfo-db - osinfo-db-tools - - virt-manager - virt-viewer package_format: deb -- 2.17.1
On Thu, Aug 09, 2018 at 03:16:38PM +0200, Andrea Bolognani wrote:
virt-manager can't be built successfully on the platform, so we shouldn't install the corresponding build dependencies.
For the sake of history, it would be nice to be a bit more detailed as why it can't be built on a specific distro. With that added: Reviewed-by: Erik Skultety <eskultet@redhat.com>
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-ubuntu-16/main.yml | 1 - 1 file changed, 1 deletion(-)
diff --git a/guests/host_vars/libvirt-ubuntu-16/main.yml b/guests/host_vars/libvirt-ubuntu-16/main.yml index 92296b4..4d9914a 100644 --- a/guests/host_vars/libvirt-ubuntu-16/main.yml +++ b/guests/host_vars/libvirt-ubuntu-16/main.yml @@ -12,7 +12,6 @@ projects: - libvirt-tck - osinfo-db - osinfo-db-tools - - virt-manager - virt-viewer
package_format: deb -- 2.17.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On Fri, 2018-08-10 at 10:31 +0200, Erik Skultety wrote:
On Thu, Aug 09, 2018 at 03:16:38PM +0200, Andrea Bolognani wrote:
virt-manager can't be built successfully on the platform, so we shouldn't install the corresponding build dependencies.
For the sake of history, it would be nice to be a bit more detailed as why it can't be built on a specific distro.
As mentioned on IRC, whenever we have to introduce an exception to our general "build every project on every platform" mantra, it's certainly useful to document the rationale. We have a few examples of that happening already, but there's plenty of room for improvement as well. I think that information belongs to the code rather than to the commit messages, though. So would you be okay if I pushed these patches as-is and posted a follow-up series that adds information about all exceptions as comments in the relevant files? -- Andrea Bolognani / Red Hat / Virtualization
On Fri, Aug 10, 2018 at 12:24:46PM +0200, Andrea Bolognani wrote:
On Fri, 2018-08-10 at 10:31 +0200, Erik Skultety wrote:
On Thu, Aug 09, 2018 at 03:16:38PM +0200, Andrea Bolognani wrote:
virt-manager can't be built successfully on the platform, so we shouldn't install the corresponding build dependencies.
For the sake of history, it would be nice to be a bit more detailed as why it can't be built on a specific distro.
As mentioned on IRC, whenever we have to introduce an exception to our general "build every project on every platform" mantra, it's certainly useful to document the rationale. We have a few examples of that happening already, but there's plenty of room for improvement as well.
I think that information belongs to the code rather than to the commit messages, though. So would you be okay if I pushed these patches as-is and posted a follow-up series that adds information about all exceptions as comments in the relevant files?
To be honest, I kinda was counting on you sending a follow-up regardless of my comment, because as you said, it's always better to document this properly in relevant files :). At the same time though, I needed to experience e.g. the failure with missing xz-static on CentOS 7 myself to actually figure out, what it is that makes the build fail. So, even though I'm not insisting on you changing the commit messages, I think that dropping a note about specific missing requirements for a successful build as a justification for those 2 patches in play won't add much work. Anyhow, my RB still stands. Erik
On Fri, 2018-08-10 at 13:16 +0200, Erik Skultety wrote:
To be honest, I kinda was counting on you sending a follow-up regardless of my comment, because as you said, it's always better to document this properly in relevant files :). At the same time though, I needed to experience e.g. the failure with missing xz-static on CentOS 7 myself to actually figure out, what it is that makes the build fail. So, even though I'm not insisting on you changing the commit messages, I think that dropping a note about specific missing requirements for a successful build as a justification for those 2 patches in play won't add much work. Anyhow, my RB still stands.
Note that the ultimate source of truth for which projects can be successfully built on which platform is the Jenkins configuration, not the guest configuration, and I'm not touching the former at all because we were (correctly) already excluding platforms where we knew the build would fail; this commit and the following one merely clean up an oversight which caused a few unnecessary packages to be installed in guests. -- Andrea Bolognani / Red Hat / Virtualization
libvirt-sandbox can't be built successfully on the platform, so we shouldn't install the corresponding build dependencies. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index 4c80e22..e220849 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -9,7 +9,6 @@ projects: - libvirt-go-xml - libvirt-perl - libvirt-python - - libvirt-sandbox - osinfo-db - osinfo-db-tools - virt-viewer -- 2.17.1
On Thu, Aug 09, 2018 at 03:16:39PM +0200, Andrea Bolognani wrote:
libvirt-sandbox can't be built successfully on the platform, so we shouldn't install the corresponding build dependencies.
Same comment as in patch 1. With that addressed: Reviewed-by: Erik Skultety <eskultet@redhat.com>
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-centos-7/main.yml | 1 - 1 file changed, 1 deletion(-)
diff --git a/guests/host_vars/libvirt-centos-7/main.yml b/guests/host_vars/libvirt-centos-7/main.yml index 4c80e22..e220849 100644 --- a/guests/host_vars/libvirt-centos-7/main.yml +++ b/guests/host_vars/libvirt-centos-7/main.yml @@ -9,7 +9,6 @@ projects: - libvirt-go-xml - libvirt-perl - libvirt-python - - libvirt-sandbox - osinfo-db - osinfo-db-tools - virt-viewer -- 2.17.1
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
libvirt-sandbox can be built successfully on the platform, so we should install the corresponding build dependencies. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-debian-8/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/libvirt-debian-8/main.yml index a6875a4..fb37205 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -7,6 +7,7 @@ projects: - libvirt-go-xml - libvirt-perl - libvirt-python + - libvirt-sandbox - libvirt-tck - osinfo-db - osinfo-db-tools -- 2.17.1
Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- projects/libvirt-sandbox.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/projects/libvirt-sandbox.yaml b/projects/libvirt-sandbox.yaml index 518080a..da9bf77 100644 --- a/projects/libvirt-sandbox.yaml +++ b/projects/libvirt-sandbox.yaml @@ -2,6 +2,7 @@ - project: name: libvirt-sandbox machines: + - libvirt-debian-8 - libvirt-debian-9 - libvirt-fedora-27 - libvirt-fedora-28 -- 2.17.1
libvirt-dbus can be built successfully on the platform, so we should install the corresponding build dependencies. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- guests/host_vars/libvirt-debian-8/main.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/guests/host_vars/libvirt-debian-8/main.yml b/guests/host_vars/libvirt-debian-8/main.yml index fb37205..aca0663 100644 --- a/guests/host_vars/libvirt-debian-8/main.yml +++ b/guests/host_vars/libvirt-debian-8/main.yml @@ -2,6 +2,7 @@ projects: - libosinfo - libvirt + - libvirt-dbus - libvirt-glib - libvirt-go - libvirt-go-xml -- 2.17.1
As with CentOS 7, we can't run 'make check' on the platform because we don't have a recent enough Python interpreter, but the daemon itself will build and run just fine. Signed-off-by: Andrea Bolognani <abologna@redhat.com> --- projects/libvirt-dbus.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/projects/libvirt-dbus.yaml b/projects/libvirt-dbus.yaml index c12a769..3212465 100644 --- a/projects/libvirt-dbus.yaml +++ b/projects/libvirt-dbus.yaml @@ -9,6 +9,7 @@ parent_jobs: 'libvirt-glib-master-build' machines: - libvirt-centos-7 + - libvirt-debian-8 - libvirt-debian-9 - libvirt-fedora-27 - libvirt-fedora-28 -- 2.17.1
On Thu, Aug 09, 2018 at 03:16:43PM +0200, Andrea Bolognani wrote:
As with CentOS 7, we can't run 'make check' on the platform because we don't have a recent enough Python interpreter, but the daemon itself will build and run just fine.
Signed-off-by: Andrea Bolognani <abologna@redhat.com> ---
collectively to patches [4-6]: Reviewed-by: Erik Skultety <eskultet@redhat.com>
participants (2)
-
Andrea Bolognani -
Erik Skultety