[libvirt] virsh help keywords vs. command prefixes
From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match
Hi all. the virsh command prefixes where they exist. For example "help nwfilter" would tell me about nwfilter- commands. Some keywords follow the prefix convention (nodedev, secret, snapshot, pool) but some do not (interface vs. iface-, filter vs nwfilter-, network vs. net-, volume vs. vol-). Minor observation and close to release but I thought I would send on feedback to see what people thought. Paul
libvir-list-bounces@redhat.com wrote on 01/03/2011 03:10:20 PM:
From: Paul Jenner <psj@familyjenner.co.uk> To: libvir-list@redhat.com Date: 01/03/2011 03:17 PM Subject: [libvirt] virsh help keywords vs. command prefixes Sent by: libvir-list-bounces@redhat.com
Hi all.
From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match the virsh command prefixes where they exist. For example "help nwfilter" would tell me about nwfilter- commands. Some keywords follow the prefix convention (nodedev, secret, snapshot, pool) but some do not (interface vs. iface-, filter vs nwfilter-, network vs. net-, volume vs. vol-).
Minor observation and close to release but I thought I would send on feedback to see what people thought.
We could introduce the 'help nwfilter' etc. as alias to the existing one(s). Stefan
On 01/03/2011 02:46 PM, Stefan Berger wrote:
libvir-list-bounces@redhat.com wrote on 01/03/2011 03:10:20 PM:
From: Paul Jenner <psj@familyjenner.co.uk> To: libvir-list@redhat.com Date: 01/03/2011 03:17 PM Subject: [libvirt] virsh help keywords vs. command prefixes Sent by: libvir-list-bounces@redhat.com
Hi all.
From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match the virsh command prefixes where they exist. For example "help nwfilter" would tell me about nwfilter- commands. Some keywords follow the prefix convention (nodedev, secret, snapshot, pool) but some do not (interface vs. iface-, filter vs nwfilter-, network vs. net-, volume vs. vol-).
Minor observation and close to release but I thought I would send on feedback to see what people thought.
We could introduce the 'help nwfilter' etc. as alias to the existing one(s).
I've also got the (post-0.8.7) idea of teaching virsh how to do unambiguous prefix recognition; and it wouldn't be too hard to tweak it to recognize that if a prefix is ambiguous but all commands that share that prefix belong to a single category, then treat it as 'help category' instead. -- Eric Blake eblake@redhat.com +1-801-349-2682 Libvirt virtualization library http://libvirt.org
On 04/01/2011, at 7:10 AM, Paul Jenner wrote:
Hi all.
From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match the virsh command prefixes where they exist. For example "help nwfilter" would tell me about nwfilter- commands. Some keywords follow the prefix convention (nodedev, secret, snapshot, pool) but some do not (interface vs. iface-, filter vs nwfilter-, network vs. net-, volume vs. vol-).
Minor observation and close to release but I thought I would send on feedback to see what people thought.
Yeah, that's not a bad idea. Makes for easier mnemonics. :) Stefan's idea to implement as an alias for the existing ones is probably the easiest way to make it happen. Stefan any inclination to create the patch? Eric's suggestion sounds like it'd work too (and do so without conflict). Patches? :)
于 2011年01月04日 16:51, Justin Clift 写道:
On 04/01/2011, at 7:10 AM, Paul Jenner wrote:
Hi all.
From a quick play with virsh from the 0.8.7 pre-release, as an end user I wonder if it may be more intuitive for the new help keywords to match the virsh command prefixes where they exist. For example "help nwfilter" would tell me about nwfilter- commands. Some keywords follow the prefix convention (nodedev, secret, snapshot, pool) but some do not (interface vs. iface-, filter vs nwfilter-, network vs. net-, volume vs. vol-).
Minor observation and close to release but I thought I would send on feedback to see what people thought.
Yeah, that's not a bad idea. Makes for easier mnemonics. :)
Stefan's idea to implement as an alias for the existing ones is probably the easiest way to make it happen. Stefan any inclination to create the patch?
Eric's suggestion sounds like it'd work too (and do so without conflict). Patches? :)
recall you guys talked it once before.
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
participants (5)
-
Eric Blake -
Justin Clift -
Osier Yang -
Paul Jenner -
Stefan Berger