[Libvir] [PATCH] Add support for scheduler functions in remote
This is a rather tedious patch, but I've tested it against the Xen driver and it works for getting and setting the various parameters and scheduler type. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
Richard W.M. Jones wrote:
This is a rather tedious patch, but I've tested it against the Xen driver and it works for getting and setting the various parameters and scheduler type.
I should add that to make the patch easier to review, I didn't include the changes to the generated files, even though those files are stored in CVS. So after applying this patch you need to do: rm qemud/remote_dispatch_localvars.h \ qemud/remote_dispatch_proc_switch.h \ qemud/remote_dispatch_prototypes.h \ qemud/remote_protocol.c \ qemud/remote_protocol.h make -C qemud remote_protocol.c Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
On Fri, Jun 22, 2007 at 12:33:59PM +0100, Richard W.M. Jones wrote:
This is a rather tedious patch, but I've tested it against the Xen driver and it works for getting and setting the various parameters and scheduler type.
Looks good to me, except for two calls to strdup which don't report errors on ENOMEM.
+ args.params.params_val[i].field = strdup (params[i].field);
Regards, Dan. -- |=- Red Hat, Engineering, Emerging Technologies, Boston. +1 978 392 2496 -=| |=- Perl modules: http://search.cpan.org/~danberr/ -=| |=- Projects: http://freshmeat.net/~danielpb/ -=| |=- GnuPG: 7D3B9505 F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 -=|
Daniel P. Berrange wrote:
On Fri, Jun 22, 2007 at 12:33:59PM +0100, Richard W.M. Jones wrote:
This is a rather tedious patch, but I've tested it against the Xen driver and it works for getting and setting the various parameters and scheduler type.
Looks good to me, except for two calls to strdup which don't report errors on ENOMEM.
+ args.params.params_val[i].field = strdup (params[i].field);
Alright, I'll fix those two and apply. Rich. -- Emerging Technologies, Red Hat - http://et.redhat.com/~rjones/ Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SL4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 03798903
participants (2)
-
Daniel P. Berrange -
Richard W.M. Jones