[libvirt] Question about compilation on MinGW(StorageAPI)
Hi, Rich and Dan I have a question about libvirt on MinGW. As you know, MinGW supports remote management only. In this situation, Storage API(dir) should be off. Can I configure it? or other way exists? One more question on MinGW with Ruby, Does someone already test the Ruby bindings on MinGW? I am stacked this on configuration of "rake" on MinGW. Thanks Atsushi SAKAI
On Fri, Jun 06, 2008 at 07:34:32PM +0900, Atsushi SAKAI wrote:
Hi, Rich and Dan
I have a question about libvirt on MinGW. As you know, MinGW supports remote management only. In this situation, Storage API(dir) should be off. Can I configure it? or other way exists?
The storage APIs will only be built if the daemon is enabled. So you can turn it off with the configure flag: --without-libvirtd There are also flags to turn on/off individual storage backend drivers, but they should also automatically turn themselves off if they detect missing functionality. Regards, Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Hi, Dan Thank you, I remenber the Mail from Rich. http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html virsh seems working again. Current problem on MinGW are 2points(These are avoidable on manually). 1) siginfo_t should comment out.(it effects driver.h/internal.h/libvirt.c on src directory) 2) Cannot compile "tests" directory Thanks Atsushi SAKAI "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Fri, Jun 06, 2008 at 07:34:32PM +0900, Atsushi SAKAI wrote:
Hi, Rich and Dan
I have a question about libvirt on MinGW. As you know, MinGW supports remote management only. In this situation, Storage API(dir) should be off. Can I configure it? or other way exists?
The storage APIs will only be built if the daemon is enabled. So you can turn it off with the configure flag:
--without-libvirtd
There are also flags to turn on/off individual storage backend drivers, but they should also automatically turn themselves off if they detect missing functionality.
Regards, Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Fri, Jun 06, 2008 at 10:03:41PM +0900, Atsushi SAKAI wrote:
Hi, Dan
Thank you, I remenber the Mail from Rich. http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html virsh seems working again.
Current problem on MinGW are 2points(These are avoidable on manually).
1) siginfo_t should comment out.(it effects driver.h/internal.h/libvirt.c on src directory)
Hmm, all the APIs with virState in their name should be disabled by a #ifdef WITH_LIBVIRTD, since they only make sense in the context of the daemon.
2) Cannot compile "tests" directory
Can you post the compile errors for this - it ought to be easy enough to fix Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Hi, Dan If remove uncompiled code on MinGW, the patch seems like this. 0)siginfo_t does not have. 1)MinGW does not have waitpid, fork etc. 2)add testutilsqemu.c to check WITH_QEMU I need to investigate more? (Please wait a week, if need to investigate this.) src/driver.h | 4 ++++ src/internal.h | 4 ++++ src/libvirt.c | 3 ++- tests/testutils.c | 9 ++++++++- tests/testutilsqemu.c | 2 ++ 5 files changed, 20 insertions(+), 2 deletions(-) Thanks Atsushi SAKAI "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Fri, Jun 06, 2008 at 10:03:41PM +0900, Atsushi SAKAI wrote:
Hi, Dan
Thank you, I remenber the Mail from Rich. http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html virsh seems working again.
Current problem on MinGW are 2points(These are avoidable on manually).
1) siginfo_t should comment out.(it effects driver.h/internal.h/libvirt.c on src directory)
Hmm, all the APIs with virState in their name should be disabled by a #ifdef WITH_LIBVIRTD, since they only make sense in the context of the daemon.
2) Cannot compile "tests" directory
Can you post the compile errors for this - it ought to be easy enough to fix
Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
Hi, Dan
If remove uncompiled code on MinGW, the patch seems like this.
0)siginfo_t does not have. 1)MinGW does not have waitpid, fork etc. 2)add testutilsqemu.c to check WITH_QEMU
I need to investigate more? (Please wait a week, if need to investigate this.)
src/driver.h | 4 ++++ src/internal.h | 4 ++++ src/libvirt.c | 3 ++- tests/testutils.c | 9 ++++++++- tests/testutilsqemu.c | 2 ++ 5 files changed, 20 insertions(+), 2 deletions(-)
The patch looks reasonnable to me, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
I need to investigate more? (Please wait a week, if need to investigate this.)
src/driver.h | 4 ++++ src/internal.h | 4 ++++ src/libvirt.c | 3 ++- tests/testutils.c | 9 ++++++++- tests/testutilsqemu.c | 2 ++ 5 files changed, 20 insertions(+), 2 deletions(-)
This patch looks good to me. You want me to apply it, or wait a bit longer? Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones virt-df lists disk usage of guests without needing to install any software inside the virtual machine. Supports Linux and Windows. http://et.redhat.com/~rjones/virt-df/
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
Hi, Dan
If remove uncompiled code on MinGW, the patch seems like this.
0)siginfo_t does not have. 1)MinGW does not have waitpid, fork etc. 2)add testutilsqemu.c to check WITH_QEMU
I need to investigate more? (Please wait a week, if need to investigate this.)
src/driver.h | 4 ++++ src/internal.h | 4 ++++ src/libvirt.c | 3 ++-
I don't like this change - we should disable all the virStateXXX funtions, based on #ifdef WITH_LIBVIRTD, since they're only used when in daemon mode, and thus avoid a #ifndef WIN32
tests/testutils.c | 9 ++++++++-
This change will cause the virshtest test file to fail every time on win32. The better way to approach this is to wrap the *entire* of virtTestCaptureProgramOutput in #ifndef WIN32, and then in the virshtest.c file disable the entire test suite, #ifndef WIN32 ....normal test code... #else int main (void) { return (77); /* means 'test skipped' for automake */ } #endif See qemuxml2argvtest.c for an example of this.
tests/testutilsqemu.c | 2 ++
This is fine. Regards, Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Hi, Dan How about this? With this patch, make, make check, make syntax-check on libvirt is running (some test are skipped.). At this moment "make install" is failed on virsh install like this. The output is like thisat src directory # ../libtool --mode=install /usr/bin/install -c 'virsh.exe' '/usr/local/bin/virsh.exe' ../libtool: ./virsh.: No such file or directory I am investigating this issue at this moment. qemud/Makefile.am | 2 ++ src/driver.h | 4 ++++ src/internal.h | 2 ++ src/libvirt.c | 4 ++++ src/qemu_driver.c | 8 ++++++++ src/remote_internal.c | 6 ++++++ tests/Makefile.am | 9 ++++++--- tests/testutils.c | 5 ++++- tests/testutilsqemu.c | 3 ++- tests/virshtest.c | 7 ++++++- 10 files changed, 44 insertions(+), 6 deletions(-) Thanks Atsushi SAKAI "Daniel P. Berrange" <berrange@redhat.com> wrote:
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
Hi, Dan
If remove uncompiled code on MinGW, the patch seems like this.
0)siginfo_t does not have. 1)MinGW does not have waitpid, fork etc. 2)add testutilsqemu.c to check WITH_QEMU
I need to investigate more? (Please wait a week, if need to investigate this.)
src/driver.h | 4 ++++ src/internal.h | 4 ++++ src/libvirt.c | 3 ++-
I don't like this change - we should disable all the virStateXXX funtions, based on #ifdef WITH_LIBVIRTD, since they're only used when in daemon mode, and thus avoid a #ifndef WIN32
tests/testutils.c | 9 ++++++++-
This change will cause the virshtest test file to fail every time on win32.
The better way to approach this is to wrap the *entire* of
virtTestCaptureProgramOutput
in #ifndef WIN32, and then in the virshtest.c file disable the entire test suite,
#ifndef WIN32 ....normal test code... #else int main (void) { return (77); /* means 'test skipped' for automake */ } #endif
See qemuxml2argvtest.c for an example of this.
tests/testutilsqemu.c | 2 ++
This is fine.
Regards, Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Hi, Dan Additional Info I change libtool version from 1.5.18 to 1.5.26. Then make install process is passed. I will post whole compilation process on MinGW after I completed. At this moment, current patch seems to be enough for MinGW. Thanks Atsushi SAKAI Atsushi SAKAI <sakaia@jp.fujitsu.com> wrote:
Hi, Dan
How about this?
With this patch, make, make check, make syntax-check on libvirt is running (some test are skipped.). At this moment "make install" is failed on virsh install like this. The output is like thisat src directory
# ../libtool --mode=install /usr/bin/install -c 'virsh.exe' '/usr/local/bin/virsh.exe' ../libtool: ./virsh.: No such file or directory
I am investigating this issue at this moment.
qemud/Makefile.am | 2 ++ src/driver.h | 4 ++++ src/internal.h | 2 ++ src/libvirt.c | 4 ++++ src/qemu_driver.c | 8 ++++++++ src/remote_internal.c | 6 ++++++ tests/Makefile.am | 9 ++++++--- tests/testutils.c | 5 ++++- tests/testutilsqemu.c | 3 ++- tests/virshtest.c | 7 ++++++- 10 files changed, 44 insertions(+), 6 deletions(-)
Thanks Atsushi SAKAI
"Daniel P. Berrange" <berrange@redhat.com> wrote:
On Mon, Jun 09, 2008 at 12:05:09PM +0900, Atsushi SAKAI wrote:
Hi, Dan
If remove uncompiled code on MinGW, the patch seems like this.
0)siginfo_t does not have. 1)MinGW does not have waitpid, fork etc. 2)add testutilsqemu.c to check WITH_QEMU
I need to investigate more? (Please wait a week, if need to investigate this.)
src/driver.h | 4 ++++ src/internal.h | 4 ++++ src/libvirt.c | 3 ++-
I don't like this change - we should disable all the virStateXXX funtions, based on #ifdef WITH_LIBVIRTD, since they're only used when in daemon mode, and thus avoid a #ifndef WIN32
tests/testutils.c | 9 ++++++++-
This change will cause the virshtest test file to fail every time on win32.
The better way to approach this is to wrap the *entire* of
virtTestCaptureProgramOutput
in #ifndef WIN32, and then in the virshtest.c file disable the entire test suite,
#ifndef WIN32 ....normal test code... #else int main (void) { return (77); /* means 'test skipped' for automake */ } #endif
See qemuxml2argvtest.c for an example of this.
tests/testutilsqemu.c | 2 ++
This is fine.
Regards, Daniel. -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Wed, Jun 18, 2008 at 06:32:37PM +0900, Atsushi SAKAI wrote:
Hi, Dan
Additional Info I change libtool version from 1.5.18 to 1.5.26. Then make install process is passed.
I will post whole compilation process on MinGW after I completed.
At this moment, current patch seems to be enough for MinGW.
Dan, you had issues with the initial patch, is the new version okay from your viewpoint ? thanks, Daniel -- Red Hat Virtualization group http://redhat.com/virtualization/ Daniel Veillard | virtualization library http://libvirt.org/ veillard@redhat.com | libxml GNOME XML XSLT toolkit http://xmlsoft.org/ http://veillard.com/ | Rpmfind RPM search engine http://rpmfind.net/
On Wed, Jun 18, 2008 at 11:58:17AM +0900, Atsushi SAKAI wrote:
Hi, Dan
How about this?
With this patch, make, make check, make syntax-check on libvirt is running (some test are skipped.). At this moment "make install" is failed on virsh install like this. The output is like thisat src directory
# ../libtool --mode=install /usr/bin/install -c 'virsh.exe' '/usr/local/bin/virsh.exe' ../libtool: ./virsh.: No such file or directory
I am investigating this issue at this moment.
qemud/Makefile.am | 2 ++ src/driver.h | 4 ++++ src/internal.h | 2 ++ src/libvirt.c | 4 ++++ src/qemu_driver.c | 8 ++++++++ src/remote_internal.c | 6 ++++++ tests/Makefile.am | 9 ++++++--- tests/testutils.c | 5 ++++- tests/testutilsqemu.c | 3 ++- tests/virshtest.c | 7 ++++++- 10 files changed, 44 insertions(+), 6 deletions(-)
This patch looks good to me. Regards, Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Fri, Jun 06, 2008 at 10:03:41PM +0900, Atsushi SAKAI wrote:
Thank you, I remenber the Mail from Rich. http://www.redhat.com/archives/libvir-list/2008-January/msg00017.html virsh seems working again.
Current problem on MinGW are 2points(These are avoidable on manually).
1) siginfo_t should comment out.(it effects driver.h/internal.h/libvirt.c on src directory) 2) Cannot compile "tests" directory
Expected. I only got the client library and virsh working under MinGW. In particular there is no daemon and no drivers except for remote and test. The tests in the tests directory did not get run either -- IIRC they failed because they make lots of Unix assumptions about the world. Patches to resolve this problems are welcome! Rich. -- Richard Jones, Emerging Technologies, Red Hat http://et.redhat.com/~rjones Read my OCaml programming blog: http://camltastic.blogspot.com/ Fedora now supports 59 OCaml packages (the OPEN alternative to F#) http://cocan.org/getting_started_with_ocaml_on_red_hat_and_fedora
participants (4)
-
Atsushi SAKAI -
Daniel P. Berrange -
Daniel Veillard -
Richard W.M. Jones