[libvirt] [PATCH] Don't depend on syslog.service
Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it. References: http://www.freedesktop.org/wiki/Software/systemd/syslog/ http://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-targe... --- src/locking/virtlockd.service.in | 1 - tools/libvirt-guests.service.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in index a9f9f93..0ef9923 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -1,7 +1,6 @@ [Unit] Description=Virtual machine lock manager Requires=virtlockd.socket -After=syslog.target [Service] EnvironmentFile=-/etc/sysconfig/virtlockd diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..5aeb14c 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=network.target [Service] EnvironmentFile=-/etc/sysconfig/libvirt-guests -- 1.8.4.2
On Mon, Nov 11, 2013 at 10:02:18AM +0100, Guido Günther wrote:
Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it.
References:
http://www.freedesktop.org/wiki/Software/systemd/syslog/ http://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-targe...
Ping? Not very exciting, I know. -- Guido
--- src/locking/virtlockd.service.in | 1 - tools/libvirt-guests.service.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in index a9f9f93..0ef9923 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -1,7 +1,6 @@ [Unit] Description=Virtual machine lock manager Requires=virtlockd.socket -After=syslog.target
[Service] EnvironmentFile=-/etc/sysconfig/virtlockd diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..5aeb14c 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=network.target
[Service] EnvironmentFile=-/etc/sysconfig/libvirt-guests -- 1.8.4.2
-- libvir-list mailing list libvir-list@redhat.com https://www.redhat.com/mailman/listinfo/libvir-list
On 11/11/2013 04:02 AM, Guido Günther wrote:
Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it.
References:
http://www.freedesktop.org/wiki/Software/systemd/syslog/ http://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-targe... --- src/locking/virtlockd.service.in | 1 - tools/libvirt-guests.service.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in index a9f9f93..0ef9923 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -1,7 +1,6 @@ [Unit] Description=Virtual machine lock manager Requires=virtlockd.socket -After=syslog.target
[Service] EnvironmentFile=-/etc/sysconfig/virtlockd diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..5aeb14c 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=network.target
[Service] EnvironmentFile=-/etc/sysconfig/libvirt-guests
ACK - Cole
On Tue, Nov 19, 2013 at 03:14:44PM -0500, Cole Robinson wrote:
On 11/11/2013 04:02 AM, Guido Günther wrote:
Syslog is socket activated since at least systemd v35 so we can drop this dependency. Debian's linitian otherwise complains about it.
References:
http://www.freedesktop.org/wiki/Software/systemd/syslog/ http://lintian.debian.org/tags/systemd-service-file-refers-to-obsolete-targe... --- src/locking/virtlockd.service.in | 1 - tools/libvirt-guests.service.in | 2 +- 2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/locking/virtlockd.service.in b/src/locking/virtlockd.service.in index a9f9f93..0ef9923 100644 --- a/src/locking/virtlockd.service.in +++ b/src/locking/virtlockd.service.in @@ -1,7 +1,6 @@ [Unit] Description=Virtual machine lock manager Requires=virtlockd.socket -After=syslog.target
[Service] EnvironmentFile=-/etc/sysconfig/virtlockd diff --git a/tools/libvirt-guests.service.in b/tools/libvirt-guests.service.in index d41bf2b..5aeb14c 100644 --- a/tools/libvirt-guests.service.in +++ b/tools/libvirt-guests.service.in @@ -1,6 +1,6 @@ [Unit] Description=Suspend Active Libvirt Guests -After=syslog.target network.target +After=network.target
[Service] EnvironmentFile=-/etc/sysconfig/libvirt-guests
ACK
Pushed. Thanks! -- Guido
participants (2)
-
Cole Robinson -
Guido Günther