[PATCH 0/2] util: hash: Aid in debugging of duplicate keys
See patch 1 for rationale. Peter Krempa (2): util: hash: Improve debugability of "Duplicate key" error message tests: hash: Test case for adding duplicate hash entry src/conf/domain_addr.c | 9 +++++++++ src/util/vircgroup.c | 8 ++++++++ src/util/virhash.c | 22 ++++++++++++++++++++-- src/util/virhash.h | 13 +++++++++++++ tests/virhashtest.c | 23 +++++++++++++++++++++++ 5 files changed, 73 insertions(+), 2 deletions(-) -- 2.24.1
If we get an user reporting this error message being shown it's pretty useless in terms of actually debugging it since we don't know which hash and which key are actually subject to the error. This patch adds a new hash table callback which formats the user-readable version of the hash key and reports it in the new message which will look like: "Duplicate hash table key 'blah'" That way we will at least have an anchor point where to start the search. There are two special implementations of keys which are numeric so we add specific printer functions for them. Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- src/conf/domain_addr.c | 9 +++++++++ src/util/vircgroup.c | 8 ++++++++ src/util/virhash.c | 22 ++++++++++++++++++++-- src/util/virhash.h | 13 +++++++++++++ 4 files changed, 50 insertions(+), 2 deletions(-) diff --git a/src/conf/domain_addr.c b/src/conf/domain_addr.c index ef7ee80e6a..607ba56efd 100644 --- a/src/conf/domain_addr.c +++ b/src/conf/domain_addr.c @@ -1007,6 +1007,13 @@ virZPCIAddrKeyCopy(const void *name) } +static char * +virZPCIAddrKeyPrintHuman(const void *name) +{ + return g_strdup_printf("%u", *((unsigned int *)name)); +} + + static void virZPCIAddrKeyFree(void *name) { @@ -1041,6 +1048,7 @@ virDomainPCIAddressSetExtensionAlloc(virDomainPCIAddressSetPtr addrs, virZPCIAddrKeyCode, virZPCIAddrKeyEqual, virZPCIAddrKeyCopy, + virZPCIAddrKeyPrintHuman, virZPCIAddrKeyFree))) goto error; @@ -1048,6 +1056,7 @@ virDomainPCIAddressSetExtensionAlloc(virDomainPCIAddressSetPtr addrs, virZPCIAddrKeyCode, virZPCIAddrKeyEqual, virZPCIAddrKeyCopy, + virZPCIAddrKeyPrintHuman, virZPCIAddrKeyFree))) goto error; } diff --git a/src/util/vircgroup.c b/src/util/vircgroup.c index 87ed9f4565..dff2f6fd3a 100644 --- a/src/util/vircgroup.c +++ b/src/util/vircgroup.c @@ -2502,6 +2502,13 @@ virCgroupPidCopy(const void *name) } +static char * +virCgroupPidPrintHuman(const void *name) +{ + return g_strdup_printf("%ld", (const long)name); +} + + int virCgroupKillRecursiveInternal(virCgroupPtr group, int signum, @@ -2587,6 +2594,7 @@ virCgroupKillRecursive(virCgroupPtr group, int signum) virCgroupPidCode, virCgroupPidEqual, virCgroupPidCopy, + virCgroupPidPrintHuman, NULL); VIR_DEBUG("group=%p path=%s signum=%d", group, group->path, signum); diff --git a/src/util/virhash.c b/src/util/virhash.c index 313ca57a54..edf11e8b7a 100644 --- a/src/util/virhash.c +++ b/src/util/virhash.c @@ -59,6 +59,7 @@ struct _virHashTable { virHashKeyCode keyCode; virHashKeyEqual keyEqual; virHashKeyCopy keyCopy; + virHashKeyPrintHuman keyPrint; virHashKeyFree keyFree; }; @@ -98,6 +99,14 @@ static void *virHashStrCopy(const void *name) return ret; } + +static char * +virHashStrPrintHuman(const void *name) +{ + return g_strdup(name); +} + + static void virHashStrFree(void *name) { VIR_FREE(name); @@ -136,6 +145,7 @@ virHashTablePtr virHashCreateFull(ssize_t size, virHashKeyCode keyCode, virHashKeyEqual keyEqual, virHashKeyCopy keyCopy, + virHashKeyPrintHuman keyPrint, virHashKeyFree keyFree) { virHashTablePtr table = NULL; @@ -153,6 +163,7 @@ virHashTablePtr virHashCreateFull(ssize_t size, table->keyCode = keyCode; table->keyEqual = keyEqual; table->keyCopy = keyCopy; + table->keyPrint = keyPrint; table->keyFree = keyFree; if (VIR_ALLOC_N(table->table, size) < 0) { @@ -180,6 +191,7 @@ virHashNew(virHashDataFree dataFree) virHashStrCode, virHashStrEqual, virHashStrCopy, + virHashStrPrintHuman, virHashStrFree); } @@ -200,6 +212,7 @@ virHashTablePtr virHashCreate(ssize_t size, virHashDataFree dataFree) virHashStrCode, virHashStrEqual, virHashStrCopy, + virHashStrPrintHuman, virHashStrFree); } @@ -353,8 +366,13 @@ virHashAddOrUpdateEntry(virHashTablePtr table, const void *name, entry->payload = userdata; return 0; } else { - virReportError(VIR_ERR_INTERNAL_ERROR, "%s", - _("Duplicate key")); + g_autofree char *keystr = NULL; + + if (table->keyPrint) + keystr = table->keyPrint(name); + + virReportError(VIR_ERR_INTERNAL_ERROR, + _("Duplicate hash table key '%s'"), NULLSTR(keystr)); return -1; } } diff --git a/src/util/virhash.h b/src/util/virhash.h index 6318c0b3cd..08f99d8a3d 100644 --- a/src/util/virhash.h +++ b/src/util/virhash.h @@ -86,6 +86,18 @@ typedef bool (*virHashKeyEqual)(const void *namea, const void *nameb); * Returns a newly allocated copy of @name */ typedef void *(*virHashKeyCopy)(const void *name); +/** + * virHashKeyPrintHuman: + * @name: the hash key + * + * Get a human readable version of the key for error messages. Caller + * will free the returned string. + * + * Returns a string representation of the key for use in error messages. Caller + * promises to always free the returned string. + */ +typedef char *(*virHashKeyPrintHuman) (const void *name); + /** * virHashKeyFree: * @name: the hash key @@ -108,6 +120,7 @@ virHashTablePtr virHashCreateFull(ssize_t size, virHashKeyCode keyCode, virHashKeyEqual keyEqual, virHashKeyCopy keyCopy, + virHashKeyPrintHuman keyPrint, virHashKeyFree keyFree); void virHashFree(virHashTablePtr table); ssize_t virHashSize(const virHashTable *table); -- 2.24.1
Test that adding a duplicate entry is rejected properly. This also allows to see the error message of the duplicate key addition in verbose mode. Signed-off-by: Peter Krempa <pkrempa@redhat.com> --- tests/virhashtest.c | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/tests/virhashtest.c b/tests/virhashtest.c index 66fa3a428e..4d05cbb0f8 100644 --- a/tests/virhashtest.c +++ b/tests/virhashtest.c @@ -510,6 +510,28 @@ testHashEqual(const void *data G_GNUC_UNUSED) } +static int +testHashDuplicate(const void *data G_GNUC_UNUSED) +{ + g_autoptr(virHashTable) hash = NULL; + + if (!(hash = virHashCreate(0, NULL))) + return -1; + + if (virHashAddEntry(hash, "a", NULL) < 0) { + VIR_TEST_VERBOSE("\nfailed to add key 'a' to hash"); + return -1; + } + + if (virHashAddEntry(hash, "a", NULL) >= 0) { + VIR_TEST_VERBOSE("\nadding of key 'a' should have failed"); + return -1; + } + + return 0; +} + + static int mymain(void) { @@ -546,6 +568,7 @@ mymain(void) DO_TEST("Search", Search); DO_TEST("GetItems", GetItems); DO_TEST("Equal", Equal); + DO_TEST("Duplicate entry", Duplicate); return (ret == 0) ? EXIT_SUCCESS : EXIT_FAILURE; } -- 2.24.1
On Thu, Jan 16, 2020 at 15:34:29 +0100, Peter Krempa wrote:
See patch 1 for rationale.
Peter Krempa (2): util: hash: Improve debugability of "Duplicate key" error message tests: hash: Test case for adding duplicate hash entry
Ping? https://bugzilla.redhat.com/show_bug.cgi?id=1791790 demonstrates the new error message and how much more helpful than the current state it is.
On 1/16/20 3:34 PM, Peter Krempa wrote:
See patch 1 for rationale.
Peter Krempa (2): util: hash: Improve debugability of "Duplicate key" error message tests: hash: Test case for adding duplicate hash entry
src/conf/domain_addr.c | 9 +++++++++ src/util/vircgroup.c | 8 ++++++++ src/util/virhash.c | 22 ++++++++++++++++++++-- src/util/virhash.h | 13 +++++++++++++ tests/virhashtest.c | 23 +++++++++++++++++++++++ 5 files changed, 73 insertions(+), 2 deletions(-)
Reviewed-by: Michal Privoznik <mprivozn@redhat.com> Michal
participants (2)
-
Michal Privoznik -
Peter Krempa