[libvirt] [PATCH] qemu: fix double free in qemuMigrationPrepareDirect
Remove assignment of the string freed by virURIFree to hostname, since it's not used anywhere. Double free introduced by ddf8ad8, useless code introduced by f03dcc5. https://bugzilla.redhat.com/show_bug.cgi?id=977961 --- src/qemu/qemu_migration.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index f9fd64f..fc70f31 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2572,8 +2572,6 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, virReportError(VIR_ERR_INVALID_ARG, _("missing host in migration" " URI: %s"), uri_in); goto cleanup; - } else { - hostname = uri->server; } if (uri->port == 0) { -- 1.8.1.5
On 07/10/2013 12:51 PM, Ján Tomko wrote:
Remove assignment of the string freed by virURIFree to hostname, since it's not used anywhere.
Double free introduced by ddf8ad8, useless code introduced by f03dcc5.
https://bugzilla.redhat.com/show_bug.cgi?id=977961 --- src/qemu/qemu_migration.c | 2 -- 1 file changed, 2 deletions(-)
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c index f9fd64f..fc70f31 100644 --- a/src/qemu/qemu_migration.c +++ b/src/qemu/qemu_migration.c @@ -2572,8 +2572,6 @@ qemuMigrationPrepareDirect(virQEMUDriverPtr driver, virReportError(VIR_ERR_INVALID_ARG, _("missing host in migration" " URI: %s"), uri_in); goto cleanup; - } else { - hostname = uri->server; }
if (uri->port == 0) {
ACK, Martin
participants (2)
-
Ján Tomko -
Martin Kletzander