[libvirt] [jenkins-ci PATCH 1/2] guests: enable {media, tree}uris tests for libosinfo
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- guests/playbooks/build/projects/libosinfo.yml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/guests/playbooks/build/projects/libosinfo.yml b/guests/playbooks/build/projects/libosinfo.yml index c29053b..3c941d2 100644 --- a/guests/playbooks/build/projects/libosinfo.yml +++ b/guests/playbooks/build/projects/libosinfo.yml @@ -9,6 +9,11 @@ - include: '{{ playbook_base }}/jobs/autotools-build-job.yml' - include: '{{ playbook_base }}/jobs/autotools-syntax-check-job.yml' - include: '{{ playbook_base }}/jobs/autotools-check-job.yml' + vars: + local_env: | + # export LIBOSINFO_NETWORK_TESTS in order to run both + # mediauris and treeuris tests + export LIBOSINFO_NETWORK_TESTS=1 - include: '{{ playbook_base }}/jobs/autotools-rpm-job.yml' vars: machines: '{{ rpm_machines }}' -- 2.17.1
Both media and tree uris tests are only run when LIBOSINFO_NETWORK_TESTS is set. Let's have those enabled in order to early catch URL changes in osinfo-db. Signed-off-by: Fabiano Fidêncio <fidencio@redhat.com> --- projects/libosinfo.yaml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/projects/libosinfo.yaml b/projects/libosinfo.yaml index 55a4817..d9e8445 100644 --- a/projects/libosinfo.yaml +++ b/projects/libosinfo.yaml @@ -12,6 +12,10 @@ parent_jobs: 'libosinfo-master-build' - autotools-check-job: parent_jobs: 'libosinfo-master-syntax-check' + local_env: | + # export LIBOSINFO_NETWORK_TESTS in order to run both + # mediauris and treeuris tests + export LIBOSINFO_NETWORK_TESTS=1 - autotools-rpm-job: parent_jobs: 'libosinfo-master-check' machines: '{rpm_machines}' -- 2.17.1
Please include a cover letter when sending more than a single patch to libvir-list. On Mon, 2018-09-03 at 15:02 +0200, Fabiano Fidêncio wrote: [...]
- include: '{{ playbook_base }}/jobs/autotools-check-job.yml' + vars: + local_env: | + # export LIBOSINFO_NETWORK_TESTS in order to run both + # mediauris and treeuris tests + export LIBOSINFO_NETWORK_TESTS=1
The above should be indented by two fewer spaces :) The comment also doesn't need to repeat the variable name or contain that much information really: Run tests that require network connectivity or something like that would be enough. Anyway, the new tests seem to be failing on all platforms at the moment. Do you want to address the issue before changing the CI environment, or would seeing the CI failures help you in fixing it and should thus go in first? -- Andrea Bolognani / Red Hat / Virtualization
On Mon, Sep 3, 2018 at 5:26 PM, Andrea Bolognani <abologna@redhat.com> wrote:
Please include a cover letter when sending more than a single patch to libvir-list.
On Mon, 2018-09-03 at 15:02 +0200, Fabiano Fidêncio wrote: [...]
- include: '{{ playbook_base }}/jobs/autotools-check-job.yml' + vars: + local_env: | + # export LIBOSINFO_NETWORK_TESTS in order to run both + # mediauris and treeuris tests + export LIBOSINFO_NETWORK_TESTS=1
The above should be indented by two fewer spaces :)
The comment also doesn't need to repeat the variable name or contain that much information really:
Run tests that require network connectivity
or something like that would be enough.
Right, I'll fix this and submit a v2.
Anyway, the new tests seem to be failing on all platforms at the moment. Do you want to address the issue before changing the CI environment, or would seeing the CI failures help you in fixing it and should thus go in first?
I do want to address the issues before changing the CI and then the patchset could be merged. The main problem now is that Fedora ISO's for f27 were removed from the standard location but still not added to the archives. I'll re-send the patchset fixing your comments and also send an osinfo-db patch as soon as the ISOs are added to the archive and only then we can have the v2 merged.
-- Andrea Bolognani / Red Hat / Virtualization
Thanks for the review, Andrea! Best Regards, -- Fabiano Fidêncio
participants (2)
-
Andrea Bolognani -
Fabiano Fidêncio