[libvirt] Fix -Werror build error regarding to '#ifdef IFF_VNET_HDR'
Hi! Our build bot found a build error when building libVirt with -Werror introduced in b4f62abbf1191c8fbab3306b4bf2f2567e18067f kvm/virtio: Set IFF_VNET_HDR when setting up tap fds The attached patch kind of fixes the build error but I'm not sure, if this is the final solution for this problem, though... Ciao Max -- The real problem with C++ for kernel modules is: the language just sucks. -- Linus Torvalds
On Thu, Jul 30, 2009 at 04:15:01PM +0200, Maximilian Wilhelm wrote:
Hi!
Our build bot found a build error when building libVirt with -Werror introduced in b4f62abbf1191c8fbab3306b4bf2f2567e18067f kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
The attached patch kind of fixes the build error but I'm not sure, if this is the final solution for this problem, though...
Err can you tell us what the error report from the compiler was ? I assume it was unused warnings for brSetInterfaceMtu() and the parameter vnet_hdr of brAddTap(), right ? thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Anno domini 2009 Daniel Veillard scripsit: Hi!
Our build bot found a build error when building libVirt with -Werror introduced in b4f62abbf1191c8fbab3306b4bf2f2567e18067f kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
The attached patch kind of fixes the build error but I'm not sure, if this is the final solution for this problem, though...
Err can you tell us what the error report from the compiler was ? I assume it was unused warnings for brSetInterfaceMtu() and the parameter vnet_hdr of brAddTap(), right ?
Sorry, I should have written this. The problem is bridge.c:464: error: unused parameter 'vnet_hdr' and if (void)ed bridge.c:406: error: 'brProbeVnetHdr' defined but not used Ciao Max -- They that give up essential liberty to obtain temporary safety, deserve neither liberty nor safety. (Ben Franklin)
On Thu, Jul 30, 2009 at 04:38:26PM +0200, Maximilian Wilhelm wrote:
Anno domini 2009 Daniel Veillard scripsit:
Hi!
Our build bot found a build error when building libVirt with -Werror introduced in b4f62abbf1191c8fbab3306b4bf2f2567e18067f kvm/virtio: Set IFF_VNET_HDR when setting up tap fds
The attached patch kind of fixes the build error but I'm not sure, if this is the final solution for this problem, though...
Err can you tell us what the error report from the compiler was ? I assume it was unused warnings for brSetInterfaceMtu() and the parameter vnet_hdr of brAddTap(), right ?
Sorry, I should have written this.
The problem is bridge.c:464: error: unused parameter 'vnet_hdr' and if (void)ed bridge.c:406: error: 'brProbeVnetHdr' defined but not used
Okay, what I expected but better being sure, makes sense, applied, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
participants (2)
-
Daniel Veillard -
Maximilian Wilhelm