[libvirt PATCH 0/2] util: audit: cleanups (include epistles)
Just a small series this time. Ján Tomko (2): util: audit: drop support for old libaudit util: viraudit: remove unnecessary includes src/util/viraudit.c | 15 --------------- 1 file changed, 15 deletions(-) -- 2.24.1
Virtualization event types were added in 2.0.5: https://github.com/linux-audit/audit-userspace/commit/3755e9ff Even Ubuntu 14.04 (which we don't support) has 2.3.2. Signed-off-by: Ján Tomko <jtomko@redhat.com> --- src/util/viraudit.c | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/util/viraudit.c b/src/util/viraudit.c index 20eb3f3621..c8346aa81b 100644 --- a/src/util/viraudit.c +++ b/src/util/viraudit.c @@ -35,18 +35,6 @@ VIR_LOG_INIT("util.audit"); -/* Provide the macros in case the header file is old. - FIXME: should be removed. */ -#ifndef AUDIT_VIRT_CONTROL -# define AUDIT_VIRT_CONTROL 2500 /* Start, Pause, Stop VM */ -#endif -#ifndef AUDIT_VIRT_RESOURCE -# define AUDIT_VIRT_RESOURCE 2501 /* Resource assignment */ -#endif -#ifndef AUDIT_VIRT_MACHINE_ID -# define AUDIT_VIRT_MACHINE_ID 2502 /* Binding of label to VM */ -#endif - #define VIR_FROM_THIS VIR_FROM_AUDIT #if WITH_AUDIT -- 2.24.1
Signed-off-by: Ján Tomko <jtomko@redhat.com> --- src/util/viraudit.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/util/viraudit.c b/src/util/viraudit.c index c8346aa81b..13421653b9 100644 --- a/src/util/viraudit.c +++ b/src/util/viraudit.c @@ -24,14 +24,11 @@ #ifdef WITH_AUDIT # include <libaudit.h> #endif -#include <unistd.h> #include "virerror.h" #include "virlog.h" #include "viraudit.h" #include "virfile.h" -#include "viralloc.h" -#include "virstring.h" VIR_LOG_INIT("util.audit"); -- 2.24.1
On 3/5/20 10:22 AM, Ján Tomko wrote:
Just a small series this time.
Ján Tomko (2): util: audit: drop support for old libaudit util: viraudit: remove unnecessary includes
src/util/viraudit.c | 15 --------------- 1 file changed, 15 deletions(-)
Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>
participants (2)
-
Daniel Henrique Barboza -
Ján Tomko