[libvirt] wrong path of domblkstat

Hi all: I tried to use virsh domblkstat to get block information of a vm(xen para-virtualized), and it returns error message like this error: Failed to get block stats vm1 hda error: internal error read_bd_stats: Failed to read any block statistics I found the code in \src\xen\block_stats.c is wrong in line 121 "/sys/devices/xen-backend/vbd-%d-%d/statistics/%s", should be "/sys/devices/vbd-%d-%d/statistics/%s", in line 127 should be "/sys/devices/tap-%d-%d/statistics/%s", After modified and rebuild the soure code,the domblkstat can work fine. Anyone can help to update the code in the git?

On 06/10/10 - 10:46:52AM, jbuy0710 wrote:
Hi all:
I tried to use virsh domblkstat to get block information of a vm(xen para-virtualized), and it returns error message like this error: Failed to get block stats vm1 hda error: internal error read_bd_stats: Failed to read any block statistics
I found the code in \src\xen\block_stats.c is wrong
in line 121 "/sys/devices/xen-backend/vbd-%d-%d/statistics/%s", should be "/sys/devices/vbd-%d-%d/statistics/%s", in line 127 should be "/sys/devices/tap-%d-%d/statistics/%s",
After modified and rebuild the soure code,the domblkstat can work fine. Anyone can help to update the code in the git?
Unfortunately, it's not that simple. Older style Xen (like what is in RHEL-5) use the "/sys/devices/xen-backend" path; I'm assuming new-style Xen (like you are possibly using) use the new style path. What dom0 kernel version are you using? If you submit a patch to try out both paths, that will probably be acceptable. -- Chris Lalancette
participants (2)
-
Chris Lalancette
-
jbuy0710