On 07/20/2011 02:15 PM, Daniel P. Berrange wrote:
On Wed, Jul 20, 2011 at 02:14:43PM -0400, Cole Robinson wrote:
> Though we prefer users to have SSH keys setup, virt-manager users still
> depend on remote SSH connections to launch a password dialog. This fixes
> launch ssh-askpass
>
> Fix suggested by danpb
> ---
> src/rpc/virnetsocket.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/src/rpc/virnetsocket.c b/src/rpc/virnetsocket.c
> index 4403fc4..6605aa3 100644
> --- a/src/rpc/virnetsocket.c
> +++ b/src/rpc/virnetsocket.c
> @@ -604,6 +604,7 @@ int virNetSocketNewConnectSSH(const char *nodename,
> virCommandAddEnvPassCommon(cmd);
> virCommandAddEnvPass(cmd, "SSH_AUTH_SOCK");
> virCommandAddEnvPass(cmd, "SSH_ASKPASS");
> + virCommandAddEnvPass(cmd, "DISPLAY");
> virCommandClearCaps(cmd);
>
> if (service)
ACK
Daniel
Thanks, pushed now.
- Cole