[libvirt] [PATCH 2/2] RPM spec file updated with glusterfs dependency
Add new dependency for glusterfs rpm. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index 1e8a8ef..ccef3a5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -86,6 +86,8 @@ BuildRequires: util-linux # For showmount in FS driver (netfs discovery) BuildRequires: nfs-utils Requires: nfs-utils +# For glusterfs +Requires: glusterfs-client >= 2.0.2 %endif %if %{with_qemu} # From QEMU RPMs -- 1.6.0.6
On Tue, Jul 07, 2009 at 05:47:56AM -0700, Harshavardhana wrote:
Add new dependency for glusterfs rpm. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 1e8a8ef..ccef3a5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -86,6 +86,8 @@ BuildRequires: util-linux # For showmount in FS driver (netfs discovery) BuildRequires: nfs-utils Requires: nfs-utils +# For glusterfs +Requires: glusterfs-client >= 2.0.2 %endif %if %{with_qemu} # From QEMU RPMs
This isn't technically a hard requirement, but the extra RPMs it pulls in are quite small really, so its reasonable Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
Daniel, Yes indeed but as in libvirt is a standalone project it should have its own dependencies. Right now this only effects the ovirt-node-image part. Was thinking of patching virt-manager also?. I have other doubts are you all planning for a generic function for mounting filesystems agnostic of the options provided to mount command?. As it could be achieved but i just wanted if any of you are working on it already so not to duplicate efforts? Thanks. Regards -- Harshavardhana Z Research Inc http://www.zresearch.com/ On Tue, Jul 7, 2009 at 10:25 PM, Daniel P. Berrange <berrange@redhat.com>wrote:
On Tue, Jul 07, 2009 at 05:47:56AM -0700, Harshavardhana wrote:
Add new dependency for glusterfs rpm. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 1e8a8ef..ccef3a5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -86,6 +86,8 @@ BuildRequires: util-linux # For showmount in FS driver (netfs discovery) BuildRequires: nfs-utils Requires: nfs-utils +# For glusterfs +Requires: glusterfs-client >= 2.0.2 %endif %if %{with_qemu} # From QEMU RPMs
This isn't technically a hard requirement, but the extra RPMs it pulls in are quite small really, so its reasonable
Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/:| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org:| |: http://autobuild.org -o- http://search.cpan.org/~danberr/<http://search.cpan.org/%7Edanberr/>:| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
On Tue, Jul 07, 2009 at 05:55:16PM +0100, Daniel P. Berrange wrote:
On Tue, Jul 07, 2009 at 05:47:56AM -0700, Harshavardhana wrote:
Add new dependency for glusterfs rpm. --- libvirt.spec.in | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/libvirt.spec.in b/libvirt.spec.in index 1e8a8ef..ccef3a5 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -86,6 +86,8 @@ BuildRequires: util-linux # For showmount in FS driver (netfs discovery) BuildRequires: nfs-utils Requires: nfs-utils +# For glusterfs +Requires: glusterfs-client >= 2.0.2 %endif %if %{with_qemu} # From QEMU RPMs
This isn't technically a hard requirement, but the extra RPMs it pulls in are quite small really, so its reasonable
yeah, I was wondering about the size too, but it pulls less than an megabyte of RPM so I think it's fine. Both patches applied and commited, thanks ! Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Tue, Jul 07, 2009 at 05:47:56AM -0700, Harshavardhana wrote:
Add new dependency for glusterfs rpm. [...] +# For glusterfs +Requires: glusterfs-client >= 2.0.2 %endif
why 2.0.2 ? is taht a hard requirement ? In Fedora/Rawhide we have only 2.0.1 at the moment, Daniel -- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
Hi Daniel, That release and above have few enhancements for VM related work, but the Fedora maintainer has not yet updated to our latest releases. I have communicated this to him but yet to receive a reply and when he will update with the latest release. I think you can remove the value its not a hard requirement. Regards -- Harshavardhana Gluster - http://www.gluster.com On Tue, Jul 28, 2009 at 3:18 PM, Daniel Veillard <veillard@redhat.com>wrote:
On Tue, Jul 07, 2009 at 05:47:56AM -0700, Harshavardhana wrote:
Add new dependency for glusterfs rpm. [...] +# For glusterfs +Requires: glusterfs-client >= 2.0.2 %endif
why 2.0.2 ? is taht a hard requirement ? In Fedora/Rawhide we have only 2.0.1 at the moment,
Daniel
-- Daniel Veillard | libxml Gnome XML XSLT toolkit http://xmlsoft.org/ daniel@veillard.com | Rpmfind RPM search engine http://rpmfind.net/ http://veillard.com/ | virtualization library http://libvirt.org/
On Tue, 2009-07-28 at 15:23 +0530, Harshavardhana wrote:
Hi Daniel,
That release and above have few enhancements for VM related work, but the Fedora maintainer has not yet updated to our latest releases. I have communicated this to him but yet to receive a reply and when he will update with the latest release. I think you can remove the value its not a hard requirement.
Thanks, I committed the patch below Cheers, Mark. From: Mark McLoughlin <markmc@redhat.com> Subject: [PATCH] Reduce glusterfs dependency to 2.0.1 * libvirt.spec.in: require glusterfs-client >= 2.0.1 --- libvirt.spec.in | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libvirt.spec.in b/libvirt.spec.in index a5b861d..918d64c 100644 --- a/libvirt.spec.in +++ b/libvirt.spec.in @@ -97,7 +97,7 @@ BuildRequires: util-linux BuildRequires: nfs-utils Requires: nfs-utils # For glusterfs -Requires: glusterfs-client >= 2.0.2 +Requires: glusterfs-client >= 2.0.1 %endif %if %{with_qemu} # From QEMU RPMs -- 1.6.2.5
participants (4)
-
Daniel P. Berrange -
Daniel Veillard -
Harshavardhana -
Mark McLoughlin