[libvirt-tck PATCH] gitlab: add CONTRIBUTING.rst file to indicate use of merge requests
With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we no longer wish to have patches sent to the mailing list, and thus the git-publish config is removed. Signed-off-by: Erik Skultety <eskultet@redhat.com> --- I was notified by jtomko, that we still haven't officially made the switch in TCK, but I was already submitting merge requests. .gitpublish | 4 ---- CONTRIBUTING.rst | 28 ++++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 4 deletions(-) delete mode 100644 .gitpublish create mode 100644 CONTRIBUTING.rst diff --git a/.gitpublish b/.gitpublish deleted file mode 100644 index 1cebab1..0000000 --- a/.gitpublish +++ /dev/null @@ -1,4 +0,0 @@ -[gitpublishprofile "default"] -base = master -to = libvir-list@redhat.com -prefix = libvirt-tck PATCH diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst new file mode 100644 index 0000000..ed8ee44 --- /dev/null +++ b/CONTRIBUTING.rst @@ -0,0 +1,28 @@ +=========================== +Contributing to libvirt-tck +=========================== + +The libvirt TCK project accepts code contributions via merge requests +on the GitLab project: + +https://gitlab.com/libvirt/libvirt-tck/-/merge_requests + +It is required that automated CI pipelines succeed before a merge request +will be accepted. The global pipeline status for the ``master`` branch is +visible at: + +https://gitlab.com/libvirt/libvirt-tck/pipelines + +CI pipeline results for merge requests will be visible via the contributors' +own private repository fork: + +https://gitlab.com/yourusername/libvirt-tck/pipelines + +Contributions submitted to the project must be in compliance with the +Developer Certificate of Origin Version 1.1. This is documented at: + +https://developercertificate.org/ + +To indicate compliance, each commit in a series must have a "Signed-off-by" +tag with the submitter's name and email address. This can be added by passing +the ``-s`` flag to ``git commit`` when creating the patches. -- 2.26.2
On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we no longer wish to have patches sent to the mailing list, and thus the git-publish config is removed.
We don't actually have any CI running for TCK yet.
Signed-off-by: Erik Skultety <eskultet@redhat.com> ---
I was notified by jtomko, that we still haven't officially made the switch in TCK, but I was already submitting merge requests.
.gitpublish | 4 ---- CONTRIBUTING.rst | 28 ++++++++++++++++++++++++++++ 2 files changed, 28 insertions(+), 4 deletions(-) delete mode 100644 .gitpublish create mode 100644 CONTRIBUTING.rst
diff --git a/.gitpublish b/.gitpublish deleted file mode 100644 index 1cebab1..0000000 --- a/.gitpublish +++ /dev/null @@ -1,4 +0,0 @@ -[gitpublishprofile "default"] -base = master -to = libvir-list@redhat.com -prefix = libvirt-tck PATCH diff --git a/CONTRIBUTING.rst b/CONTRIBUTING.rst new file mode 100644 index 0000000..ed8ee44 --- /dev/null +++ b/CONTRIBUTING.rst @@ -0,0 +1,28 @@ +=========================== +Contributing to libvirt-tck +=========================== + +The libvirt TCK project accepts code contributions via merge requests +on the GitLab project: + +https://gitlab.com/libvirt/libvirt-tck/-/merge_requests + +It is required that automated CI pipelines succeed before a merge request +will be accepted. The global pipeline status for the ``master`` branch is +visible at: + +https://gitlab.com/libvirt/libvirt-tck/pipelines + +CI pipeline results for merge requests will be visible via the contributors' +own private repository fork: + +https://gitlab.com/yourusername/libvirt-tck/pipelines + +Contributions submitted to the project must be in compliance with the +Developer Certificate of Origin Version 1.1. This is documented at: + +https://developercertificate.org/ + +To indicate compliance, each commit in a series must have a "Signed-off-by" +tag with the submitter's name and email address. This can be added by passing +the ``-s`` flag to ``git commit`` when creating the patches. -- 2.26.2
Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Mon, Jun 08, 2020 at 10:02:07AM +0100, Daniel P. Berrangé wrote:
On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we no longer wish to have patches sent to the mailing list, and thus the git-publish config is removed.
We don't actually have any CI running for TCK yet.
True, bad wording for the commit message, but TCK is not a high-traffic libvirt project and since I already kind of started the trend I don't see a reason why we couldn't make it official, I'll reword the commit message if that is only what's needed. Erik
On Mon, Jun 08, 2020 at 12:10:53PM +0200, Erik Skultety wrote:
On Mon, Jun 08, 2020 at 10:02:07AM +0100, Daniel P. Berrangé wrote:
On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we no longer wish to have patches sent to the mailing list, and thus the git-publish config is removed.
We don't actually have any CI running for TCK yet.
True, bad wording for the commit message, but TCK is not a high-traffic libvirt project and since I already kind of started the trend I don't see a reason why we couldn't make it official, I'll reword the commit message if that is only what's needed.
Or just wait and I'll send a CI patch later today Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
On Mon, Jun 08, 2020 at 11:22:51AM +0100, Daniel P. Berrangé wrote:
On Mon, Jun 08, 2020 at 12:10:53PM +0200, Erik Skultety wrote:
On Mon, Jun 08, 2020 at 10:02:07AM +0100, Daniel P. Berrangé wrote:
On Thu, Jun 04, 2020 at 03:23:05PM +0200, Erik Skultety wrote:
With the introduction of automated CI pipelines, we are now ready to switch to using merge requests for the project. With this switch we no longer wish to have patches sent to the mailing list, and thus the git-publish config is removed.
We don't actually have any CI running for TCK yet.
True, bad wording for the commit message, but TCK is not a high-traffic libvirt project and since I already kind of started the trend I don't see a reason why we couldn't make it official, I'll reword the commit message if that is only what's needed.
Or just wait and I'll send a CI patch later today
This is merged now, so for this patch Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
participants (2)
-
Daniel P. Berrangé -
Erik Skultety