[libvirt] Memory leak in xen_inotify.c - Devel - Libvirt List Archives

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

2006

2005

December

[libvirt] Memory leak in xen_inotify.c

[libvirt] [PATCH] avoid format...

[libvirt] libvirt + xen 3.2.1...

Niraj Tolia

Saturday, 29 November 2008 Sat, 29 Nov '08

3:15 p.m.

Hi, It looks like xenInotifyOpen() in xen_inotify.c has an opendir() call. However, as there is no corresponding closedir() and opendir() uses malloc internally, valgrind reports this as a memory leak. Adding a closedir() to the end of this function should fix this. Cheers, Niraj

Reply

Show replies by date

Daniel P. Berrange

Sunday, 30 November Sun, 30 Nov

12:40 p.m.

On Sat, Nov 29, 2008 at 01:15:52PM -0800, Niraj Tolia wrote:

Hi, It looks like xenInotifyOpen() in xen_inotify.c has an opendir() call. However, as there is no corresponding closedir() and opendir() uses malloc internally, valgrind reports this as a memory leak. Adding a closedir() to the end of this function should fix this.

Thanks for the bug info, I've committed the following patch: diff -u -r1.1 xen_inotify.c --- xen_inotify.c 25 Nov 2008 10:44:53 -0000 1.1 +++ xen_inotify.c 30 Nov 2008 18:36:00 -0000 @@ -395,7 +395,7 @@ return -1; } } - + closedir(dh); } if ((priv->inotifyFD = inotify_init()) < 0) { Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://ovirt.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|

Reply

5835

days inactive

5836

days old

devel@lists.libvirt.org

Manage subscription

1 comments

2 participants

tags (0)

participants (2)

Daniel P. Berrange
Niraj Tolia