[libvirt] [RFC] Add iommu group commands
Hi, Currently, we need to assign the iommu group to guests manually. It needs to know the groups information. I think we can add some iommu group commands to provide users groups information. I can think of these commands as the following: #virsh group-list <--active> * list all the groups in the system with VFIO * --active: list the active groups which have been used by guests. #virsh group-devs <groupnum> * list the devices in the group. *If groupnum is not specified, it will list every groups' devices. # virsh group-dumpxml <groupnum> * dump the group's xml configuration. dumxml file for example: <iommuGroup number='1'> <address domain='0x0001' bus='0x40' slot='0x00' function='0x0'/> <address domain='0x0001' bus='0x40' slot='0x00' function='0x1'/> </iommuGroup> This information can also be got by #nodedev-dumpxml <device> But users still can't know all the groups and the devices in the group directly. Any suggestions? I want to add iommu symbol to the commands name, but it's too long. Thanks Li Zhang
On Tue, Sep 17, 2013 at 03:56:46PM +0800, Li Zhang wrote:
Hi,
Currently, we need to assign the iommu group to guests manually. It needs to know the groups information. I think we can add some iommu group commands to provide users groups information.
I can think of these commands as the following:
#virsh group-list <--active> * list all the groups in the system with VFIO * --active: list the active groups which have been used by guests.
#virsh group-devs <groupnum> * list the devices in the group. *If groupnum is not specified, it will list every groups' devices.
# virsh group-dumpxml <groupnum> * dump the group's xml configuration. dumxml file for example: <iommuGroup number='1'> <address domain='0x0001' bus='0x40' slot='0x00' function='0x0'/> <address domain='0x0001' bus='0x40' slot='0x00' function='0x1'/> </iommuGroup>
This information can also be got by #nodedev-dumpxml <device> But users still can't know all the groups and the devices in the group directly.
Any suggestions?
I'm not convinced we should add new APIs or commands for this. I think that an iommu group could just be presented as a new type of virtual device in the existing 'nodedev' APIs. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
On 2013年09月17日 21:39, Daniel P. Berrange wrote:
On Tue, Sep 17, 2013 at 03:56:46PM +0800, Li Zhang wrote:
Hi,
Currently, we need to assign the iommu group to guests manually. It needs to know the groups information. I think we can add some iommu group commands to provide users groups information.
I can think of these commands as the following:
#virsh group-list <--active> * list all the groups in the system with VFIO * --active: list the active groups which have been used by guests.
#virsh group-devs <groupnum> * list the devices in the group. *If groupnum is not specified, it will list every groups' devices.
# virsh group-dumpxml <groupnum> * dump the group's xml configuration. dumxml file for example: <iommuGroup number='1'> <address domain='0x0001' bus='0x40' slot='0x00' function='0x0'/> <address domain='0x0001' bus='0x40' slot='0x00' function='0x1'/> </iommuGroup>
This information can also be got by #nodedev-dumpxml <device> But users still can't know all the groups and the devices in the group directly.
Any suggestions? I'm not convinced we should add new APIs or commands for this.
I think that an iommu group could just be presented as a new type of virtual device in the existing 'nodedev' APIs.
Ah, okay, it sounds better if it can be presented in the existing 'nodedev' APIs. I will have a look at it. Thanks.
Regards, Daniel
participants (2)
-
Daniel P. Berrange -
Li Zhang