[PATCH 0/2] qemu: Couple of memleak fixes
*** BLURB HERE *** Michal Prívozník (2): qemuDomainStorageSourcePrivateDispose: Free httpcookie qemuBlockJobDataDisposeJobdata: Free data.commit.disabledBitmapsBase src/qemu/qemu_blockjob.c | 5 +++++ src/qemu/qemu_domain.c | 1 + 2 files changed, 6 insertions(+) -- 2.26.2
==156803== 58 (40 direct, 18 indirect) bytes in 1 blocks are definitely lost in loss record 306 of 463 ==156803== at 0x4839EC6: calloc (vg_replace_malloc.c:762) ==156803== by 0x5791AC0: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.6400.1) ==156803== by 0x48F60DC: virAlloc (viralloc.c:48) ==156803== by 0x18DD74: qemuStorageSourcePrivateDataAssignSecinfo (qemu_domain.c:2384) ==156803== by 0x18DFD5: qemuStorageSourcePrivateDataParse (qemu_domain.c:2433) ==156803== by 0x49EC884: virDomainStorageSourceParse (domain_conf.c:9857) ==156803== by 0x49ECBA3: virDomainDiskBackingStoreParse (domain_conf.c:9909) ==156803== by 0x49F129D: virDomainDiskDefParseXML (domain_conf.c:10785) ==156803== by 0x4A1804E: virDomainDefParseXML (domain_conf.c:21543) ==156803== by 0x4A1B60C: virDomainObjParseXML (domain_conf.c:22254) ==156803== by 0x4A1BFE9: virDomainObjParseNode (domain_conf.c:22429) ==156803== by 0x4A1C0B4: virDomainObjParseFile (domain_conf.c:22443 Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_domain.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c index a1b250fd0b..d0528dbfe0 100644 --- a/src/qemu/qemu_domain.c +++ b/src/qemu/qemu_domain.c @@ -1229,6 +1229,7 @@ qemuDomainStorageSourcePrivateDispose(void *obj) g_clear_pointer(&priv->secinfo, qemuDomainSecretInfoFree); g_clear_pointer(&priv->encinfo, qemuDomainSecretInfoFree); + g_clear_pointer(&priv->httpcookie, qemuDomainSecretInfoFree); } -- 2.26.2
==179663== 35 (24 direct, 11 indirect) bytes in 1 blocks are definitely lost in loss record 205 of 461 ==179663== at 0x4839EC6: calloc (vg_replace_malloc.c:762) ==179663== by 0x5791AC0: g_malloc0 (in /usr/lib64/libglib-2.0.so.0.6400.1) ==179663== by 0x190C79: qemuDomainObjPrivateXMLParseBlockjobDataCommit (qemu_domain.c:3295) ==179663== by 0x190DF7: qemuDomainObjPrivateXMLParseBlockjobDataSpecific (qemu_domain.c:3331) ==179663== by 0x19157D: qemuDomainObjPrivateXMLParseBlockjobData (qemu_domain.c:3469) ==179663== by 0x1918E8: qemuDomainObjPrivateXMLParseBlockjobs (qemu_domain.c:3498) ==179663== by 0x193841: qemuDomainObjPrivateXMLParse (qemu_domain.c:3944) ==179663== by 0x4A1BA9D: virDomainObjParseXML (domain_conf.c:22306) ==179663== by 0x4A1BFE9: virDomainObjParseNode (domain_conf.c:22429) ==179663== by 0x4A1C0B4: virDomainObjParseFile (domain_conf.c:22443) ==179663== by 0x1431E1: testCompareStatusXMLToXMLFiles (qemuxml2xmltest.c:61) ==179663== by 0x177722: virTestRun (testutils.c:142) Signed-off-by: Michal Privoznik <mprivozn@redhat.com> --- src/qemu/qemu_blockjob.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/qemu/qemu_blockjob.c b/src/qemu/qemu_blockjob.c index e51499532f..17dc08476b 100644 --- a/src/qemu/qemu_blockjob.c +++ b/src/qemu/qemu_blockjob.c @@ -84,6 +84,11 @@ qemuBlockJobDataDisposeJobdata(qemuBlockJobDataPtr job) virObjectUnref(job->data.backup.store); g_free(job->data.backup.bitmap); } + + if (job->type == QEMU_BLOCKJOB_TYPE_COMMIT || + job->type == QEMU_BLOCKJOB_TYPE_ACTIVE_COMMIT) { + virStringListFree(job->data.commit.disabledBitmapsBase); + } } -- 2.26.2
On Thu, May 14, 2020 at 11:37:40 +0200, Michal Privoznik wrote:
*** BLURB HERE ***
Michal Prívozník (2): qemuDomainStorageSourcePrivateDispose: Free httpcookie qemuBlockJobDataDisposeJobdata: Free data.commit.disabledBitmapsBase
src/qemu/qemu_blockjob.c | 5 +++++ src/qemu/qemu_domain.c | 1 + 2 files changed, 6 insertions(+)
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
participants (2)
-
Michal Privoznik -
Peter Krempa