[libvirt] usage of PKG_CHECK_ in libvirt

hi, I want to try to add some basic support for (linux-)vserver to libvirt and after reading some old mail threads I noticed you vanished PKG_CHECK_EXISTS back in 2008. is it still not welcomed in libvirt? PKG_CHECK_MODULES also? Thanks, Alejandro Mery

2010/10/14 Alejandro Mery <amery@geeks.cl>:
hi,
I want to try to add some basic support for (linux-)vserver to libvirt and after reading some old mail threads I noticed you vanished PKG_CHECK_EXISTS back in 2008. is it still not welcomed in libvirt? PKG_CHECK_MODULES also?
Thanks, Alejandro Mery
No idea about PKG_CHECK_EXISTS, but if you look at configure.ac you'll find multiple instances of PKG_CHECK_MODULES, so this one is perfectly fine. Matthias

On Thu, Oct 14, 2010 at 21:33, Matthias Bolte <matthias.bolte@googlemail.com> wrote:
No idea about PKG_CHECK_EXISTS, but if you look at configure.ac you'll find multiple instances of PKG_CHECK_MODULES, so this one is perfectly fine.
Thanks, I'll use PKG_CHECK_MODULES then Alejandro

On Thu, Oct 14, 2010 at 09:33:18PM +0200, Matthias Bolte wrote:
2010/10/14 Alejandro Mery <amery@geeks.cl>:
hi,
I want to try to add some basic support for (linux-)vserver to libvirt and after reading some old mail threads I noticed you vanished PKG_CHECK_EXISTS back in 2008. is it still not welcomed in libvirt? PKG_CHECK_MODULES also?
No idea about PKG_CHECK_EXISTS, but if you look at configure.ac you'll find multiple instances of PKG_CHECK_MODULES, so this one is perfectly fine.
We stopped using PKG_CHECK_EXISTS because it did not allow us to handle missing modules gracefully without terminating configure. CHECK_MODULES allows for flexible error handling. Daniel -- |: Red Hat, Engineering, London -o- http://people.redhat.com/berrange/ :| |: http://libvirt.org -o- http://virt-manager.org -o- http://deltacloud.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: GnuPG: 7D3B9505 -o- F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505 :|
participants (3)
-
Alejandro Mery
-
Daniel P. Berrange
-
Matthias Bolte